From: Jonathan Cameron <jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
To: samu.p.onkalo-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org
Cc: "eric.piel-VkQ1JFuSMpfAbQlEx87xDw@public.gmane.org"
<eric.piel-VkQ1JFuSMpfAbQlEx87xDw@public.gmane.org>,
"khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org"
<khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>,
"guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org"
<guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>,
"kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org"
<kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>,
"linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org"
<lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org>
Subject: Re: [lm-sensors] [RFC PATCH 2/9] hwmon: lis3: regulator control
Date: Sun, 03 Oct 2010 12:21:17 +0100 [thread overview]
Message-ID: <4CA8672D.2070801@cam.ac.uk> (raw)
In-Reply-To: <1286083558.2064.35.camel-Vo7XL3ix0D0UEupzmRo7jhl4MBrZKKet0E9HWUfgJXw@public.gmane.org>
...
>> subtle change here... Out of intererst, why did the top level lis3_dev
>> structure ever exist? (you can tell I haven't looked closely at this driver
>> before!) Can remove_fs return an error?
>
> Remove fs returns always 0.
>
> There are couple of bigger changes which somebody should do to this
> driver:
> - Change static lis3_dev structure to a dynamically allocated one//generalize
Definitely.
> - Add proper error handling to the driver.
Agreed, hopefully someone will step up and do it (good job for a starting out
kernel dev perhaps?)
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@cam.ac.uk>
To: samu.p.onkalo-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org
Cc: "eric.piel-VkQ1JFuSMpfAbQlEx87xDw@public.gmane.org"
<eric.piel-VkQ1JFuSMpfAbQlEx87xDw@public.gmane.org>,
"khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org"
<khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>,
"guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org"
<guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>,
"kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org"
<kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>,
"linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org"
<lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org>
Subject: Re: [lm-sensors] [RFC PATCH 2/9] hwmon: lis3: regulator control
Date: Sun, 03 Oct 2010 11:21:17 +0000 [thread overview]
Message-ID: <4CA8672D.2070801@cam.ac.uk> (raw)
In-Reply-To: <1286083558.2064.35.camel-Vo7XL3ix0D0UEupzmRo7jhl4MBrZKKet0E9HWUfgJXw@public.gmane.org>
...
>> subtle change here... Out of intererst, why did the top level lis3_dev
>> structure ever exist? (you can tell I haven't looked closely at this driver
>> before!) Can remove_fs return an error?
>
> Remove fs returns always 0.
>
> There are couple of bigger changes which somebody should do to this
> driver:
> - Change static lis3_dev structure to a dynamically allocated one//generalize
Definitely.
> - Add proper error handling to the driver.
Agreed, hopefully someone will step up and do it (good job for a starting out
kernel dev perhaps?)
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2010-10-03 11:21 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 11:46 [RFC PATCH 0/9] lis3 accelerator feature update Samu Onkalo
2010-10-01 11:46 ` [lm-sensors] " Samu Onkalo
[not found] ` <1285933616-16044-1-git-send-email-samu.p.onkalo-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-10-01 11:46 ` [RFC PATCH 1/9] hwmon: lis3: pm_runtime support Samu Onkalo
2010-10-01 11:46 ` [lm-sensors] " Samu Onkalo
[not found] ` <1285933616-16044-2-git-send-email-samu.p.onkalo-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-10-02 17:14 ` Jonathan Cameron
2010-10-02 17:14 ` Jonathan Cameron
[not found] ` <4CA76875.1040508-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
2010-10-03 5:03 ` Onkalo Samu
2010-10-03 5:03 ` Onkalo Samu
[not found] ` <1286082228.2064.14.camel-Vo7XL3ix0D0UEupzmRo7jhl4MBrZKKet0E9HWUfgJXw@public.gmane.org>
2010-10-03 11:18 ` Jonathan Cameron
2010-10-03 11:18 ` Jonathan Cameron
2010-10-01 11:46 ` [RFC PATCH 2/9] hwmon: lis3: regulator control Samu Onkalo
2010-10-01 11:46 ` [lm-sensors] " Samu Onkalo
[not found] ` <1285933616-16044-3-git-send-email-samu.p.onkalo-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-10-02 17:33 ` Jonathan Cameron
2010-10-02 17:33 ` Jonathan Cameron
[not found] ` <4CA76CDA.4040803-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
2010-10-03 5:25 ` Onkalo Samu
2010-10-03 5:25 ` Onkalo Samu
[not found] ` <1286083558.2064.35.camel-Vo7XL3ix0D0UEupzmRo7jhl4MBrZKKet0E9HWUfgJXw@public.gmane.org>
2010-10-03 11:21 ` Jonathan Cameron [this message]
2010-10-03 11:21 ` Jonathan Cameron
2010-10-03 11:53 ` David Lutolf
2010-10-03 11:53 ` [lm-sensors] " David Lutolf
2010-10-01 11:46 ` [RFC PATCH 3/9] hwmon: lis3: Cleanup interrupt handling Samu Onkalo
2010-10-01 11:46 ` [lm-sensors] " Samu Onkalo
2010-10-01 11:46 ` [RFC PATCH 4/9] hwmon: lis3: Update coordinates at polled device open Samu Onkalo
2010-10-01 11:46 ` [lm-sensors] [RFC PATCH 4/9] hwmon: lis3: Update coordinates at Samu Onkalo
2010-10-01 11:46 ` [RFC PATCH 5/9] hwmon: lis3: Power on corrections Samu Onkalo
2010-10-01 11:46 ` [lm-sensors] " Samu Onkalo
[not found] ` <1285933616-16044-6-git-send-email-samu.p.onkalo-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-10-02 17:43 ` Jonathan Cameron
2010-10-02 17:43 ` Jonathan Cameron
2010-10-01 11:46 ` [RFC PATCH 7/9] hwmon: lis3: Adjust fuzziness for 8 bit device Samu Onkalo
2010-10-01 11:46 ` [lm-sensors] [RFC PATCH 7/9] hwmon: lis3: Adjust fuzziness for 8 Samu Onkalo
2010-10-01 11:46 ` [RFC PATCH 8/9] hwmon: lis3: use block read to access data registers Samu Onkalo
2010-10-01 11:46 ` [lm-sensors] [RFC PATCH 8/9] hwmon: lis3: use block read to access Samu Onkalo
[not found] ` <1285933616-16044-9-git-send-email-samu.p.onkalo-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-10-04 11:41 ` [lm-sensors] [RFC PATCH 8/9] hwmon: lis3: use block read to access data registers Jonathan Cameron
2010-10-04 11:41 ` [lm-sensors] [RFC PATCH 8/9] hwmon: lis3: use block read to Jonathan Cameron
[not found] ` <4CA9BD6E.6040002-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
2010-10-04 13:29 ` [lm-sensors] [RFC PATCH 8/9] hwmon: lis3: use block read to access data registers Guenter Roeck
2010-10-04 13:29 ` [lm-sensors] [RFC PATCH 8/9] hwmon: lis3: use block read to Guenter Roeck
2010-10-01 11:46 ` [RFC PATCH 9/9] hwmon: lis3: Enhance lis3 selftest with IRQ line test Samu Onkalo
2010-10-01 11:46 ` [lm-sensors] [RFC PATCH 9/9] hwmon: lis3: Enhance lis3 selftest Samu Onkalo
2010-10-02 2:53 ` [RFC PATCH 0/9] lis3 accelerator feature update Guenter Roeck
2010-10-02 2:53 ` [lm-sensors] " Guenter Roeck
[not found] ` <20101002025311.GA25875-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
2010-10-02 8:25 ` Jean Delvare
2010-10-02 8:25 ` [lm-sensors] " Jean Delvare
[not found] ` <20101002102528.2955d95a-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2010-10-02 12:27 ` Jonathan Cameron
2010-10-02 12:27 ` Jonathan Cameron
[not found] ` <4CA72519.1070600-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
2010-10-02 13:16 ` Guenter Roeck
2010-10-02 13:16 ` Guenter Roeck
2010-10-01 11:46 ` [RFC PATCH 6/9] hwmon: lis3: New parameters to platform data Samu Onkalo
2010-10-01 11:46 ` [lm-sensors] [RFC PATCH 6/9] hwmon: lis3: New parameters to Samu Onkalo
[not found] ` <1285933616-16044-7-git-send-email-samu.p.onkalo-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-10-04 11:37 ` [lm-sensors] [RFC PATCH 6/9] hwmon: lis3: New parameters to platform data Jonathan Cameron
2010-10-04 11:37 ` [lm-sensors] [RFC PATCH 6/9] hwmon: lis3: New parameters Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA8672D.2070801@cam.ac.uk \
--to=jic23-kwpb1pkirijaa/9udqfwiw@public.gmane.org \
--cc=eric.piel-VkQ1JFuSMpfAbQlEx87xDw@public.gmane.org \
--cc=guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
--cc=samu.p.onkalo-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.