Re: [PATCH v3 11/20] Staging: rtl8192su: Makefile: cleaned up Makefile

All of lore.kernel.org
 help / color / mirror / Atom feed

From: walter harms <wharms@bfs.de>
To: Tracey Dent <tdent48227@gmail.com>
Cc: greg@kroah.com, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org, sam@ravnborg.org
Subject: Re: [PATCH v3 11/20] Staging: rtl8192su: Makefile: cleaned up Makefile
Date: Sun, 03 Oct 2010 12:42:47 +0000	[thread overview]
Message-ID: <4CA87A47.6030007@bfs.de> (raw)
In-Reply-To: <1286037489-28439-11-git-send-email-tdent48227@gmail.com>



Tracey Dent schrieb:
> Changed to use the proper ccflags-y option
> 
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> ---
>  drivers/staging/rtl8192su/Makefile |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192su/Makefile b/drivers/staging/rtl8192su/Makefile
> index 7133894..1120c04 100644
> --- a/drivers/staging/rtl8192su/Makefile
> +++ b/drivers/staging/rtl8192su/Makefile
> @@ -1,12 +1,12 @@
>  NIC_SELECT = RTL8192SU
>  
> -EXTRA_CFLAGS += -std=gnu89
> -EXTRA_CFLAGS += -O2
> +ccflags-y := -std=gnu89
> +ccflags-y += -O2
>  


I still do not think that -O2 belongs here.
it should simply be removed.

re,
 wh



> -EXTRA_CFLAGS += -DJACKSON_NEW_RX
> -EXTRA_CFLAGS += -DTHOMAS_BEACON
> +ccflags-y += -DJACKSON_NEW_RX
> +ccflags-y += -DTHOMAS_BEACON
>  
> -#EXTRA_CFLAGS += -DMUTIPLE_BULK_OUT
> +#ccflags-y += -DMUTIPLE_BULK_OUT
>  
>  r8192s_usb-objs :=		\
>  	r8192U_wx.o		\

WARNING: multiple messages have this Message-ID (diff)

From: walter harms <wharms@bfs.de>
To: Tracey Dent <tdent48227@gmail.com>
Cc: greg@kroah.com, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org, sam@ravnborg.org
Subject: Re: [PATCH v3 11/20] Staging: rtl8192su: Makefile: cleaned up Makefile cflag lines
Date: Sun, 03 Oct 2010 14:42:47 +0200	[thread overview]
Message-ID: <4CA87A47.6030007@bfs.de> (raw)
In-Reply-To: <1286037489-28439-11-git-send-email-tdent48227@gmail.com>



Tracey Dent schrieb:
> Changed to use the proper ccflags-y option
> 
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> ---
>  drivers/staging/rtl8192su/Makefile |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192su/Makefile b/drivers/staging/rtl8192su/Makefile
> index 7133894..1120c04 100644
> --- a/drivers/staging/rtl8192su/Makefile
> +++ b/drivers/staging/rtl8192su/Makefile
> @@ -1,12 +1,12 @@
>  NIC_SELECT = RTL8192SU
>  
> -EXTRA_CFLAGS += -std=gnu89
> -EXTRA_CFLAGS += -O2
> +ccflags-y := -std=gnu89
> +ccflags-y += -O2
>  


I still do not think that -O2 belongs here.
it should simply be removed.

re,
 wh



> -EXTRA_CFLAGS += -DJACKSON_NEW_RX
> -EXTRA_CFLAGS += -DTHOMAS_BEACON
> +ccflags-y += -DJACKSON_NEW_RX
> +ccflags-y += -DTHOMAS_BEACON
>  
> -#EXTRA_CFLAGS += -DMUTIPLE_BULK_OUT
> +#ccflags-y += -DMUTIPLE_BULK_OUT
>  
>  r8192s_usb-objs :=		\
>  	r8192U_wx.o		\

next prev parent reply	other threads:[~2010-10-03 12:42 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-02 16:37 [PATCH v3 01/20] Staging: cx25821: Makefile: cleaned up Makefile cflag lines Tracey Dent
2010-10-02 16:37 ` Tracey Dent
2010-10-02 16:37 ` [PATCH v3 02/20] Staging: cxt1e1: " Tracey Dent
2010-10-02 16:37   ` Tracey Dent
2010-10-02 16:37 ` [PATCH v3 03/20] Staging: dream: " Tracey Dent
2010-10-02 16:37   ` Tracey Dent
2010-10-02 16:37 ` [PATCH v3 04/20] Staging: dream: camera: " Tracey Dent
2010-10-02 16:37   ` Tracey Dent
2010-10-02 16:37 ` [PATCH v3 05/20] Staging: dream: qdsp5: " Tracey Dent
2010-10-02 16:37   ` Tracey Dent
2010-10-02 16:37 ` [PATCH v3 06/20] Stagng: easycap: " Tracey Dent
2010-10-02 16:37   ` Tracey Dent
2010-10-02 16:37 ` [PATCH v3 07/20] Staging: rt2860: " Tracey Dent
2010-10-02 16:37   ` Tracey Dent
2010-10-02 16:37 ` [PATCH v3 08/20] Staging: rt2870: " Tracey Dent
2010-10-02 16:37   ` Tracey Dent
2010-10-02 16:37 ` [PATCH v3 09/20] Staging: rtl8187se: " Tracey Dent
2010-10-02 16:37   ` Tracey Dent
2010-10-03 12:47   ` [PATCH v3 09/20] Staging: rtl8187se: Makefile: cleaned up Makefile walter harms
2010-10-03 12:47     ` [PATCH v3 09/20] Staging: rtl8187se: Makefile: cleaned up Makefile cflag lines walter harms
2010-10-02 16:37 ` [PATCH v3 10/20] Staging: rtl8192e: " Tracey Dent
2010-10-02 16:37   ` Tracey Dent
2010-10-02 16:38 ` [PATCH v3 11/20] Staging: rtl8192su: " Tracey Dent
2010-10-02 16:38   ` Tracey Dent
2010-10-03 12:42   ` walter harms [this message]
2010-10-03 12:42     ` walter harms
2010-10-03 13:39     ` [PATCH v3 11/20] Staging: rtl8192su: Makefile: cleaned up T Dent
2010-10-03 13:39       ` [PATCH v3 11/20] Staging: rtl8192su: Makefile: cleaned up Makefile cflag lines T Dent
2010-10-05 19:02   ` [PATCH v3 11/20] Staging: rtl8192su: Makefile: cleaned up Greg KH
2010-10-05 19:02     ` [PATCH v3 11/20] Staging: rtl8192su: Makefile: cleaned up Makefile cflag lines Greg KH
2010-10-02 16:38 ` [PATCH v3 12/20] Staging: rtl8192su: ieee80211: " Tracey Dent
2010-10-02 16:38   ` Tracey Dent
2010-10-03 12:48   ` [PATCH v3 12/20] Staging: rtl8192su: ieee80211: Makefile: cleaned walter harms
2010-10-03 12:48     ` [PATCH v3 12/20] Staging: rtl8192su: ieee80211: Makefile: cleaned up Makefile cflag lines walter harms
2010-10-05 19:02   ` [PATCH v3 12/20] Staging: rtl8192su: ieee80211: Makefile: Greg KH
2010-10-05 19:02     ` [PATCH v3 12/20] Staging: rtl8192su: ieee80211: Makefile: cleaned up Makefile cflag lines Greg KH
2010-10-05 21:47     ` [PATCH v3 12/20] Staging: rtl8192su: ieee80211: Makefile: cleaned T Dent
2010-10-05 21:47       ` [PATCH v3 12/20] Staging: rtl8192su: ieee80211: Makefile: cleaned up Makefile cflag lines T Dent
2010-10-05 21:51       ` [PATCH v3 12/20] Staging: rtl8192su: ieee80211: Makefile: cleaned T Dent
2010-10-05 21:51         ` [PATCH v3 12/20] Staging: rtl8192su: ieee80211: Makefile: cleaned up Makefile cflag lines T Dent
2010-10-05 22:20       ` [PATCH v3 12/20] Staging: rtl8192su: ieee80211: Makefile: Greg KH
2010-10-05 22:20         ` [PATCH v3 12/20] Staging: rtl8192su: ieee80211: Makefile: cleaned up Makefile cflag lines Greg KH
2010-10-02 16:38 ` [PATCH v3 13/20] Staging: rtl8192u: " Tracey Dent
2010-10-02 16:38   ` Tracey Dent
2010-10-03 12:50   ` [PATCH v3 13/20] Staging: rtl8192u: Makefile: cleaned up Makefile walter harms
2010-10-03 12:50     ` [PATCH v3 13/20] Staging: rtl8192u: Makefile: cleaned up Makefile cflag lines walter harms
2010-10-02 16:38 ` [PATCH v3 14/20] Staging: rtl8192u: ieee80211: " Tracey Dent
2010-10-02 16:38   ` Tracey Dent
2010-10-03 13:06   ` [PATCH v3 14/20] Staging: rtl8192u: ieee80211: Makefile: cleaned walter harms
2010-10-03 13:06     ` [PATCH v3 14/20] Staging: rtl8192u: ieee80211: Makefile: cleaned up Makefile cflag lines walter harms
2010-10-02 16:38 ` [PATCH v3 15/20] Staging: tm6000: " Tracey Dent
2010-10-02 16:38   ` Tracey Dent
2010-10-02 16:38 ` [PATCH v3 16/20] Staging: usbip: " Tracey Dent
2010-10-02 16:38   ` Tracey Dent
2010-10-02 16:38 ` [PATCH v3 17/20] Staging: vt6655: " Tracey Dent
2010-10-02 16:38   ` Tracey Dent
2010-10-02 16:38 ` [PATCH v3 18/20] Staging: vt6656: " Tracey Dent
2010-10-02 16:38   ` Tracey Dent
2010-10-03 13:09   ` [PATCH v3 18/20] Staging: vt6656: Makefile: cleaned up Makefile walter harms
2010-10-03 13:09     ` [PATCH v3 18/20] Staging: vt6656: Makefile: cleaned up Makefile cflag lines walter harms
2010-10-02 16:38 ` [PATCH v3 19/20] Staging: wlags49_h2: " Tracey Dent
2010-10-02 16:38   ` Tracey Dent
2010-10-02 16:38 ` [PATCH v3 20/20] Staging: wlags49_h25: " Tracey Dent
2010-10-02 16:38   ` Tracey Dent
2010-10-03 12:40 ` [PATCH v3 01/20] Staging: cx25821: Makefile: cleaned up Makefile walter harms
2010-10-03 12:40   ` [PATCH v3 01/20] Staging: cx25821: Makefile: cleaned up Makefile cflag lines walter harms
2010-10-03 20:51   ` [PATCH v3 01/20] Staging: cx25821: Makefile: cleaned up Sam Ravnborg
2010-10-03 20:51     ` [PATCH v3 01/20] Staging: cx25821: Makefile: cleaned up Makefile cflag lines Sam Ravnborg
2010-10-05  5:35     ` [PATCH v3 01/20] Staging: cx25821: Makefile: cleaned up matt mooney
2010-10-05  5:35       ` [PATCH v3 01/20] Staging: cx25821: Makefile: cleaned up Makefile cflag lines matt mooney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CA87A47.6030007@bfs.de \
    --to=wharms@bfs.de \
    --cc=greg@kroah.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=tdent48227@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.