From: Nathan Fontenot <nfont@austin.ibm.com>
To: balbir@linux.vnet.ibm.com
Cc: Greg KH <greg@kroah.com>,
steiner@sgi.com, linux-kernel@vger.kernel.org,
Dave Hansen <dave@linux.vnet.ibm.com>,
linux-mm@kvack.org, Robin Holt <holt@sgi.com>,
linuxppc-dev@lists.ozlabs.org,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH 7/9] v3 Define memory_block_size_bytes for powerpc/pseries
Date: Mon, 04 Oct 2010 09:45:14 -0500 [thread overview]
Message-ID: <4CA9E87A.3000807@austin.ibm.com> (raw)
In-Reply-To: <20101003182701.GI7896@balbir.in.ibm.com>
On 10/03/2010 01:27 PM, Balbir Singh wrote:
> * Dave Hansen <dave@linux.vnet.ibm.com> [2010-10-03 11:11:01]:
>
>> On Sun, 2010-10-03 at 13:07 -0500, Robin Holt wrote:
>>> On Sun, Oct 03, 2010 at 11:25:00PM +0530, Balbir Singh wrote:
>>>> * Nathan Fontenot <nfont@austin.ibm.com> [2010-10-01 13:35:54]:
>>>>
>>>>> Define a version of memory_block_size_bytes() for powerpc/pseries such that
>>>>> a memory block spans an entire lmb.
>>>>
>>>> I hope I am not missing anything obvious, but why not just call it
>>>> lmb_size, why do we need memblock_size?
>>>>
>>>> Is lmb_size == memblock_size after your changes true for all
>>>> platforms?
>>>
>>> What is an lmb? I don't recall anything like lmb being referred to in
>>> the rest of the kernel.
>>
>> Heh. It's the OpenFirmware name for a Logical Memory Block. Basically
>> what we use to determine the SECTION_SIZE on powerpc. Probably not the
>> best terminology to use elsewhere in the kernel.
>
> Agreed for the kernel, this patch was for powerpc/pseries, hence was
> checking in this context.
>
I don't really see a reason to name it lmb_size, it seems easier
to stick with the naming used by the rest of the kernel.
-Nathan
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Fontenot <nfont@austin.ibm.com>
To: balbir@linux.vnet.ibm.com
Cc: Dave Hansen <dave@linux.vnet.ibm.com>, Robin Holt <holt@sgi.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linuxppc-dev@lists.ozlabs.org, Greg KH <greg@kroah.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
steiner@sgi.com
Subject: Re: [PATCH 7/9] v3 Define memory_block_size_bytes for powerpc/pseries
Date: Mon, 04 Oct 2010 09:45:14 -0500 [thread overview]
Message-ID: <4CA9E87A.3000807@austin.ibm.com> (raw)
In-Reply-To: <20101003182701.GI7896@balbir.in.ibm.com>
On 10/03/2010 01:27 PM, Balbir Singh wrote:
> * Dave Hansen <dave@linux.vnet.ibm.com> [2010-10-03 11:11:01]:
>
>> On Sun, 2010-10-03 at 13:07 -0500, Robin Holt wrote:
>>> On Sun, Oct 03, 2010 at 11:25:00PM +0530, Balbir Singh wrote:
>>>> * Nathan Fontenot <nfont@austin.ibm.com> [2010-10-01 13:35:54]:
>>>>
>>>>> Define a version of memory_block_size_bytes() for powerpc/pseries such that
>>>>> a memory block spans an entire lmb.
>>>>
>>>> I hope I am not missing anything obvious, but why not just call it
>>>> lmb_size, why do we need memblock_size?
>>>>
>>>> Is lmb_size == memblock_size after your changes true for all
>>>> platforms?
>>>
>>> What is an lmb? I don't recall anything like lmb being referred to in
>>> the rest of the kernel.
>>
>> Heh. It's the OpenFirmware name for a Logical Memory Block. Basically
>> what we use to determine the SECTION_SIZE on powerpc. Probably not the
>> best terminology to use elsewhere in the kernel.
>
> Agreed for the kernel, this patch was for powerpc/pseries, hence was
> checking in this context.
>
I don't really see a reason to name it lmb_size, it seems easier
to stick with the naming used by the rest of the kernel.
-Nathan
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Fontenot <nfont@austin.ibm.com>
To: balbir@linux.vnet.ibm.com
Cc: Dave Hansen <dave@linux.vnet.ibm.com>, Robin Holt <holt@sgi.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linuxppc-dev@lists.ozlabs.org, Greg KH <greg@kroah.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
steiner@sgi.com
Subject: Re: [PATCH 7/9] v3 Define memory_block_size_bytes for powerpc/pseries
Date: Mon, 04 Oct 2010 09:45:14 -0500 [thread overview]
Message-ID: <4CA9E87A.3000807@austin.ibm.com> (raw)
In-Reply-To: <20101003182701.GI7896@balbir.in.ibm.com>
On 10/03/2010 01:27 PM, Balbir Singh wrote:
> * Dave Hansen <dave@linux.vnet.ibm.com> [2010-10-03 11:11:01]:
>
>> On Sun, 2010-10-03 at 13:07 -0500, Robin Holt wrote:
>>> On Sun, Oct 03, 2010 at 11:25:00PM +0530, Balbir Singh wrote:
>>>> * Nathan Fontenot <nfont@austin.ibm.com> [2010-10-01 13:35:54]:
>>>>
>>>>> Define a version of memory_block_size_bytes() for powerpc/pseries such that
>>>>> a memory block spans an entire lmb.
>>>>
>>>> I hope I am not missing anything obvious, but why not just call it
>>>> lmb_size, why do we need memblock_size?
>>>>
>>>> Is lmb_size == memblock_size after your changes true for all
>>>> platforms?
>>>
>>> What is an lmb? I don't recall anything like lmb being referred to in
>>> the rest of the kernel.
>>
>> Heh. It's the OpenFirmware name for a Logical Memory Block. Basically
>> what we use to determine the SECTION_SIZE on powerpc. Probably not the
>> best terminology to use elsewhere in the kernel.
>
> Agreed for the kernel, this patch was for powerpc/pseries, hence was
> checking in this context.
>
I don't really see a reason to name it lmb_size, it seems easier
to stick with the naming used by the rest of the kernel.
-Nathan
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-10-04 14:45 UTC|newest]
Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 18:22 [PATCH 0/9] v3 De-couple sysfs memory directories from memory sections Nathan Fontenot
2010-10-01 18:22 ` Nathan Fontenot
2010-10-01 18:22 ` Nathan Fontenot
2010-10-01 18:28 ` [PATCH 1/9] v3 Move find_memory_block routine Nathan Fontenot
2010-10-01 18:28 ` Nathan Fontenot
2010-10-01 18:28 ` Nathan Fontenot
2010-10-01 18:40 ` Robin Holt
2010-10-01 18:40 ` Robin Holt
2010-10-01 18:40 ` Robin Holt
2010-10-05 5:01 ` KAMEZAWA Hiroyuki
2010-10-05 5:01 ` KAMEZAWA Hiroyuki
2010-10-05 5:01 ` KAMEZAWA Hiroyuki
2010-10-01 18:29 ` [PATCH 2/9] v3 Add mutex for adding/removing memory blocks Nathan Fontenot
2010-10-01 18:29 ` Nathan Fontenot
2010-10-01 18:29 ` Nathan Fontenot
2010-10-01 18:45 ` Robin Holt
2010-10-01 18:45 ` Robin Holt
2010-10-01 18:45 ` Robin Holt
2010-10-05 5:06 ` KAMEZAWA Hiroyuki
2010-10-05 5:06 ` KAMEZAWA Hiroyuki
2010-10-05 5:06 ` KAMEZAWA Hiroyuki
2010-10-01 18:30 ` [PATCH 3/9] v3 Add section count to memory_block struct Nathan Fontenot
2010-10-01 18:30 ` Nathan Fontenot
2010-10-01 18:30 ` Nathan Fontenot
2010-10-01 18:46 ` Robin Holt
2010-10-01 18:46 ` Robin Holt
2010-10-01 18:46 ` Robin Holt
2010-10-05 5:08 ` KAMEZAWA Hiroyuki
2010-10-05 5:08 ` KAMEZAWA Hiroyuki
2010-10-05 5:08 ` KAMEZAWA Hiroyuki
2010-10-01 18:31 ` [PATCH 4/9] v3 Allow memory blocks to span multiple memory sections Nathan Fontenot
2010-10-01 18:31 ` Nathan Fontenot
2010-10-01 18:31 ` Nathan Fontenot
2010-10-01 18:52 ` Robin Holt
2010-10-01 18:52 ` Robin Holt
2010-10-01 18:52 ` Robin Holt
2010-10-01 18:56 ` Nathan Fontenot
2010-10-01 18:56 ` Nathan Fontenot
2010-10-01 18:56 ` Nathan Fontenot
2010-10-01 19:00 ` Nathan Fontenot
2010-10-01 19:00 ` Nathan Fontenot
2010-10-01 19:00 ` Nathan Fontenot
2010-10-01 19:20 ` Robin Holt
2010-10-01 19:20 ` Robin Holt
2010-10-01 19:20 ` Robin Holt
2010-10-05 5:13 ` KAMEZAWA Hiroyuki
2010-10-05 5:13 ` KAMEZAWA Hiroyuki
2010-10-05 5:13 ` KAMEZAWA Hiroyuki
2010-10-01 18:33 ` [PATCH 5/9] v3 rename phys_index properties of memory block struct Nathan Fontenot
2010-10-01 18:33 ` Nathan Fontenot
2010-10-01 18:33 ` Nathan Fontenot
2010-10-01 18:54 ` Robin Holt
2010-10-01 18:54 ` Robin Holt
2010-10-01 18:54 ` Robin Holt
2010-10-05 5:14 ` KAMEZAWA Hiroyuki
2010-10-05 5:14 ` KAMEZAWA Hiroyuki
2010-10-05 5:14 ` KAMEZAWA Hiroyuki
2010-10-01 18:34 ` [PATCH 6/9] v3 Update node sysfs code Nathan Fontenot
2010-10-01 18:34 ` Nathan Fontenot
2010-10-01 18:34 ` Nathan Fontenot
2010-10-01 18:55 ` Robin Holt
2010-10-01 18:55 ` Robin Holt
2010-10-01 18:55 ` Robin Holt
2010-10-05 5:15 ` KAMEZAWA Hiroyuki
2010-10-05 5:15 ` KAMEZAWA Hiroyuki
2010-10-05 5:15 ` KAMEZAWA Hiroyuki
2010-10-01 18:35 ` [PATCH 7/9] v3 Define memory_block_size_bytes for powerpc/pseries Nathan Fontenot
2010-10-01 18:35 ` Nathan Fontenot
2010-10-01 18:35 ` Nathan Fontenot
2010-10-01 18:56 ` Robin Holt
2010-10-01 18:56 ` Robin Holt
2010-10-01 18:56 ` Robin Holt
2010-10-03 17:55 ` Balbir Singh
2010-10-03 17:55 ` Balbir Singh
2010-10-03 17:55 ` Balbir Singh
2010-10-03 18:07 ` Robin Holt
2010-10-03 18:07 ` Robin Holt
2010-10-03 18:07 ` Robin Holt
2010-10-03 18:11 ` Dave Hansen
2010-10-03 18:11 ` Dave Hansen
2010-10-03 18:11 ` Dave Hansen
2010-10-03 18:27 ` Balbir Singh
2010-10-03 18:27 ` Balbir Singh
2010-10-03 18:27 ` Balbir Singh
2010-10-04 14:45 ` Nathan Fontenot [this message]
2010-10-04 14:45 ` Nathan Fontenot
2010-10-04 14:45 ` Nathan Fontenot
2010-10-01 18:37 ` [PATCH 8/9] v3 Define memory_block_size_bytes for x86_64 with CONFIG_X86_UV set Nathan Fontenot
2010-10-01 18:37 ` Nathan Fontenot
2010-10-01 18:37 ` Nathan Fontenot
2010-10-01 18:57 ` Robin Holt
2010-10-01 18:57 ` Robin Holt
2010-10-01 18:57 ` Robin Holt
2010-10-01 18:37 ` [PATCH 9/9] v3 Update memory hotplug documentation Nathan Fontenot
2010-10-01 18:37 ` Nathan Fontenot
2010-10-01 18:37 ` Nathan Fontenot
2010-10-01 18:58 ` Robin Holt
2010-10-01 18:58 ` Robin Holt
2010-10-01 18:58 ` Robin Holt
2010-10-05 5:18 ` KAMEZAWA Hiroyuki
2010-10-05 5:18 ` KAMEZAWA Hiroyuki
2010-10-05 5:18 ` KAMEZAWA Hiroyuki
2010-10-21 12:05 ` [PATCH 0/9] v3 De-couple sysfs memory directories from memory sections Nikanth Karthikesan
2010-10-21 12:05 ` Nikanth Karthikesan
2010-10-21 12:05 ` Nikanth Karthikesan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA9E87A.3000807@austin.ibm.com \
--to=nfont@austin.ibm.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=dave@linux.vnet.ibm.com \
--cc=greg@kroah.com \
--cc=holt@sgi.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=steiner@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.