From: Jeff Garzik <jgarzik@pobox.com>
To: Mark Lord <kernel@teksavvy.com>
Cc: Tejun Heo <htejun@gmail.com>,
Robert Hancock <hancockrwd@gmail.com>,
Seed <seedrubbish@gmail.com>,
IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: [BUG] libahci returns stale result tf much of the time.
Date: Mon, 04 Oct 2010 15:42:14 -0400 [thread overview]
Message-ID: <4CAA2E16.4010905@pobox.com> (raw)
In-Reply-To: <4CAA2C6F.2090603@teksavvy.com>
On 10/04/2010 03:35 PM, Mark Lord wrote:
> On 10-10-04 03:27 PM, Jeff Garzik wrote:
>> On 10/04/2010 02:50 PM, Mark Lord wrote:
>>> I've dug a bit deeper, and worked around the issue.
>>> It seems that libata is not always happy about DATA-xfer commands
>>> that also have the check-sense bit set (0x20 in cdb[2]).
>>> Perhaps that's not even valid in SCSI ??
>>
>>
>> Very interesting... poking at this now on pre- and post-libahci
>> platforms. As you said, don't see much difference in behavior WRT
>> libahci -- which I expected/hoped, since that split shouldn't have
>> changed behavior at all[1].
>
>
> Yeah. Non-data commands still get a (correct) updated result_tf from AHCI,
> but data commands don't get one, unless they fail.
>
> Weird, but I've worked around it now.
Might be that we just get a single-bit "OK" notification from hardware
for successfully completed commands, a la NCQ's SDB FIS.
Which opcodes are you using? I see set-acoustic-mgmt in one email...
Jeff
next prev parent reply other threads:[~2010-10-04 19:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-24 5:34 [BUG] libahci returns stale result tf much of the time Mark Lord
2010-09-24 5:49 ` Seed
2010-09-24 6:27 ` Mark Lord
2010-09-24 7:01 ` Seed
2010-09-24 13:11 ` Mark Lord
2010-09-24 13:24 ` Mark Lord
2010-09-24 23:26 ` Robert Hancock
2010-10-04 9:18 ` Tejun Heo
2010-10-04 17:01 ` Mark Lord
2010-10-04 17:06 ` Mark Lord
2010-10-04 17:31 ` Mark Lord
2010-10-04 18:50 ` Mark Lord
2010-10-04 19:27 ` Jeff Garzik
2010-10-04 19:35 ` Mark Lord
2010-10-04 19:42 ` Jeff Garzik [this message]
2010-10-04 19:51 ` Mark Lord
2010-10-05 7:07 ` Tejun Heo
2010-10-05 14:06 ` Mark Lord
2010-10-05 16:06 ` Tejun Heo
2010-10-06 1:00 ` Robert Hancock
2010-10-14 8:53 ` [PATCH #upstream-fixes] libahci: fix result_tf handling after an ATA PIO data-in command Tejun Heo
2010-10-14 21:38 ` Mark Lord
2010-10-15 0:24 ` Robert Hancock
2010-10-15 8:45 ` Tejun Heo
2010-10-15 22:14 ` Mark Lord
2010-10-15 0:32 ` Robert Hancock
2010-10-15 8:45 ` Tejun Heo
2010-10-15 9:00 ` [PATCH UPDATED " Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CAA2E16.4010905@pobox.com \
--to=jgarzik@pobox.com \
--cc=hancockrwd@gmail.com \
--cc=htejun@gmail.com \
--cc=kernel@teksavvy.com \
--cc=linux-ide@vger.kernel.org \
--cc=seedrubbish@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.