All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Mark Lord <kernel@teksavvy.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
	Robert Hancock <hancockrwd@gmail.com>,
	Seed <seedrubbish@gmail.com>,
	IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: [BUG] libahci returns stale result tf much of the time.
Date: Tue, 05 Oct 2010 18:06:01 +0200	[thread overview]
Message-ID: <4CAB4CE9.9070709@gmail.com> (raw)
In-Reply-To: <4CAB30FA.2010508@teksavvy.com>

Hello,

On 10/05/2010 04:06 PM, Mark Lord wrote:
> Yeah, maybe something like that.
> 
> But do note that I have verified that "hdparm -C" does work correctly,
> and is dependent upon correctly returned result_tf values.
> 
> It's not a PIO "data" command, though.  Does it get issued the same way?

PIO Setup FIS is not used for nodata commands.  IIRC, nodata uses D2H
Reg FIS for command completion.  I think the only exception is PIO
data commands.  The weird hack is to satisfy PIO data command protocol
timing requirement stemming from PATA specification.  Eh... ugly.

Thanks.

-- 
tejun

  reply	other threads:[~2010-10-05 16:04 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-24  5:34 [BUG] libahci returns stale result tf much of the time Mark Lord
2010-09-24  5:49 ` Seed
2010-09-24  6:27   ` Mark Lord
2010-09-24  7:01     ` Seed
2010-09-24 13:11       ` Mark Lord
2010-09-24 13:24         ` Mark Lord
2010-09-24 23:26           ` Robert Hancock
2010-10-04  9:18             ` Tejun Heo
2010-10-04 17:01               ` Mark Lord
2010-10-04 17:06                 ` Mark Lord
2010-10-04 17:31                   ` Mark Lord
2010-10-04 18:50                     ` Mark Lord
2010-10-04 19:27                       ` Jeff Garzik
2010-10-04 19:35                         ` Mark Lord
2010-10-04 19:42                           ` Jeff Garzik
2010-10-04 19:51                             ` Mark Lord
2010-10-05  7:07                               ` Tejun Heo
2010-10-05 14:06                                 ` Mark Lord
2010-10-05 16:06                                   ` Tejun Heo [this message]
2010-10-06  1:00                                     ` Robert Hancock
2010-10-14  8:53                                       ` [PATCH #upstream-fixes] libahci: fix result_tf handling after an ATA PIO data-in command Tejun Heo
2010-10-14 21:38                                         ` Mark Lord
2010-10-15  0:24                                           ` Robert Hancock
2010-10-15  8:45                                             ` Tejun Heo
2010-10-15 22:14                                               ` Mark Lord
2010-10-15  0:32                                         ` Robert Hancock
2010-10-15  8:45                                           ` Tejun Heo
2010-10-15  9:00                                         ` [PATCH UPDATED " Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CAB4CE9.9070709@gmail.com \
    --to=htejun@gmail.com \
    --cc=hancockrwd@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=kernel@teksavvy.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=seedrubbish@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.