* [PATCH 1/1] Don't check exchange flags unless using v4.1
@ 2010-10-06 15:56 Fred Isaman
2010-10-06 16:02 ` Benny Halevy
0 siblings, 1 reply; 3+ messages in thread
From: Fred Isaman @ 2010-10-06 15:56 UTC (permalink / raw)
To: linux-nfs
Signed-off-by: Fred Isaman <iisaman@netapp.com>
---
fs/nfs/pnfs.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
index 7013916..64baf20 100644
--- a/fs/nfs/pnfs.c
+++ b/fs/nfs/pnfs.c
@@ -141,7 +141,9 @@ set_pnfs_layoutdriver(struct nfs_server *server, u32 id)
if (id == 0)
goto out_no_driver;
- if (!(server->nfs_client->cl_exchange_flags &
+ if ((server->nfs_client->rpc_ops->version == 4) &&
+ (server->nfs_client->cl_minorversion == 1) &&
+ !(server->nfs_client->cl_exchange_flags &
(EXCHGID4_FLAG_USE_NON_PNFS | EXCHGID4_FLAG_USE_PNFS_MDS))) {
printk(KERN_ERR "%s: id %u cl_exchange_flags 0x%x\n", __func__,
id, server->nfs_client->cl_exchange_flags);
--
1.7.2.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] Don't check exchange flags unless using v4.1
2010-10-06 15:56 [PATCH 1/1] Don't check exchange flags unless using v4.1 Fred Isaman
@ 2010-10-06 16:02 ` Benny Halevy
2010-10-06 16:10 ` Fred Isaman
0 siblings, 1 reply; 3+ messages in thread
From: Benny Halevy @ 2010-10-06 16:02 UTC (permalink / raw)
To: Fred Isaman; +Cc: linux-nfs
On 2010-10-06 11:56, Fred Isaman wrote:
> Signed-off-by: Fred Isaman <iisaman@netapp.com>
> ---
> fs/nfs/pnfs.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
> index 7013916..64baf20 100644
> --- a/fs/nfs/pnfs.c
> +++ b/fs/nfs/pnfs.c
> @@ -141,7 +141,9 @@ set_pnfs_layoutdriver(struct nfs_server *server, u32 id)
>
> if (id == 0)
> goto out_no_driver;
> - if (!(server->nfs_client->cl_exchange_flags &
> + if ((server->nfs_client->rpc_ops->version == 4) &&
> + (server->nfs_client->cl_minorversion == 1) &&
> + !(server->nfs_client->cl_exchange_flags &
> (EXCHGID4_FLAG_USE_NON_PNFS | EXCHGID4_FLAG_USE_PNFS_MDS))) {
> printk(KERN_ERR "%s: id %u cl_exchange_flags 0x%x\n", __func__,
> id, server->nfs_client->cl_exchange_flags);
Actually, it'd better to disable just the warning printout in this case,
not the entire block.
Benny
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] Don't check exchange flags unless using v4.1
2010-10-06 16:02 ` Benny Halevy
@ 2010-10-06 16:10 ` Fred Isaman
0 siblings, 0 replies; 3+ messages in thread
From: Fred Isaman @ 2010-10-06 16:10 UTC (permalink / raw)
To: Benny Halevy; +Cc: linux-nfs
On Oct 6, 2010, at 12:02 PM, Benny Halevy wrote:
> On 2010-10-06 11:56, Fred Isaman wrote:
>> Signed-off-by: Fred Isaman <iisaman@netapp.com>
>> ---
>> fs/nfs/pnfs.c | 4 +++-
>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>
>> diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
>> index 7013916..64baf20 100644
>> --- a/fs/nfs/pnfs.c
>> +++ b/fs/nfs/pnfs.c
>> @@ -141,7 +141,9 @@ set_pnfs_layoutdriver(struct nfs_server *server, u32 id)
>>
>> if (id == 0)
>> goto out_no_driver;
>> - if (!(server->nfs_client->cl_exchange_flags &
>> + if ((server->nfs_client->rpc_ops->version == 4) &&
>> + (server->nfs_client->cl_minorversion == 1) &&
>> + !(server->nfs_client->cl_exchange_flags &
>> (EXCHGID4_FLAG_USE_NON_PNFS | EXCHGID4_FLAG_USE_PNFS_MDS))) {
>> printk(KERN_ERR "%s: id %u cl_exchange_flags 0x%x\n", __func__,
>> id, server->nfs_client->cl_exchange_flags);
>
> Actually, it'd better to disable just the warning printout in this case,
> not the entire block.
>
> Benny
Bah. I sent out the wrong version. See next email.
Fred
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-06 16:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-06 15:56 [PATCH 1/1] Don't check exchange flags unless using v4.1 Fred Isaman
2010-10-06 16:02 ` Benny Halevy
2010-10-06 16:10 ` Fred Isaman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.