From: Ben Dooks <ben-linux@fluff.org>
To: Kyungmin Park <kmpark@infradead.org>
Cc: Maurus Cuelenaere <mcuelenaere@gmail.com>,
linux-samsung-soc@vger.kernel.org, ben-linux@fluff.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM: S3C64XX: Add suspend support
Date: Wed, 06 Oct 2010 23:22:48 +0100 [thread overview]
Message-ID: <4CACF6B8.9030304@fluff.org> (raw)
In-Reply-To: <AANLkTi=CH6BJZDYsCHXmcYAVuu-LTsqjKXUVGnBAikiN@mail.gmail.com>
On 06/10/10 00:23, Kyungmin Park wrote:
> Hi,
>
> I agree your approach, put the common features in common place.
> but Samsung maintainers insist put these at each machine file at current time.
This is just an init call, the actuall implementation is common to the
core. We did it this was as it was not clear if _all_ machines under
the architecture could do this by default, or would need extra code in
their mach implementation, or in a driver elsewhere.
I would still prefer each machine that can do pm to call s3c_pm_init()
in their setup code to ensure that we don't enable pm on a machine with
possibly incomplete support (especially as PM can be one of the more
difficult things to debug).
WARNING: multiple messages have this Message-ID (diff)
From: ben-linux@fluff.org (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: S3C64XX: Add suspend support
Date: Wed, 06 Oct 2010 23:22:48 +0100 [thread overview]
Message-ID: <4CACF6B8.9030304@fluff.org> (raw)
In-Reply-To: <AANLkTi=CH6BJZDYsCHXmcYAVuu-LTsqjKXUVGnBAikiN@mail.gmail.com>
On 06/10/10 00:23, Kyungmin Park wrote:
> Hi,
>
> I agree your approach, put the common features in common place.
> but Samsung maintainers insist put these at each machine file at current time.
This is just an init call, the actuall implementation is common to the
core. We did it this was as it was not clear if _all_ machines under
the architecture could do this by default, or would need extra code in
their mach implementation, or in a driver elsewhere.
I would still prefer each machine that can do pm to call s3c_pm_init()
in their setup code to ensure that we don't enable pm on a machine with
possibly incomplete support (especially as PM can be one of the more
difficult things to debug).
next prev parent reply other threads:[~2010-10-06 22:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-05 23:09 [PATCH 0/2] ARM: S3C64XX: SmartQ: add suspend support Maurus Cuelenaere
2010-10-05 23:09 ` Maurus Cuelenaere
2010-10-05 23:09 ` [PATCH 1/2] ARM: S3C64XX: Add " Maurus Cuelenaere
2010-10-05 23:09 ` Maurus Cuelenaere
2010-10-05 23:23 ` Kyungmin Park
2010-10-05 23:23 ` Kyungmin Park
2010-10-05 23:27 ` Maurus Cuelenaere
2010-10-05 23:27 ` Maurus Cuelenaere
2010-10-05 23:39 ` Kyungmin Park
2010-10-05 23:39 ` Kyungmin Park
2010-10-06 22:22 ` Ben Dooks [this message]
2010-10-06 22:22 ` Ben Dooks
2010-10-06 22:27 ` Maurus Cuelenaere
2010-10-06 22:27 ` Maurus Cuelenaere
2010-10-05 23:10 ` [PATCH 2/2] ARM: S3C64XX: Add wakeup sources to SmartQ boards Maurus Cuelenaere
2010-10-05 23:10 ` Maurus Cuelenaere
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CACF6B8.9030304@fluff.org \
--to=ben-linux@fluff.org \
--cc=kmpark@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mcuelenaere@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.