[PATCH 0/4] RDEPENDS -> RDEPENDS_${PN}

[PATCH 0/4] RDEPENDS -> RDEPENDS_${PN}

[Frans Meulenbroeks]

Below are 4 patches that change RDEPENDS into RDEPENDS_${PN}
As I am not too familiar with these files your review comments are appreciated

Frans Meulenbroeks (4):
  RDEPENDS -> RDEPENDS_${PN}
  RDEPENDS -> RDEPENDS_${PN}
  RDEPENDS -> RDEPENDS_${PN}
  RDEPENDS -> RDEPENDS_${PN}

 classes/cpan-base.bbclass      |    2 +-
 classes/distutils-base.bbclass |    2 +-
 classes/image.bbclass          |    2 +-
 classes/rubyextension.bbclass  |    2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

[PATCH 1/4] RDEPENDS -> RDEPENDS_${PN}

[Frans Meulenbroeks]

Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
---
 classes/cpan-base.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/classes/cpan-base.bbclass b/classes/cpan-base.bbclass
index 379defa..a04f61c 100644
--- a/classes/cpan-base.bbclass
+++ b/classes/cpan-base.bbclass
@@ -5,7 +5,7 @@
 FILES_${PN} += "${libdir}/perl5 ${datadir}/perl5"
 
 DEPENDS  += "${@["perl", "perl-native"][(bb.data.inherits_class('native', d))]}"
-RDEPENDS  += "${@["perl", ""][(bb.data.inherits_class('native', d))]}"
+RDEPENDS_${PN}  += "${@["perl", ""][(bb.data.inherits_class('native', d))]}"
 
 # Determine the staged version of perl from the perl configuration file
 def get_perl_version(d):
-- 
1.6.4.2

[PATCH 2/4] RDEPENDS -> RDEPENDS_${PN}

[Frans Meulenbroeks]

Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
---
 classes/distutils-base.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/classes/distutils-base.bbclass b/classes/distutils-base.bbclass
index 59864f7..4d5de24 100644
--- a/classes/distutils-base.bbclass
+++ b/classes/distutils-base.bbclass
@@ -1,4 +1,4 @@
 DEPENDS  += "${@["python-native python", ""][(bb.data.getVar('PACKAGES', d, 1) == '')]}"
-RDEPENDS += "${@['', 'python-core']['${PN}' == '${BPN}']}"
+RDEPENDS_${PN} += "${@['', 'python-core']['${PN}' == '${BPN}']}"
 
 inherit distutils-common-base
-- 
1.6.4.2

[PATCH 3/4] RDEPENDS -> RDEPENDS_${PN}

[Frans Meulenbroeks]

Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
---
 classes/image.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/classes/image.bbclass b/classes/image.bbclass
index 2105195..49924d7 100644
--- a/classes/image.bbclass
+++ b/classes/image.bbclass
@@ -29,7 +29,7 @@ ${IMAGE_DEV_MANAGER} \
 ${IMAGE_INIT_MANAGER} \
 ${IMAGE_LOGIN_MANAGER} "
 
-RDEPENDS += "${IMAGE_INSTALL} ${IMAGE_BOOT}"
+RDEPENDS_${PN} += "${IMAGE_INSTALL} ${IMAGE_BOOT}"
 
 # "export IMAGE_BASENAME" not supported at this time
 IMAGE_BASENAME[export] = "1"
-- 
1.6.4.2

[PATCH 4/4] RDEPENDS -> RDEPENDS_${PN}

[Frans Meulenbroeks]

Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
---
 classes/rubyextension.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/classes/rubyextension.bbclass b/classes/rubyextension.bbclass
index 628ebdb..de8eb9c 100644
--- a/classes/rubyextension.bbclass
+++ b/classes/rubyextension.bbclass
@@ -1,5 +1,5 @@
 DEPENDS  += "ruby-native"
-RDEPENDS += "ruby"
+RDEPENDS_${PN} += "ruby"
 
 rubyextension_do_configure() {
 	${STAGING_BINDIR_NATIVE}/ruby setup.rb config || \
-- 
1.6.4.2

Re: [PATCH 0/4] RDEPENDS -> RDEPENDS_${PN}

[Chris Larson]

On Wed, Oct 6, 2010 at 2:08 PM, Frans Meulenbroeks <
fransmeulenbroeks@gmail.com> wrote:

> Below are 4 patches that change RDEPENDS into RDEPENDS_${PN}
> As I am not too familiar with these files your review comments are
> appreciated


For all 4:

Acked-by: Chris Larson <chris_larson@mentor.com>
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

Re: [PATCH 1/4] RDEPENDS -> RDEPENDS_${PN}

[Philip Balister]

Next time, can you add the package name to the commit message?


Philip

On 10/06/2010 05:08 PM, Frans Meulenbroeks wrote:
> Signed-off-by: Frans Meulenbroeks<fransmeulenbroeks@gmail.com>
> ---
>   classes/cpan-base.bbclass |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/classes/cpan-base.bbclass b/classes/cpan-base.bbclass
> index 379defa..a04f61c 100644
> --- a/classes/cpan-base.bbclass
> +++ b/classes/cpan-base.bbclass
> @@ -5,7 +5,7 @@
>   FILES_${PN} += "${libdir}/perl5 ${datadir}/perl5"
>
>   DEPENDS  += "${@["perl", "perl-native"][(bb.data.inherits_class('native', d))]}"
> -RDEPENDS  += "${@["perl", ""][(bb.data.inherits_class('native', d))]}"
> +RDEPENDS_${PN}  += "${@["perl", ""][(bb.data.inherits_class('native', d))]}"
>
>   # Determine the staged version of perl from the perl configuration file
>   def get_perl_version(d):

Re: [PATCH 1/4] RDEPENDS -> RDEPENDS_${PN}

[Frans Meulenbroeks]

2010/10/7 Philip Balister <philip@balister.org>:
> Next time, can you add the package name to the commit message?
>
>
> Philip

Actually there is no package name here as it is for .bbclass, but I
will add the bbclass filename to the commit message before pushing
this (need one more ack)
That also explains why gmail decided this was all the same thread.

Frans

Re: [PATCH 1/4] RDEPENDS -> RDEPENDS_${PN}

[Frans Meulenbroeks]

Triggered by a remark from Martin on irc:

Do we need a PR bump for all users of those classes?
Did a quick grep, there are 75 recipes inheriting image, about 160
inheriting cpan and about 200 inheriting distutils
rubyextensions.bbclass is not used.

And if it is felt that a bump is needed, is it ok that I make this
change (strictly limiting myself to incrementing PR) and commit that
without further review ?
(each bbclass change + associated PR bump will be a separate commit;
so 4 commits)

(Since a PR bump addresses quite some files, a review has the
disadvantage that the patch probably won't apply any more due to other
changes because one of the files involved has been touched)

Frans.

Re: [PATCH 1/4] RDEPENDS -> RDEPENDS_${PN}

[Frans Meulenbroeks]

2010/10/6 Frans Meulenbroeks <fransmeulenbroeks@gmail.com>:
> Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
> ---
>  classes/cpan-base.bbclass |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/classes/cpan-base.bbclass b/classes/cpan-base.bbclass
> index 379defa..a04f61c 100644
> --- a/classes/cpan-base.bbclass
> +++ b/classes/cpan-base.bbclass
> @@ -5,7 +5,7 @@
>  FILES_${PN} += "${libdir}/perl5 ${datadir}/perl5"
>
>  DEPENDS  += "${@["perl", "perl-native"][(bb.data.inherits_class('native', d))]}"
> -RDEPENDS  += "${@["perl", ""][(bb.data.inherits_class('native', d))]}"
> +RDEPENDS_${PN}  += "${@["perl", ""][(bb.data.inherits_class('native', d))]}"
>
>  # Determine the staged version of perl from the perl configuration file
>  def get_perl_version(d):


Aargh. Accidently pushed this patch yesterday with another one.
Thought I'd removed it from my git, but apparently it wasn't.
Propose to keep it like that (and no revert). Let me know if a PR bump
of recipes inheriting this is needed.

Frans.

Re: [PATCH 1/4] RDEPENDS -> RDEPENDS_${PN}

[Frans Meulenbroeks]

2010/10/8 Frans Meulenbroeks <fransmeulenbroeks@gmail.com>:
> 2010/10/6 Frans Meulenbroeks <fransmeulenbroeks@gmail.com>:
>> Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
>> ---
>>  classes/cpan-base.bbclass |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/classes/cpan-base.bbclass b/classes/cpan-base.bbclass
>> index 379defa..a04f61c 100644
>> --- a/classes/cpan-base.bbclass
>> +++ b/classes/cpan-base.bbclass
>> @@ -5,7 +5,7 @@
>>  FILES_${PN} += "${libdir}/perl5 ${datadir}/perl5"
>>
>>  DEPENDS  += "${@["perl", "perl-native"][(bb.data.inherits_class('native', d))]}"
>> -RDEPENDS  += "${@["perl", ""][(bb.data.inherits_class('native', d))]}"
>> +RDEPENDS_${PN}  += "${@["perl", ""][(bb.data.inherits_class('native', d))]}"
>>
>>  # Determine the staged version of perl from the perl configuration file
>>  def get_perl_version(d):
>
>
> Aargh. Accidently pushed this patch yesterday with another one.
> Thought I'd removed it from my git, but apparently it wasn't.
> Propose to keep it like that (and no revert). Let me know if a PR bump
> of recipes inheriting this is needed.
>
> Frans.
>
Patches applied after getting a 2nd ack from Martin on irc so this
gets into the next testing branch.
If PR bumps are needed they can still be applied (let me know)

Frans