From: Paolo Bonzini <pbonzini@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH 08/11] vnc: avoid write only variables
Date: Thu, 07 Oct 2010 09:23:17 +0200 [thread overview]
Message-ID: <4CAD7565.5040909@redhat.com> (raw)
In-Reply-To: <AANLkTi=f0aw0r0HAYmk7r_CpsueG5WZjf0A_Y_khiWW5@mail.gmail.com>
On 10/06/2010 11:33 PM, Blue Swirl wrote:
> +#if defined(CONFIG_VNC_TLS) || defined(CONFIG_VNC_SASL)
> } else if (strncmp(options, "acl", 3) == 0) {
> acl = 1;
> +#endif
Not sure it's okay to reject the option altogether (i.e. maybe the #if
should only include "acl = 1".
Paolo
next prev parent reply other threads:[~2010-10-07 7:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 21:33 [Qemu-devel] [PATCH 08/11] vnc: avoid write only variables Blue Swirl
2010-10-07 7:23 ` Paolo Bonzini [this message]
2010-10-07 12:26 ` [Qemu-devel] " Markus Armbruster
2010-10-07 18:04 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CAD7565.5040909@redhat.com \
--to=pbonzini@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.