All of lore.kernel.org
 help / color / mirror / Atom feed
From: Milan Broz <mbroz@redhat.com>
To: device-mapper development <dm-devel@redhat.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	just.for.lkml@googlemail.com, hch@infradead.org,
	herbert@gondor.hengli.com.au, Tejun Heo <tj@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: Linux 2.6.36-rc7
Date: Thu, 07 Oct 2010 22:13:00 +0200	[thread overview]
Message-ID: <4CAE29CC.8030702@redhat.com> (raw)
In-Reply-To: <4CAE1F47.3050105@kernel.org>

On 10/07/2010 09:28 PM, Tejun Heo wrote:

> I'm afraid there is a possibly workqueue related deadlock under high
> memory pressure.  It happens on dm-crypt + md raid1 configuration.
> I'm not yet sure whether this is caused by workqueue failing to kick
> rescuers under memory pressure or the shared workqueue is making an
> already existing problem more visible and in the process of setting up
> an environment to reproduce the problem.
> 
>  http://thread.gmane.org/gmane.comp.file-systems.xfs.general/34922/focus=1044784

Yes, XFS is very good to show up problems in dm-crypt:)

But there was no change in dm-crypt which can itself cause such problem,
planned workqueue changes are not in 2.6.36 yet.
Code is basically the same for the last few releases.

So it seems that workqueue processing really changed here under memory pressure.

Milan

p.s.
Anyway, if you are able to reproduce it and you think that there is problem
in per-device dm-crypt workqueue, there are patches from Andi for shared
per-cpu workqueue, maybe it can help here. (But this is really not RC material.)

Unfortunately not yet in dm-devel tree, but I have them here ready for review:
http://mbroz.fedorapeople.org/dm-crypt/2.6.36-devel/
(all 4 patches must be applied, I hope Alasdair will put them in dm quilt soon.)

WARNING: multiple messages have this Message-ID (diff)
From: Milan Broz <mbroz@redhat.com>
To: device-mapper development <dm-devel@redhat.com>
Cc: Tejun Heo <tj@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	just.for.lkml@googlemail.com, hch@infradead.org,
	herbert@gondor.hengli.com.au
Subject: Re: [dm-devel] Linux 2.6.36-rc7
Date: Thu, 07 Oct 2010 22:13:00 +0200	[thread overview]
Message-ID: <4CAE29CC.8030702@redhat.com> (raw)
In-Reply-To: <4CAE1F47.3050105@kernel.org>

On 10/07/2010 09:28 PM, Tejun Heo wrote:

> I'm afraid there is a possibly workqueue related deadlock under high
> memory pressure.  It happens on dm-crypt + md raid1 configuration.
> I'm not yet sure whether this is caused by workqueue failing to kick
> rescuers under memory pressure or the shared workqueue is making an
> already existing problem more visible and in the process of setting up
> an environment to reproduce the problem.
> 
>  http://thread.gmane.org/gmane.comp.file-systems.xfs.general/34922/focus=1044784

Yes, XFS is very good to show up problems in dm-crypt:)

But there was no change in dm-crypt which can itself cause such problem,
planned workqueue changes are not in 2.6.36 yet.
Code is basically the same for the last few releases.

So it seems that workqueue processing really changed here under memory pressure.

Milan

p.s.
Anyway, if you are able to reproduce it and you think that there is problem
in per-device dm-crypt workqueue, there are patches from Andi for shared
per-cpu workqueue, maybe it can help here. (But this is really not RC material.)

Unfortunately not yet in dm-devel tree, but I have them here ready for review:
http://mbroz.fedorapeople.org/dm-crypt/2.6.36-devel/
(all 4 patches must be applied, I hope Alasdair will put them in dm quilt soon.)

  reply	other threads:[~2010-10-07 20:13 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-06 21:45 Linux 2.6.36-rc7 Linus Torvalds
2010-10-07  0:49 ` Stephen Rothwell
2010-10-08 15:05   ` James Bottomley
2010-10-07 16:10 ` Tvrtko Ursulin
2010-10-07 17:15   ` Tvrtko Ursulin
2010-10-07 17:33     ` Eric Paris
2010-10-07 18:07       ` Alan Cox
2010-10-07 17:49         ` Eric Paris
2010-10-08 12:06           ` Andreas Gruenbacher
2010-10-08 16:33             ` David Daney
2010-10-08 21:50               ` Andreas Gruenbacher
2010-10-08 21:59                 ` H. Peter Anvin
2010-10-11 22:13                   ` fanotify: disable fanotify syscalls Eric Paris
2010-10-08 16:38             ` Linux 2.6.36-rc7 Eric Paris
2010-10-08 21:45               ` Andreas Gruenbacher
2010-10-07 20:55       ` John Stoffel
2010-10-07 21:24         ` Eric Paris
2010-10-08 15:42           ` John Stoffel
2010-10-08 16:17             ` Tvrtko Ursulin
2010-10-08 16:41               ` Eric Paris
2010-10-18 11:01                 ` Tvrtko Ursulin
2010-10-08 16:54               ` John Stoffel
2010-10-08 21:03               ` Andreas Gruenbacher
2010-10-09  0:46                 ` John Stoffel
2010-10-07 19:28 ` Tejun Heo
2010-10-07 20:13   ` Milan Broz [this message]
2010-10-07 20:13     ` [dm-devel] " Milan Broz
2010-10-08 17:02     ` Tejun Heo
2010-10-10 11:56       ` Torsten Kaiser
2010-10-10 11:56         ` Torsten Kaiser
2010-10-11 10:09       ` [PATCH wq#for-next] workqueue: fix HIGHPRI handling in keep_working() Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CAE29CC.8030702@redhat.com \
    --to=mbroz@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=hch@infradead.org \
    --cc=herbert@gondor.hengli.com.au \
    --cc=just.for.lkml@googlemail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.