[Qemu-devel] Re: [PATCH 0/2] qcow2_create() error handling fixes

[Kevin Wolf <kwolf@redhat.com>]

Am 07.10.2010 22:25, schrieb Eduardo Habkost:
> From: Eduardo Habkost <ehabkost@raisama.net>
> 
> Hi,
> 
> Here are two small fixes on qcow2_create() error handling.
> 
> Eduardo Habkost (2):
>   fix fd leak on a qcow2_create2() error path
>   check for close() errors on qcow2_create()

A while ago I sent a patch to completely rewrite qcow_create using qemu
block layer functions. I didn't submit it for inclusion yet because it
makes some assumptions in qemu-iotests invalid and the test cases need
to be fixed first.

In the new version, your first patch wouldn't be needed. However, for
the second one, I think we have a problem today:

    void bdrv_close(BlockDriverState *bs);

We need to convert bdrv_close to be able to return error values and to
pass them on up to the first caller (which is qemu-img in this case).

I'll have a look at fixing the test cases and bdrv_close. If I can't get
it fixed easily, I'll consider your patches.

Kevin