All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zdenek Kabelac <zkabelac@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] Fix liblvm2cmd.so linking order for --as-needed builds
Date: Tue, 12 Oct 2010 15:55:48 +0200	[thread overview]
Message-ID: <4CB468E4.4080101@redhat.com> (raw)
In-Reply-To: <1283355456.30896.286.camel@yamato.local>

Dne 1.9.2010 17:37, Diego Elio Petten? napsal(a):
> Hi all,
> 
> I'm attaching a patch that fix the linking of liblvm2cmd.so so that it
> actually links to the libraries it needs... with the original Makefile,
> the linking order is such that ld drops all the libraries, linking only
> libc at the end... this in turn will cause undefined references to floor
> when the library is loaded in (see http://bugs.gentoo.org/335205 for
> reference).

The last occurrence of  CLDWHOLEARCHIVE in tools/Makefile.in seems to be
dropped by this Alasdair's commit:

Author: Alasdair Kergon <agk@redhat.com>
Date:   Thu Feb 2 19:16:47 2006 +0000

Which seems to in somewhat history.

So this patch doesn't look like upstream related - rather some local 'gentoo'
cooking patch ?   Is gentoo doing their own build rules?

If the upstream still has any linking problem - please report problems/patches
against upstream CVS/git repository.


Zdenek



  reply	other threads:[~2010-10-12 13:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-01 15:35 [PATCH] Fix liblvm2cmd.so linking order for --as-needed builds Diego Elio Pettenò
2010-10-12 13:55 ` Zdenek Kabelac [this message]
2010-10-12 14:26   ` Diego Elio Pettenò
2010-10-12 14:57     ` Zdenek Kabelac
2010-10-12 15:15       ` Przemyslaw Iskra
2010-10-15  9:50         ` Zdenek Kabelac
2010-11-30 10:31     ` Zdenek Kabelac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CB468E4.4080101@redhat.com \
    --to=zkabelac@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.