All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zdenek Kabelac <zkabelac@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] Fix liblvm2cmd.so linking order for --as-needed builds
Date: Tue, 30 Nov 2010 11:31:33 +0100	[thread overview]
Message-ID: <4CF4D285.7070005@redhat.com> (raw)
In-Reply-To: <1286893207.20493.20.camel@yamato.local>

Dne 12.10.2010 16:20, Diego Elio Petten? napsal(a):
> Il giorno mar, 12/10/2010 alle 15.55 +0200, Zdenek Kabelac ha scritto:
>> The last occurrence of  CLDWHOLEARCHIVE in tools/Makefile.in seems to be
>> dropped by this Alasdair's commit:
> 
> Uh?
> 
> liblvm2cmd.$(LIB_SUFFIX): liblvm2cmd.a $(LDDEPS)
>         $(CC) -shared -Wl,-soname,$@.$(LIB_VERSION) \
>         $(CFLAGS) $(CLDFLAGS) -o $@ $(LVMLIBS) $(LIBS) \
>                 @CLDWHOLEARCHIVE@ liblvm2cmd.a @CLDNOWHOLEARCHIVE@
> 
> this is in 
> 
> commit 39429d390515de9a375979274bc61d787ea9a0cb
> Author: Zdenek Kabelac <zkabelac@redhat.com>
> Date:   Fri Oct 8 15:03:21 2010 +0000
> 
> Did I get the wrong GIT repository?
> 


f5c395ad (Alasdair Kergon   2008-11-14 20:59:56 +0000 151)
liblvm2cmd.$(LIB_SUFFIX): liblvm2cmd.a $(LDDEPS)
16d70487 (Zdenek Kabelac    2010-05-11 08:34:38 +0000 152)      $(CC) -shared
-Wl,-soname,$@.$(LIB_VERSION) \
d54db501 (Zdenek Kabelac    2010-10-15 09:41:21 +0000 153)
$(CFLAGS) $(CLDFLAGS) -o $@ \
d54db501 (Zdenek Kabelac    2010-10-15 09:41:21 +0000 154)
@CLDWHOLEARCHIVE@ liblvm2cmd.a @CLDNOWHOLEARCHIVE@ \
d54db501 (Zdenek Kabelac    2010-10-15 09:41:21 +0000 155)
$(LVMLIBS) $(LIBS)

---

liblvm2cmd.$(LIB_SUFFIX): liblvm2cmd.a $(LDDEPS)
	$(CC) -shared -Wl,-soname,$@.$(LIB_VERSION) \
		$(CFLAGS) $(CLDFLAGS) -o $@ \
		@CLDWHOLEARCHIVE@ liblvm2cmd.a @CLDNOWHOLEARCHIVE@ \
		$(LVMLIBS) $(LIBS)

---

commit d54db5013b9ff5ebdf7cc3747b78e0cc39f72b39
Author: Zdenek Kabelac <zkabelac@redhat.com>
Date:   Fri Oct 15 09:41:21 2010 +0000

    Fix linking order for liblvm2cmd

    Reorder linked libraries so we better support --as-needed linker flag used
    by some distributions (i.e. Gentoo).

    Patch suggested by Diego Elio Petten? <flameeyes <at> gmail.com>

---


I suppose this should be fixing reported problem ?

Zdenek



      parent reply	other threads:[~2010-11-30 10:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-01 15:35 [PATCH] Fix liblvm2cmd.so linking order for --as-needed builds Diego Elio Pettenò
2010-10-12 13:55 ` Zdenek Kabelac
2010-10-12 14:26   ` Diego Elio Pettenò
2010-10-12 14:57     ` Zdenek Kabelac
2010-10-12 15:15       ` Przemyslaw Iskra
2010-10-15  9:50         ` Zdenek Kabelac
2010-11-30 10:31     ` Zdenek Kabelac [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CF4D285.7070005@redhat.com \
    --to=zkabelac@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.