Re: [PATCH 01/15] mountd: Clear mountd registrations at start up

[Steve Dickson <SteveD@redhat.com>]

On 10/10/2010 08:04 PM, Chuck Lever wrote:
> Clear stale MNT registrations before mountd tries to create fresh
> listeners, to ensure that mountd starts.  This is also what statd
> does.
> 
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
> 
>  utils/mountd/mountd.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/utils/mountd/mountd.c b/utils/mountd/mountd.c
> index d309950..7e0cf6a 100644
> --- a/utils/mountd/mountd.c
> +++ b/utils/mountd/mountd.c
> @@ -840,6 +840,7 @@ main(int argc, char **argv)
>  	if (new_cache)
>  		cache_open();
>  
> +	unregister_services();
>  	if (version2()) {
>  		listeners += nfs_svc_create("mountd", MOUNTPROG,
>  					MOUNTVERS, mount_dispatch, port);
> 
Question, since unregister_services() only unregisters version
that are currently requested, won't it miss unregistering 
version that are not currently requested, ones that are left over
from a previous instant of mountd? 

The point being all versions need to be unregistered at his point, 
not just the ones currently being requested. 

steved.