All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: disheng.su@gmail.com
Cc: qemu-devel@nongnu.org, edison <edison@cloud.com>
Subject: Re: [Qemu-devel] [PATCH] [V2] Copy snapshots out of QCOW2 disk
Date: Wed, 13 Oct 2010 17:40:29 +0200	[thread overview]
Message-ID: <4CB5D2ED.2060501@redhat.com> (raw)
In-Reply-To: <1285124321-32556-1-git-send-email-disheng.su@gmail.com>

Am 22.09.2010 04:58, schrieb disheng.su@gmail.com:
> From: edison <edison@cloud.com>
> 
> In order to backup snapshots, created from QCOW2 iamge, we want to copy snapshots out of QCOW2 disk to a seperate storage.
> The following patch adds a new option in "qemu-img": qemu-img convert -f qcow2 -O qcow2 -s snapshot_name src_img bck_img.
> Right now, it only supports to copy the full snapshot, delta snapshot is on the way.
> 
> Changes from V1: all the comments from Kevin are addressed:
> Add read-only checking
> Fix coding style
> Change the name from bdrv_snapshot_load to bdrv_snapshot_load_tmp
> 
> Signed-off-by: Disheng Su <edison@cloud.com>

Thanks, applied to the block branch.

Kevin

      reply	other threads:[~2010-10-13 15:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-22  2:58 [Qemu-devel] [PATCH] [V2] Copy snapshots out of QCOW2 disk disheng.su
2010-10-13 15:40 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CB5D2ED.2060501@redhat.com \
    --to=kwolf@redhat.com \
    --cc=disheng.su@gmail.com \
    --cc=edison@cloud.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.