All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Keir Fraser <keir@xen.org>,
	"Srujan D. Kotikela" <ksrujandas@gmail.com>
Subject: Re: Hypercalls from user-space
Date: Wed, 13 Oct 2010 09:45:38 -0700	[thread overview]
Message-ID: <4CB5E232.40308@goop.org> (raw)
In-Reply-To: <1286986809.2003.3551.camel@zakaz.uk.xensource.com>

 On 10/13/2010 09:20 AM, Ian Campbell wrote:
> On Tue, 2010-10-05 at 23:37 +0100, Jeremy Fitzhardinge wrote:
>> On 10/05/2010 03:09 PM, Keir Fraser wrote:
>>> /proc/xen/privcmd should be available in domU as well. You might need to
>>> enable some dom0 build config options to get it though.
>> xenfs doesn't init privcmd on non-privileged kernels.
>>
>> Srujan, this should be enough to enable it in domU:
> I see you fixed this properly in 66d850da but I think you also need the
> following:

Oops, thanks.

    J

>
> Subject: build privcmd for domU now that it is exposed
>
> Fixes build error introduced in 66d850da "xen/privcmd: make privcmd
> visible in domU"
>
> drivers/built-in.o:(.data+0xd44): undefined reference to `privcmd_file_ops'
> make[1]: *** [.tmp_vmlinux1] Error 1
> make: *** [sub-make] Error 2
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>
> diff --git a/drivers/xen/xenfs/Makefile b/drivers/xen/xenfs/Makefile
> index 4a0be9a..4fde944 100644
> --- a/drivers/xen/xenfs/Makefile
> +++ b/drivers/xen/xenfs/Makefile
> @@ -1,4 +1,4 @@
>  obj-$(CONFIG_XENFS) += xenfs.o
>  
> -xenfs-y			  = super.o xenbus.o
> -xenfs-$(CONFIG_XEN_DOM0) += xenstored.o privcmd.o
> +xenfs-y			  = super.o xenbus.o privcmd.o
> +xenfs-$(CONFIG_XEN_DOM0) += xenstored.o
>
>

  reply	other threads:[~2010-10-13 16:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-24 18:38 Hypercalls from user-space Srujan D. Kotikela
2010-09-24 19:14 ` Jeremy Fitzhardinge
2010-09-24 20:30   ` Ian Campbell
2010-10-05 21:31   ` Srujan D. Kotikela
2010-10-05 22:09     ` Keir Fraser
2010-10-05 22:37       ` Jeremy Fitzhardinge
2010-10-06  6:46         ` Keir Fraser
2010-10-13 16:20         ` Ian Campbell
2010-10-13 16:45           ` Jeremy Fitzhardinge [this message]
2010-09-27  7:33 ` Michal Novotny
2010-09-27 16:20   ` Srujan D. Kotikela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CB5E232.40308@goop.org \
    --to=jeremy@goop.org \
    --cc=Ian.Campbell@citrix.com \
    --cc=keir@xen.org \
    --cc=ksrujandas@gmail.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.