All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Henningsson <david.henningsson@canonical.com>
To: Valentine Sinitsyn <valentine.sinitsyn@gmail.com>
Cc: ALSA Development Mailing List <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] ALSA: hda: Add speaker pin to automute Acer Aspire 8943G
Date: Thu, 14 Oct 2010 09:49:07 +0200	[thread overview]
Message-ID: <4CB6B5F3.9000700@canonical.com> (raw)
In-Reply-To: <4CB69FA4.9030702@gmail.com>

On 2010-10-14 08:13, Valentine Sinitsyn wrote:
> Hi David,
>
> First of all, thank you for your work on subwoofer issues. I've had a
> chance to test them on my system lately, and they do really fix the bug
> reported, but another one (more serious, in my opinion) remains:
> subwoofer is not muted via normal mute button (more precisely, by muting
> Master ALSA mixer). The problem is that during autoconfiguration
> procedure, subwoofer is mapped on PCM channel, and there seems (at least
> to me) to be no reliable way to distinguish subwoofer from other
> possibly existing outputs on a general system and change this behavior.
> Creating dedicated presets for the machines with a subwoofer seems to be
> right way to workaround this, but then _quirks you've implemented should
> be merged with this preset.
>
> Does this sound reasonable to you or I am missing anything?

I would say that advertising this pin correctly to the driver is the 
first step. Trying to make the auto-parser treat this pin better would 
be a second step, separate from this patch. Making a new model (if that 
is what you call a "preset") would work as well, and might be easier for 
this particular case, while improving the auto-parser would be better in 
the long run.

Do you agree?

-- 
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic

  parent reply	other threads:[~2010-10-14  7:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-14  5:06 [PATCH] ALSA: hda: Add speaker pin to automute Acer Aspire 8943G David Henningsson
2010-10-14  6:13 ` Valentine Sinitsyn
2010-10-14  6:22   ` Raymond Yau
2010-10-14  6:38     ` Valentine Sinitsyn
2010-10-14  8:30       ` Raymond Yau
2010-10-14  8:40         ` Valentine Sinitsyn
2010-10-14  9:06           ` Raymond Yau
2010-10-14  7:49   ` David Henningsson [this message]
2010-10-14  8:33     ` Valentine Sinitsyn
2010-10-16  7:06   ` Raymond Yau
2010-10-14  8:10 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CB6B5F3.9000700@canonical.com \
    --to=david.henningsson@canonical.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=valentine.sinitsyn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.