All of lore.kernel.org
 help / color / mirror / Atom feed
From: Valentine Sinitsyn <valentine.sinitsyn@gmail.com>
To: ALSA Development Mailing List <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] ALSA: hda: Add speaker pin to automute Acer Aspire 8943G
Date: Thu, 14 Oct 2010 14:33:29 +0600	[thread overview]
Message-ID: <4CB6C059.8060708@gmail.com> (raw)
In-Reply-To: <4CB6B5F3.9000700@canonical.com>

> I would say that advertising this pin correctly to the driver is the
> first step.
That's true.

> Trying to make the auto-parser treat this pin better would
> be a second step, separate from this patch.
Definitely. But changing autoconfiguration behavior for this particular 
case requires extensive testing to prove that changes made for subwoofer 
code haven't affected any other systems with no subwoofer at all (and I 
don't have enough hardware to do it myself). As I've said, I know no 
reliable way to determine that particular pin is connected to a 
subwoofer - it appears like just another speaker pin.

> Making a new model (if that
> is what you call a "preset") would work as well, and might be easier for
It's not mine :-) The struct to store all model parameters is called 
alc_config_preset. Anyway, I meant this very thing.

> this particular case, while improving the auto-parser would be better in
> the long run.
That's true. In fact, they are not mutually exclusive: adding new models 
will have the benefits I've outlined in the last message, while having 
auto-parser treat subwoofer correctly means broader support for new 
machines.

Valentine

  reply	other threads:[~2010-10-14  8:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-14  5:06 [PATCH] ALSA: hda: Add speaker pin to automute Acer Aspire 8943G David Henningsson
2010-10-14  6:13 ` Valentine Sinitsyn
2010-10-14  6:22   ` Raymond Yau
2010-10-14  6:38     ` Valentine Sinitsyn
2010-10-14  8:30       ` Raymond Yau
2010-10-14  8:40         ` Valentine Sinitsyn
2010-10-14  9:06           ` Raymond Yau
2010-10-14  7:49   ` David Henningsson
2010-10-14  8:33     ` Valentine Sinitsyn [this message]
2010-10-16  7:06   ` Raymond Yau
2010-10-14  8:10 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CB6C059.8060708@gmail.com \
    --to=valentine.sinitsyn@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.