All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Gábor Stefanik" <netrolller.3d@gmail.com>,
	linux-wireless@vger.kernel.org,
	"John W. Linville" <linville@tuxdriver.com>,
	b43-dev@lists.infradead.org
Subject: [PATCH 1/3] b43: N-PHY: define channel table struct for rev3+ devices
Date: Fri, 15 Oct 2010 09:53:09 -0500	[thread overview]
Message-ID: <4CB86AD5.90205@lwfinger.net> (raw)
In-Reply-To: <AANLkTimvMCRVLzNjM+vsVEyHHAV0fLF4ABeV_20CdOCa@mail.gmail.com>

On 10/15/2010 09:27 AM, Rafa? Mi?ecki wrote:
> 
> There is "Chapter 12: Macros, Enums and RTL" in:
> http://www.kernel.org/doc/Documentation/CodingStyle
> 
> Some quotes:
> 1) "Macros with multiple statements should be enclosed in a do - while block:"
> 2) "macros defining constants using expressions must enclose the
> expression in parentheses"
> 
> Second one may sound like sth close, but it's just about expressions like:
> #define CONSTEXP (CONSTANT | 3)
> 
> So there doesn't seem to be any "rule" in CodingStyle wanting us to
> add parentheses when you suggested.

I think that scripts/checkpatch would report any definitions that need parentheses.

As you have probably figured out, I'm back home. If you have spec questions ;),
I'm ready.

Larry

WARNING: multiple messages have this Message-ID (diff)
From: Larry Finger <Larry.Finger@lwfinger.net>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Gábor Stefanik" <netrolller.3d@gmail.com>,
	linux-wireless@vger.kernel.org,
	"John W. Linville" <linville@tuxdriver.com>,
	b43-dev@lists.infradead.org
Subject: Re: [PATCH 1/3] b43: N-PHY: define channel table struct for rev3+ devices
Date: Fri, 15 Oct 2010 09:53:09 -0500	[thread overview]
Message-ID: <4CB86AD5.90205@lwfinger.net> (raw)
In-Reply-To: <AANLkTimvMCRVLzNjM+vsVEyHHAV0fLF4ABeV_20CdOCa@mail.gmail.com>

On 10/15/2010 09:27 AM, Rafał Miłecki wrote:
> 
> There is "Chapter 12: Macros, Enums and RTL" in:
> http://www.kernel.org/doc/Documentation/CodingStyle
> 
> Some quotes:
> 1) "Macros with multiple statements should be enclosed in a do - while block:"
> 2) "macros defining constants using expressions must enclose the
> expression in parentheses"
> 
> Second one may sound like sth close, but it's just about expressions like:
> #define CONSTEXP (CONSTANT | 3)
> 
> So there doesn't seem to be any "rule" in CodingStyle wanting us to
> add parentheses when you suggested.

I think that scripts/checkpatch would report any definitions that need parentheses.

As you have probably figured out, I'm back home. If you have spec questions ;),
I'm ready.

Larry

  reply	other threads:[~2010-10-15 14:53 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-14 21:01 [PATCH 1/3] b43: N-PHY: define channel table struct for rev3+ devices Rafał Miłecki
2010-10-14 21:01 ` Rafał Miłecki
2010-10-14 21:01 ` [PATCH 2/3] b43: N-PHY: define registers names for 2056 radio Rafał Miłecki
2010-10-14 21:01   ` Rafał Miłecki
2010-10-14 21:23   ` Luis R. Rodriguez
2010-10-14 21:23     ` Luis R. Rodriguez
2010-10-15 11:01     ` Rafał Miłecki
2010-10-15 11:01       ` Rafał Miłecki
2010-10-14 23:58   ` Gábor Stefanik
2010-10-14 23:58     ` Gábor Stefanik
2010-10-15 11:02     ` Rafał Miłecki
2010-10-15 11:02       ` Rafał Miłecki
2010-10-15 14:15       ` Gábor Stefanik
2010-10-15 14:15         ` Gábor Stefanik
2010-10-15 14:19         ` Gábor Stefanik
2010-10-15 14:19           ` Gábor Stefanik
2010-10-15 14:29         ` Rafał Miłecki
2010-10-15 14:29           ` Rafał Miłecki
2010-10-14 22:39 ` [PATCH 1/3] b43: N-PHY: define channel table struct for rev3+ devices Gábor Stefanik
2010-10-14 22:39   ` Gábor Stefanik
2010-10-15 10:58   ` Rafał Miłecki
2010-10-15 10:58     ` Rafał Miłecki
2010-10-15 14:13     ` Gábor Stefanik
2010-10-15 14:13       ` Gábor Stefanik
2010-10-15 14:27       ` Rafał Miłecki
2010-10-15 14:27         ` Rafał Miłecki
2010-10-15 14:53         ` Larry Finger [this message]
2010-10-15 14:53           ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CB86AD5.90205@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=b43-dev@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netrolller.3d@gmail.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.