From: Felix Fietkau <nbd@openwrt.org>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH v2] ath9k: Properly initialize ath_common->cc_lock.
Date: Sat, 16 Oct 2010 00:11:32 +0200 [thread overview]
Message-ID: <4CB8D194.9060907@openwrt.org> (raw)
In-Reply-To: <1287180249-18647-1-git-send-email-greearb@candelatech.com>
On 2010-10-16 12:04 AM, greearb at candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
>
> Otherwise, lockdep splats, at the least:
> [...]
> diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
> index a4c5ed4..fdc25f9 100644
> --- a/drivers/net/wireless/ath/ath9k/init.c
> +++ b/drivers/net/wireless/ath/ath9k/init.c
> @@ -577,6 +577,7 @@ static int ath9k_init_softc(u16 devid, struct ath_softc *sc, u16 subsysid,
> common->hw = sc->hw;
> common->priv = sc;
> common->debug_mask = ath9k_debug;
> + spin_lock_init(&common->cc_lock);
>
> spin_lock_init(&sc->wiphy_lock);
> spin_lock_init(&sc->sc_resetlock);
Makes sense. Please update ath5k as well, it also uses the lock.
- Felix
WARNING: multiple messages have this Message-ID (diff)
From: Felix Fietkau <nbd@openwrt.org>
To: greearb@candelatech.com
Cc: linux-wireless@vger.kernel.org, ath9k-devel@venema.h4ckr.net
Subject: Re: [PATCH v2] ath9k: Properly initialize ath_common->cc_lock.
Date: Sat, 16 Oct 2010 00:11:32 +0200 [thread overview]
Message-ID: <4CB8D194.9060907@openwrt.org> (raw)
In-Reply-To: <1287180249-18647-1-git-send-email-greearb@candelatech.com>
On 2010-10-16 12:04 AM, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
>
> Otherwise, lockdep splats, at the least:
> [...]
> diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
> index a4c5ed4..fdc25f9 100644
> --- a/drivers/net/wireless/ath/ath9k/init.c
> +++ b/drivers/net/wireless/ath/ath9k/init.c
> @@ -577,6 +577,7 @@ static int ath9k_init_softc(u16 devid, struct ath_softc *sc, u16 subsysid,
> common->hw = sc->hw;
> common->priv = sc;
> common->debug_mask = ath9k_debug;
> + spin_lock_init(&common->cc_lock);
>
> spin_lock_init(&sc->wiphy_lock);
> spin_lock_init(&sc->sc_resetlock);
Makes sense. Please update ath5k as well, it also uses the lock.
- Felix
next prev parent reply other threads:[~2010-10-15 22:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 22:04 [ath9k-devel] [PATCH v2] ath9k: Properly initialize ath_common->cc_lock greearb at candelatech.com
2010-10-15 22:04 ` greearb
2010-10-15 22:11 ` Felix Fietkau [this message]
2010-10-15 22:11 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB8D194.9060907@openwrt.org \
--to=nbd@openwrt.org \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.