All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Cc: kosaki.motohiro@jp.fujitsu.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] blk: fix a wrong accounting of hd_struct->in_flight
Date: Tue, 19 Oct 2010 12:02:18 +0200	[thread overview]
Message-ID: <4CBD6CAA.1060708@kernel.dk> (raw)
In-Reply-To: <4CBD00F7.3070503@jp.fujitsu.com>

On 2010-10-19 04:22, Yasuaki Ishimatsu wrote:
> Hi Jens,
> 
>> This version looks good, thanks for following through on this. What kind
>> of testing did you do?
> 
> I did three kinds of test.
> 
> 1. run a reproducer.
>    I confirmed the problem was fixed using attached the reproducer.
> 
> 2. remove and make a partition which is running I/O.
>    I confirmed the kernel panic or hungup did not occur using following steps.
> 
>      # dd if=/dev/sda of=null &
>      # while true
>      > do
>      > /sbin/parted /dev/sda rm 3 > /dev/null
>      > /sbin/parted /dev/sda mkpart primary ext2 42.5GB 52.5GB > /dev/null
>      > sleep 2
>      > done
> 
> 3. reload a partition which is running I/O.
>    I confirmed the kernel panic or hungup did not occur using following steps.
> 
>      # dd if=/dev/sda of=null &
>      # while true
>      > do
>      > /sbin/hdparm -z /dev/sda
>      > sleep 2
>      > done

Thanks, sounds good! I have queued it up for 2.6.37 and marked as a
stable backport candidate.

-- 
Jens Axboe


  reply	other threads:[~2010-10-19 10:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-12  6:38 [PATCH] blk: fix a wrong accounting of hd_struct->in_flight Yasuaki Ishimatsu
2010-10-12  8:19 ` Jens Axboe
2010-10-14 12:48   ` [PATCH v2] " Yasuaki Ishimatsu
2010-10-14 12:55     ` Jens Axboe
2010-10-15  8:39       ` [PATCH v3] " Yasuaki Ishimatsu
2010-10-15 10:04         ` Jens Axboe
2010-10-18  8:28           ` [PATCH v4] " Yasuaki Ishimatsu
2010-10-18  8:34             ` Jens Axboe
2010-10-18 12:19               ` [PATCH v5] " Yasuaki Ishimatsu
2010-10-18 12:21                 ` Jens Axboe
2010-10-19  2:22                   ` Yasuaki Ishimatsu
2010-10-19 10:02                     ` Jens Axboe [this message]
2010-10-14  6:07 ` [PATCH] " KOSAKI Motohiro
2010-10-14 12:44   ` Jens Axboe
2010-10-14 23:30     ` Paul E. McKenney
2010-10-15  7:30       ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CBD6CAA.1060708@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=isimatu.yasuaki@jp.fujitsu.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.