All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] usb: add public usb_device_by_id
Date: Tue, 19 Oct 2010 15:09:38 +0200	[thread overview]
Message-ID: <4CBD9892.2040301@redhat.com> (raw)
In-Reply-To: <1287484411-13611-3-git-send-email-alevy@redhat.com>

> +USBDevice *usb_device_by_id(const char* id)
> +{
> +    USBBus *bus;
> +    DeviceState *qdev;
> +    USBDevice *dev;
> +
> +    QTAILQ_FOREACH(bus,&busses, next) {
> +        qdev = qdev_find_recursive(&bus->qbus, id);
> +        if (qdev != NULL) {
> +            dev = DO_UPCAST(USBDevice, qdev, qdev);
> +            return dev;
> +        }
> +    }

You don't need qdev_find_recursive here.  Have a look at the usb_info() 
code to see how to loop over all usb devices.  Then compare id with 
USBDevice->qdev.id.

cheers,
   Gerd

  reply	other threads:[~2010-10-19 13:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-19 10:33 [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v2) Alon Levy
2010-10-19 10:33 ` [Qemu-devel] [PATCH 1/3] qdev: make qdev_find_recursive public Alon Levy
2010-10-19 10:33 ` [Qemu-devel] [PATCH 2/3] usb: add public usb_device_by_id Alon Levy
2010-10-19 13:09   ` Gerd Hoffmann [this message]
2010-10-19 13:13     ` Alon Levy
2010-10-19 13:30       ` Gerd Hoffmann
2010-10-19 10:33 ` [Qemu-devel] [PATCH 3/3] monitor: add usb_attach and usb_detach Alon Levy
2010-10-19 13:35   ` Gerd Hoffmann
2010-10-20 16:24     ` Luiz Capitulino
2010-10-21 10:00       ` Gerd Hoffmann
2010-10-21 10:58         ` Alon Levy
2010-10-21 19:18       ` Alon Levy
  -- strict thread matches above, loose matches on Subject: below --
2010-10-21  6:36 [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3) Alon Levy
2010-10-21  6:36 ` [Qemu-devel] [PATCH 2/3] usb: add public usb_device_by_id Alon Levy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CBD9892.2040301@redhat.com \
    --to=kraxel@redhat.com \
    --cc=alevy@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.