Re: [Qemu-devel] [PATCH 3/3] monitor: add usb_attach and usb_detach

[Gerd Hoffmann <kraxel@redhat.com>]

On 10/20/10 18:24, Luiz Capitulino wrote:
> On Tue, 19 Oct 2010 15:35:01 +0200
> Gerd Hoffmann<kraxel@redhat.com>  wrote:
>
>>     Hi,
>>
>>> +        .help       = "attach USB device 'bus.addr'",
>>
>>> +@item usb_attach @var{devname}
>>
>> /me sees a mismatch here.
>>
>> There is still the use case question.  Also note that this might have
>> unwanted side effects when drivers automagically attach/detach devices
>> like usb-host.
>
> Alon, did you check this? I hope it doesn't blowup.
>
>> Having this purely for debugging/troubleshooting purposes would be fine
>> with me, but the documentation should clearly say so.
>
> Is this useful in production or only in the development of new devices?

I'd say more a development tool.

> If
> it's the letter, then I would even prefer enabling them only when DEBUG
> is enabled.

Makes sense indeed.

cheers,
   Gerd