From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Ralph Campbell <ralph.campbell-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org>
Cc: Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>,
Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Hal Rosenstock
<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
lkml <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v2.6.36-rc7] infiniband: update workqueue usage
Date: Wed, 20 Oct 2010 10:37:03 +0200 [thread overview]
Message-ID: <4CBEAA2F.6000009@kernel.org> (raw)
In-Reply-To: <1287508926.27343.299.camel-/vjeY7uYZjrPXfVEPVhPGq6RkeBMCJyt@public.gmane.org>
Hello,
On 10/19/2010 07:22 PM, Ralph Campbell wrote:
> On Tue, 2010-10-19 at 08:24 -0700, Tejun Heo wrote:
>
>> * qib_cq_wq is a separate singlethread workqueue. Does the queue
>> require strict single thread execution ordering? IOW, does each
>> work have to be executed in the exact queued order and no two works
>> should execute in parallel? Or was the singlethreadedness chosen
>> just to reduce the number of workers?
>
> The work functions need to be called in-order and single threaded
> or memory will be freed multiple times and other "bad things".
I see, so they'll need to be converted to alloc_ordered_workqueue()
once -rc1 merge window opens up. I'll follow up with the conversion.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Ralph Campbell <ralph.campbell@qlogic.com>
Cc: Roland Dreier <rolandd@cisco.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2.6.36-rc7] infiniband: update workqueue usage
Date: Wed, 20 Oct 2010 10:37:03 +0200 [thread overview]
Message-ID: <4CBEAA2F.6000009@kernel.org> (raw)
In-Reply-To: <1287508926.27343.299.camel@chromite.mv.qlogic.com>
Hello,
On 10/19/2010 07:22 PM, Ralph Campbell wrote:
> On Tue, 2010-10-19 at 08:24 -0700, Tejun Heo wrote:
>
>> * qib_cq_wq is a separate singlethread workqueue. Does the queue
>> require strict single thread execution ordering? IOW, does each
>> work have to be executed in the exact queued order and no two works
>> should execute in parallel? Or was the singlethreadedness chosen
>> just to reduce the number of workers?
>
> The work functions need to be called in-order and single threaded
> or memory will be freed multiple times and other "bad things".
I see, so they'll need to be converted to alloc_ordered_workqueue()
once -rc1 merge window opens up. I'll follow up with the conversion.
Thanks.
--
tejun
next prev parent reply other threads:[~2010-10-20 8:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 15:24 [PATCH v2.6.36-rc7] infiniband: update workqueue usage Tejun Heo
2010-10-19 15:24 ` Tejun Heo
[not found] ` <4CBDB834.2050905-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2010-10-19 17:22 ` Ralph Campbell
2010-10-19 17:22 ` Ralph Campbell
[not found] ` <1287508926.27343.299.camel-/vjeY7uYZjrPXfVEPVhPGq6RkeBMCJyt@public.gmane.org>
2010-10-20 8:37 ` Tejun Heo [this message]
2010-10-20 8:37 ` Tejun Heo
2010-10-19 18:40 ` Bart Van Assche
2010-10-19 18:40 ` Bart Van Assche
2010-10-20 8:38 ` Tejun Heo
2010-10-20 8:38 ` Tejun Heo
[not found] ` <4CBEAA6E.2060000-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2010-10-20 10:21 ` Bart Van Assche
2010-10-20 10:21 ` Bart Van Assche
2010-10-20 11:03 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CBEAA2F.6000009@kernel.org \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ralph.campbell-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org \
--cc=rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.