Re: [PATCH 2.6.37] RDMA/cxgb3: When a user QP is marked in error, also mark the CQs in error.

[Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>]

On 10/20/2010 05:10 PM, Hefty, Sean wrote:
>> @@ -217,15 +218,24 @@ static struct ib_cq *iwch_create_cq(struct ib_device
>> *ibdev, int entries, int ve
>>   		uresp.key = ucontext->key;
>>   		ucontext->key += PAGE_SIZE;
>>   		spin_unlock(&ucontext->mmap_lock);
>> +		mm->key = uresp.key;
>> +		mm->addr = virt_to_phys(chp->cq.queue);
>> +		if (udata->outlen<  sizeof uresp) {
>> +			if (!warned++)
>> +				printk(KERN_WARNING MOD "Warning - "
>> +				       "downlevel libcxgb3 (non-fatal).\n");
>> +			mm->len = PAGE_ALIGN((1UL<<  uresp.size_log2) *
>> +					     sizeof(struct t3_cqe));
>> +		} else {
>> +			mm->len = PAGE_ALIGN(((1UL<<  uresp.size_log2) + 1) *
>> +					     sizeof(struct t3_cqe));
>> +			uresp.memsize = mm->len;
>> +		}
>>   		if (ib_copy_to_udata(udata,&uresp, sizeof (uresp))) {
>>      
> Is this correct?  udata->outlen can be less than sizeof uresp here.
>
>    

The only way it can be less is if the library is using the ABI 0 version 
of the response struct.  Or am I missing something?

Steve.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html