All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: "Kevin O'Connor" <kevin@koconnor.net>
Cc: Gleb Natapov <gleb@redhat.com>,
	seabios@seabios.org, Anthony Liguori <anthony@codemonkey.ws>,
	qemu-devel <qemu-devel@nongnu.org>,
	KVM list <kvm@vger.kernel.org>,
	"Justin M. Forbes" <jforbes@redhat.com>
Subject: Re: [SeaBIOS] [PATCH] mark irq9 active high in DSDT
Date: Thu, 21 Oct 2010 12:07:17 +0200	[thread overview]
Message-ID: <4CC010D5.7070103@redhat.com> (raw)
In-Reply-To: <20101021020020.GA21095@morn.localdomain>

  On 10/21/2010 04:00 AM, Kevin O'Connor wrote:
> On Wed, Oct 20, 2010 at 11:34:41AM +0200, Gleb Natapov wrote:
> >  In PIIX4 SCI (irq9) is active high. Seabios marks it so in interrupt
> >  override table, but some OSes (FreeBSD) require the same information to
> >  be present in DSDT too. Make it so.
> >
> >  Signed-off-by: Gleb Natapov<gleb@redhat.com>
>
> Thanks.

How do we manage the stable series wrt this issue?

qemu-kvm-0.12.5 has a regression within the stable series that this 
patch fixes.  qemu 0.12.5 does not, but only because it does not emulate 
polarity in the I/O APIC correctly.

There are several paths we could take:

- do nothing, bug is fixed in mainline
- release a seabios 0.x.1 for qemu 0.13.1 with this patch
- same, plus seabios 0.y.1 for qemu 0.12.6 with this patch
- skip qemu (which is not truly affected), patch qemu-kvm's copy of 
seabios for both 0.12.z and 0.13.z

The third option is the most "correct" from a release engineering point 
of view, but involves more work for everyone.  The fourth is quick pain 
relief but is a little forky.

-- 
error compiling committee.c: too many arguments to function


WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: KVM list <kvm@vger.kernel.org>,
	seabios@seabios.org, qemu-devel <qemu-devel@nongnu.org>,
	Gleb Natapov <gleb@redhat.com>,
	"Justin M. Forbes" <jforbes@redhat.com>
Subject: [Qemu-devel] Re: [SeaBIOS] [PATCH] mark irq9 active high in DSDT
Date: Thu, 21 Oct 2010 12:07:17 +0200	[thread overview]
Message-ID: <4CC010D5.7070103@redhat.com> (raw)
In-Reply-To: <20101021020020.GA21095@morn.localdomain>

  On 10/21/2010 04:00 AM, Kevin O'Connor wrote:
> On Wed, Oct 20, 2010 at 11:34:41AM +0200, Gleb Natapov wrote:
> >  In PIIX4 SCI (irq9) is active high. Seabios marks it so in interrupt
> >  override table, but some OSes (FreeBSD) require the same information to
> >  be present in DSDT too. Make it so.
> >
> >  Signed-off-by: Gleb Natapov<gleb@redhat.com>
>
> Thanks.

How do we manage the stable series wrt this issue?

qemu-kvm-0.12.5 has a regression within the stable series that this 
patch fixes.  qemu 0.12.5 does not, but only because it does not emulate 
polarity in the I/O APIC correctly.

There are several paths we could take:

- do nothing, bug is fixed in mainline
- release a seabios 0.x.1 for qemu 0.13.1 with this patch
- same, plus seabios 0.y.1 for qemu 0.12.6 with this patch
- skip qemu (which is not truly affected), patch qemu-kvm's copy of 
seabios for both 0.12.z and 0.13.z

The third option is the most "correct" from a release engineering point 
of view, but involves more work for everyone.  The fourth is quick pain 
relief but is a little forky.

-- 
error compiling committee.c: too many arguments to function

       reply	other threads:[~2010-10-21 10:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20101020093441.GP10207@redhat.com>
     [not found] ` <20101021020020.GA21095@morn.localdomain>
2010-10-21 10:07   ` Avi Kivity [this message]
2010-10-21 10:07     ` [Qemu-devel] Re: [SeaBIOS] [PATCH] mark irq9 active high in DSDT Avi Kivity
2010-10-23 14:12     ` Kevin O'Connor
2010-10-23 14:12       ` [Qemu-devel] " Kevin O'Connor
2010-10-25 10:52       ` Avi Kivity
2010-10-25 10:52         ` [Qemu-devel] " Avi Kivity
2010-10-27 13:27         ` Avi Kivity
2010-10-27 13:27           ` [Qemu-devel] " Avi Kivity
2010-10-31 22:46           ` Kevin O'Connor
2010-10-31 22:46             ` [Qemu-devel] " Kevin O'Connor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CC010D5.7070103@redhat.com \
    --to=avi@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=gleb@redhat.com \
    --cc=jforbes@redhat.com \
    --cc=kevin@koconnor.net \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=seabios@seabios.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.