All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: "akpm >> Andrew Morton" <akpm@linux-foundation.org>
Cc: Paul Menage <menage@google.com>,
	Stephane Eranian <eranian@google.com>,
	LKML <linux-kernel@vger.kernel.org>,
	containers@lists.linux-foundation.org
Subject: [PATCH 7/7] cgroups: Update documentation for bindable subsystems
Date: Fri, 22 Oct 2010 16:12:25 +0800	[thread overview]
Message-ID: <4CC14769.2000406@cn.fujitsu.com> (raw)
In-Reply-To: <4CC146A4.9090505@cn.fujitsu.com>

Provide a usage example, and update the bind() callback API.

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
 Documentation/cgroups/cgroups.txt |   26 +++++++++++++++++---------
 1 files changed, 17 insertions(+), 9 deletions(-)

diff --git a/Documentation/cgroups/cgroups.txt b/Documentation/cgroups/cgroups.txt
index 190018b..5b5382a 100644
--- a/Documentation/cgroups/cgroups.txt
+++ b/Documentation/cgroups/cgroups.txt
@@ -363,17 +363,23 @@ Note this will add ns to the hierarchy but won't remove memory or
 cpuset, because the new options are appended to the old ones:
 # mount -o remount,ns /dev/cgroup
 
+For some subsystems you can bind them to a mounted hierarchy or
+remove them from it, even if there're sub-cgroups in it:
+# mount -t cgroup -o freezer hier1 /dev/cgroup
+# echo $$ > /dev/cgroup/my_cgroup
+# mount -o freezer,cpuset hier1 /dev/cgroup
+(failed)
+# mount -o freezer,cpuacct hier1 /dev/cgroup
+# mount -o cpuacct hier1 /dev/cgroup
+
+Note cpuacct should be sit in the default hierarchy before remount.
+
 To Specify a hierarchy's release_agent:
 # mount -t cgroup -o cpuset,release_agent="/sbin/cpuset_release_agent" \
   xxx /dev/cgroup
 
 Note that specifying 'release_agent' more than once will return failure.
 
-Note that changing the set of subsystems is currently only supported
-when the hierarchy consists of a single (root) cgroup. Supporting
-the ability to arbitrarily bind/unbind subsystems from an existing
-cgroup hierarchy is intended to be implemented in the future.
-
 Then under /dev/cgroup you can find a tree that corresponds to the
 tree of the cgroups in the system. For instance, /dev/cgroup
 is the cgroup that holds the whole system.
@@ -623,13 +629,15 @@ initialization which might be required before a task could attach.  For
 example in cpusets, no task may attach before 'cpus' and 'mems' are set
 up.
 
-void bind(struct cgroup_subsys *ss, struct cgroup *root)
+void bind(struct cgroup_subsys *ss, struct cgroup *cgrp, bool unbind)
 (cgroup_mutex and ss->hierarchy_mutex held by caller)
 
 Called when a cgroup subsystem is rebound to a different hierarchy
-and root cgroup. Currently this will only involve movement between
-the default hierarchy (which never has sub-cgroups) and a hierarchy
-that is being created/destroyed (and hence has no sub-cgroups).
+and root cgroup. For some subsystems this will only involve movement
+between the default hierarchy (which never has sub-cgroups) and a
+hierarchy that is being created/destroyed (and hence has no sub-cgroups).
+For some other subsystems this can involve movement between the default
+hierarchy and a mounted hierarchy which may have sub-cgroups in it.
 
 4. Questions
 ============
-- 
1.7.0.1


  parent reply	other threads:[~2010-10-22  8:11 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-22  8:09 [PATCH 0/7] cgroups: Allow to bind/unbind subsystems to/from non-trival hierarchy Li Zefan
     [not found] ` <4CC146A4.9090505-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2010-10-22  8:09   ` [PATCH 1/7] cgroups: Shrink struct cgroup_subsys Li Zefan
2010-10-22  8:09   ` [PATCH 2/7] cgroups: Allow to bind a subsystem to a cgroup hierarchy Li Zefan
2010-10-22  8:09     ` Li Zefan
2010-10-22 12:47     ` Peter Zijlstra
2010-10-25  0:59       ` Li Zefan
2010-10-25  0:59       ` Li Zefan
     [not found]     ` <4CC146D4.7030009-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2010-10-22 12:47       ` Peter Zijlstra
2010-10-22 21:38       ` Matt Helsley
2010-10-28 23:55       ` Paul Menage
2010-10-28 23:55         ` Paul Menage
2010-11-08  5:26         ` Li Zefan
     [not found]         ` <AANLkTimCD90s+y_6y=LyOL1QqEOOAaT+b2b4guDrzo_g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-11-08  5:26           ` Li Zefan
2010-10-22 21:38     ` Matt Helsley
     [not found]       ` <20101022213819.GK10119-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2010-10-25  1:23         ` Li Zefan
2010-10-25  1:23           ` Li Zefan
2010-10-28 23:57         ` Paul Menage
2010-10-28 23:57       ` Paul Menage
2010-10-22  8:10   ` [PATCH 3/7] cgroups: Allow to unbind subsystem from a cgroup hierarachy Li Zefan
2010-10-22  8:11   ` [PATCH 4/7] cgroups: Mark some subsystems bindable Li Zefan
2010-10-22  8:11   ` [PATCH 5/7] cgroups: Make freezer subsystem bindable Li Zefan
2010-10-22  8:12   ` [PATCH 6/7] cgroups: Warn if a bindable subsystem calls css_get() Li Zefan
2010-10-22  8:12   ` [PATCH 7/7] cgroups: Update documentation for bindable subsystems Li Zefan
2010-10-22 12:50   ` [PATCH 0/7] cgroups: Allow to bind/unbind subsystems to/from non-trival hierarchy Peter Zijlstra
2010-10-22  8:09 ` [PATCH 1/7] cgroups: Shrink struct cgroup_subsys Li Zefan
     [not found]   ` <4CC146BA.7080009-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2010-10-28 23:34     ` Paul Menage
2010-10-28 23:34   ` Paul Menage
2010-11-08  5:23     ` Li Zefan
     [not found]       ` <4CD78946.5060405-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2010-11-09 21:05         ` Paul Menage
2010-11-09 21:05       ` Paul Menage
     [not found]         ` <AANLkTim6d1fQLZbkmZST3PTN0RMSs3m=oossF81pYBn9-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-11-10  0:52           ` Li Zefan
2010-11-10  0:52         ` Li Zefan
2010-11-10  1:53           ` Paul Menage
     [not found]             ` <AANLkTinMr7VE4Os7rXWjiHWOVysv=oE0vHKduLWCN0bC-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-11-10  2:06               ` Li Zefan
2010-11-10  2:06             ` Li Zefan
2010-11-10  2:15               ` Paul Menage
     [not found]               ` <4CD9FE2D.2070108-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2010-11-10  2:15                 ` Paul Menage
     [not found]           ` <4CD9ECD2.3030805-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2010-11-10  1:53             ` Paul Menage
     [not found]     ` <AANLkTikf-1kLStxqi5UjP=vn3pqVBHy0OA7ibeWTkJ5z-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-11-08  5:23       ` Li Zefan
2010-10-22  8:10 ` [PATCH 3/7] cgroups: Allow to unbind subsystem from a cgroup hierarachy Li Zefan
     [not found]   ` <4CC146F5.9060006-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2010-10-29  0:02     ` Paul Menage
2010-10-29  0:02   ` Paul Menage
2010-10-22  8:11 ` [PATCH 4/7] cgroups: Mark some subsystems bindable Li Zefan
2010-10-22  8:11 ` [PATCH 5/7] cgroups: Make freezer subsystem bindable Li Zefan
     [not found]   ` <4CC1473D.9070201-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2010-10-22 20:57     ` Matt Helsley
2010-10-22 20:57       ` Matt Helsley
2010-10-22 21:46       ` Matt Helsley
     [not found]         ` <20101022214650.GL10119-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2010-10-29  0:06           ` Paul Menage
2010-10-29  0:06         ` Paul Menage
2010-10-22 21:57       ` Matt Helsley
2010-10-25  1:15       ` Li Zefan
     [not found]       ` <20101022205755.GJ10119-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2010-10-22 21:46         ` Matt Helsley
2010-10-22 21:57         ` Matt Helsley
2010-10-25  1:15         ` Li Zefan
2010-10-22  8:12 ` [PATCH 6/7] cgroups: Warn if a bindable subsystem calls css_get() Li Zefan
     [not found]   ` <4CC14756.5010504-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2010-10-29  0:05     ` Paul Menage
2010-10-29  0:05   ` Paul Menage
2010-10-22  8:12 ` Li Zefan [this message]
2010-10-25  0:36   ` [PATCH 7/7] cgroups: Update documentation for bindable subsystems KAMEZAWA Hiroyuki
     [not found]     ` <20101025093617.7de750c0.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2010-10-25  0:52       ` Li Zefan
2010-10-25  0:52     ` Li Zefan
     [not found]       ` <4CC4D4B9.3020807-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2010-10-25  0:56         ` Li Zefan
2010-10-25  0:56       ` Li Zefan
2010-10-29  0:13   ` Paul Menage
2010-10-29  0:15     ` Paul Menage
     [not found]     ` <AANLkTinbtLkF=haFeDkzecEWv_FE9jG4TefiptSnZcPi-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-10-29  0:15       ` Paul Menage
2010-11-08  5:27       ` Li Zefan
2010-11-08  5:27     ` Li Zefan
     [not found]   ` <4CC14769.2000406-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2010-10-25  0:36     ` KAMEZAWA Hiroyuki
2010-10-29  0:13     ` Paul Menage
2010-10-22 12:50 ` [PATCH 0/7] cgroups: Allow to bind/unbind subsystems to/from non-trival hierarchy Peter Zijlstra
2010-10-25  1:07   ` Li Zefan
     [not found]     ` <4CC4D84C.5000705-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2010-10-28 23:33       ` Paul Menage
2010-10-28 23:33     ` Paul Menage
2010-10-25  1:07   ` Li Zefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CC14769.2000406@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=containers@lists.linux-foundation.org \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=menage@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.