From: Li Zefan <lizf@cn.fujitsu.com>
To: Paul Menage <menage@google.com>
Cc: "akpm >> Andrew Morton" <akpm@linux-foundation.org>,
Stephane Eranian <eranian@google.com>,
LKML <linux-kernel@vger.kernel.org>,
containers@lists.linux-foundation.org
Subject: Re: [PATCH 2/7] cgroups: Allow to bind a subsystem to a cgroup hierarchy
Date: Mon, 08 Nov 2010 13:26:13 +0800 [thread overview]
Message-ID: <4CD789F5.4000208@cn.fujitsu.com> (raw)
In-Reply-To: <AANLkTimCD90s+y_6y=LyOL1QqEOOAaT+b2b4guDrzo_g@mail.gmail.com>
Paul Menage wrote:
> On Fri, Oct 22, 2010 at 1:09 AM, Li Zefan <lizf@cn.fujitsu.com> wrote:
>> + /*
>> + * Indicate if this subsystem can be bound/unbound to/from a cgroup
>> + * hierarchy which has child cgroups.
>> + */
>> + unsigned int can_bind:1;
>
> Maybe call this "bindable"?
>
> Basic idea looks great, it could do with a bunch more comments, and
> maybe locking rules.
>
> Is there any chance of a lock inversion between dir->i_mutex and
> cgroup_lock in hierarchy_popuiate_dir() ?
>
The lock order is:
mutex_lock(&dir->i_mutex)
mutex_lock(&cgroup_mutex)
mutex_lock(&dir->i_mutex, I_MUTEX_CHILD)
it should be safe.
next prev parent reply other threads:[~2010-11-08 5:25 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 8:09 [PATCH 0/7] cgroups: Allow to bind/unbind subsystems to/from non-trival hierarchy Li Zefan
[not found] ` <4CC146A4.9090505-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2010-10-22 8:09 ` [PATCH 1/7] cgroups: Shrink struct cgroup_subsys Li Zefan
2010-10-22 8:09 ` [PATCH 2/7] cgroups: Allow to bind a subsystem to a cgroup hierarchy Li Zefan
2010-10-22 8:09 ` Li Zefan
[not found] ` <4CC146D4.7030009-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2010-10-22 12:47 ` Peter Zijlstra
2010-10-22 21:38 ` Matt Helsley
2010-10-28 23:55 ` Paul Menage
2010-10-28 23:55 ` Paul Menage
2010-11-08 5:26 ` Li Zefan [this message]
[not found] ` <AANLkTimCD90s+y_6y=LyOL1QqEOOAaT+b2b4guDrzo_g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-11-08 5:26 ` Li Zefan
2010-10-22 12:47 ` Peter Zijlstra
2010-10-25 0:59 ` Li Zefan
2010-10-25 0:59 ` Li Zefan
2010-10-22 21:38 ` Matt Helsley
[not found] ` <20101022213819.GK10119-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2010-10-25 1:23 ` Li Zefan
2010-10-25 1:23 ` Li Zefan
2010-10-28 23:57 ` Paul Menage
2010-10-28 23:57 ` Paul Menage
2010-10-22 8:10 ` [PATCH 3/7] cgroups: Allow to unbind subsystem from a cgroup hierarachy Li Zefan
2010-10-22 8:11 ` [PATCH 4/7] cgroups: Mark some subsystems bindable Li Zefan
2010-10-22 8:11 ` [PATCH 5/7] cgroups: Make freezer subsystem bindable Li Zefan
2010-10-22 8:12 ` [PATCH 6/7] cgroups: Warn if a bindable subsystem calls css_get() Li Zefan
2010-10-22 8:12 ` [PATCH 7/7] cgroups: Update documentation for bindable subsystems Li Zefan
2010-10-22 12:50 ` [PATCH 0/7] cgroups: Allow to bind/unbind subsystems to/from non-trival hierarchy Peter Zijlstra
2010-10-22 8:09 ` [PATCH 1/7] cgroups: Shrink struct cgroup_subsys Li Zefan
[not found] ` <4CC146BA.7080009-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2010-10-28 23:34 ` Paul Menage
2010-10-28 23:34 ` Paul Menage
[not found] ` <AANLkTikf-1kLStxqi5UjP=vn3pqVBHy0OA7ibeWTkJ5z-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-11-08 5:23 ` Li Zefan
2010-11-08 5:23 ` Li Zefan
2010-11-09 21:05 ` Paul Menage
[not found] ` <AANLkTim6d1fQLZbkmZST3PTN0RMSs3m=oossF81pYBn9-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-11-10 0:52 ` Li Zefan
2010-11-10 0:52 ` Li Zefan
2010-11-10 1:53 ` Paul Menage
[not found] ` <AANLkTinMr7VE4Os7rXWjiHWOVysv=oE0vHKduLWCN0bC-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-11-10 2:06 ` Li Zefan
2010-11-10 2:06 ` Li Zefan
2010-11-10 2:15 ` Paul Menage
[not found] ` <4CD9FE2D.2070108-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2010-11-10 2:15 ` Paul Menage
[not found] ` <4CD9ECD2.3030805-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2010-11-10 1:53 ` Paul Menage
[not found] ` <4CD78946.5060405-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2010-11-09 21:05 ` Paul Menage
2010-10-22 8:10 ` [PATCH 3/7] cgroups: Allow to unbind subsystem from a cgroup hierarachy Li Zefan
[not found] ` <4CC146F5.9060006-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2010-10-29 0:02 ` Paul Menage
2010-10-29 0:02 ` Paul Menage
2010-10-22 8:11 ` [PATCH 4/7] cgroups: Mark some subsystems bindable Li Zefan
2010-10-22 8:11 ` [PATCH 5/7] cgroups: Make freezer subsystem bindable Li Zefan
[not found] ` <4CC1473D.9070201-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2010-10-22 20:57 ` Matt Helsley
2010-10-22 20:57 ` Matt Helsley
2010-10-22 21:46 ` Matt Helsley
2010-10-29 0:06 ` Paul Menage
[not found] ` <20101022214650.GL10119-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2010-10-29 0:06 ` Paul Menage
2010-10-22 21:57 ` Matt Helsley
2010-10-25 1:15 ` Li Zefan
[not found] ` <20101022205755.GJ10119-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2010-10-22 21:46 ` Matt Helsley
2010-10-22 21:57 ` Matt Helsley
2010-10-25 1:15 ` Li Zefan
2010-10-22 8:12 ` [PATCH 6/7] cgroups: Warn if a bindable subsystem calls css_get() Li Zefan
2010-10-29 0:05 ` Paul Menage
[not found] ` <4CC14756.5010504-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2010-10-29 0:05 ` Paul Menage
2010-10-22 8:12 ` [PATCH 7/7] cgroups: Update documentation for bindable subsystems Li Zefan
2010-10-25 0:36 ` KAMEZAWA Hiroyuki
2010-10-25 0:52 ` Li Zefan
2010-10-25 0:56 ` Li Zefan
[not found] ` <4CC4D4B9.3020807-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2010-10-25 0:56 ` Li Zefan
[not found] ` <20101025093617.7de750c0.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2010-10-25 0:52 ` Li Zefan
[not found] ` <4CC14769.2000406-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2010-10-25 0:36 ` KAMEZAWA Hiroyuki
2010-10-29 0:13 ` Paul Menage
2010-10-29 0:13 ` Paul Menage
2010-10-29 0:15 ` Paul Menage
[not found] ` <AANLkTinbtLkF=haFeDkzecEWv_FE9jG4TefiptSnZcPi-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-10-29 0:15 ` Paul Menage
2010-11-08 5:27 ` Li Zefan
2010-11-08 5:27 ` Li Zefan
2010-10-22 12:50 ` [PATCH 0/7] cgroups: Allow to bind/unbind subsystems to/from non-trival hierarchy Peter Zijlstra
2010-10-25 1:07 ` Li Zefan
2010-10-25 1:07 ` Li Zefan
[not found] ` <4CC4D84C.5000705-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2010-10-28 23:33 ` Paul Menage
2010-10-28 23:33 ` Paul Menage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD789F5.4000208@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.linux-foundation.org \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.