From: Clemens Ladisch <clemens@ladisch.de>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: alsa-devel@alsa-project.org, Valdis.Kletnieks@vt.edu,
Takashi Iwai <tiwai@suse.de>,
linux-kernel@vger.kernel.org, mm-commits@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: HDA: no sound [was: mmotm 2010-10-20-15-01 uploaded]
Date: Fri, 22 Oct 2010 13:31:53 +0200 [thread overview]
Message-ID: <4CC17629.6050703@ladisch.de> (raw)
In-Reply-To: <4CC085F5.9070905@gmail.com>
Jiri Slaby wrote:
> On 10/21/2010 10:05 AM, Takashi Iwai wrote:
> > commit de8c85f7840e5e29629de95f5af24297fb325e0b
> > ALSA: HDA: Sigmatel: work around incorrect master muting
>
> Reverting this one helps.
This one introduced even more wrong volume information on some codecs.
Pleasy try this patch on top:
--- a/sound/pci/hda/patch_sigmatel.c
+++ b/sound/pci/hda/patch_sigmatel.c
@@ -32,6 +32,7 @@
#include <sound/core.h>
#include <sound/asoundef.h>
#include <sound/jack.h>
+#include <sound/tlv.h>
#include "hda_codec.h"
#include "hda_local.h"
#include "hda_beep.h"
@@ -1145,7 +1146,7 @@ static int stac92xx_build_controls(struct hda_codec *codec)
/* correct volume offset */
vmaster_tlv[2] += vmaster_tlv[3] * spec->volume_offset;
/* minimum value is actually mute */
- vmaster_tlv[3] |= 0x1000;
+ vmaster_tlv[3] |= TLV_DB_SCALE_MUTE;
err = snd_hda_add_vmaster(codec, "Master Playback Volume",
vmaster_tlv, slave_vols);
if (err < 0)
WARNING: multiple messages have this Message-ID (diff)
From: Clemens Ladisch <clemens@ladisch.de>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, mm-commits@vger.kernel.org,
linux-kernel@vger.kernel.org, Valdis.Kletnieks@vt.edu,
akpm@linux-foundation.org
Subject: Re: [alsa-devel] HDA: no sound [was: mmotm 2010-10-20-15-01 uploaded]
Date: Fri, 22 Oct 2010 13:31:53 +0200 [thread overview]
Message-ID: <4CC17629.6050703@ladisch.de> (raw)
In-Reply-To: <4CC085F5.9070905@gmail.com>
Jiri Slaby wrote:
> On 10/21/2010 10:05 AM, Takashi Iwai wrote:
> > commit de8c85f7840e5e29629de95f5af24297fb325e0b
> > ALSA: HDA: Sigmatel: work around incorrect master muting
>
> Reverting this one helps.
This one introduced even more wrong volume information on some codecs.
Pleasy try this patch on top:
--- a/sound/pci/hda/patch_sigmatel.c
+++ b/sound/pci/hda/patch_sigmatel.c
@@ -32,6 +32,7 @@
#include <sound/core.h>
#include <sound/asoundef.h>
#include <sound/jack.h>
+#include <sound/tlv.h>
#include "hda_codec.h"
#include "hda_local.h"
#include "hda_beep.h"
@@ -1145,7 +1146,7 @@ static int stac92xx_build_controls(struct hda_codec *codec)
/* correct volume offset */
vmaster_tlv[2] += vmaster_tlv[3] * spec->volume_offset;
/* minimum value is actually mute */
- vmaster_tlv[3] |= 0x1000;
+ vmaster_tlv[3] |= TLV_DB_SCALE_MUTE;
err = snd_hda_add_vmaster(codec, "Master Playback Volume",
vmaster_tlv, slave_vols);
if (err < 0)
next prev parent reply other threads:[~2010-10-22 11:30 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 22:01 mmotm 2010-10-20-15-01 uploaded akpm
2010-10-21 2:54 ` Li Zefan
2010-10-21 3:15 ` Li Zefan
2010-10-21 3:38 ` Konrad Rzeszutek Wilk
2010-10-21 3:44 ` Li Zefan
2010-10-21 14:28 ` Konrad Rzeszutek Wilk
2010-10-21 3:46 ` Andrew Morton
2010-10-21 7:17 ` Peter Zijlstra
2010-10-21 7:30 ` Andrew Morton
2010-10-21 9:52 ` Peter Zijlstra
2010-10-21 9:54 ` Peter Zijlstra
2010-10-21 7:41 ` HDA: no sound [was: mmotm 2010-10-20-15-01 uploaded] Jiri Slaby
2010-10-21 7:41 ` Jiri Slaby
2010-10-21 7:49 ` Takashi Iwai
2010-10-21 7:49 ` Takashi Iwai
2010-10-21 7:57 ` Jiri Slaby
2010-10-21 7:57 ` Jiri Slaby
2010-10-21 8:05 ` Takashi Iwai
2010-10-21 8:05 ` Takashi Iwai
2010-10-21 18:27 ` Jiri Slaby
2010-10-21 18:27 ` Jiri Slaby
2010-10-21 19:20 ` Takashi Iwai
2010-10-21 19:20 ` Takashi Iwai
2010-10-21 19:21 ` Jiri Slaby
2010-10-21 19:21 ` Jiri Slaby
2010-10-21 19:22 ` Takashi Iwai
2010-10-21 19:22 ` Takashi Iwai
2010-10-21 19:40 ` Takashi Iwai
2010-10-21 19:40 ` Takashi Iwai
2010-10-21 20:29 ` Valdis.Kletnieks
2010-10-21 20:29 ` Valdis.Kletnieks
2010-10-21 20:48 ` Takashi Iwai
2010-10-21 20:48 ` Takashi Iwai
2010-10-21 21:24 ` Valdis.Kletnieks
2010-10-21 21:24 ` Valdis.Kletnieks
2010-10-21 21:31 ` Takashi Iwai
2010-10-21 21:31 ` Takashi Iwai
2010-10-21 21:42 ` Jiri Slaby
2010-10-21 21:42 ` Jiri Slaby
2010-10-22 8:46 ` Colin Guthrie
2010-10-22 9:02 ` Takashi Iwai
2010-10-22 9:02 ` Takashi Iwai
2010-10-22 9:18 ` Jiri Slaby
2010-10-22 9:18 ` Jiri Slaby
2010-10-22 9:40 ` Takashi Iwai
2010-10-22 9:40 ` Takashi Iwai
2010-10-22 9:45 ` Jiri Slaby
2010-10-22 9:45 ` Jiri Slaby
2010-10-22 10:26 ` Takashi Iwai
2010-10-22 10:26 ` Takashi Iwai
2010-10-22 11:10 ` Jiri Slaby
2010-10-22 11:10 ` Jiri Slaby
2010-10-22 9:41 ` Colin Guthrie
2010-10-22 11:31 ` Clemens Ladisch [this message]
2010-10-22 11:31 ` [alsa-devel] " Clemens Ladisch
2010-10-22 11:51 ` Jiri Slaby
2010-10-22 11:51 ` [alsa-devel] " Jiri Slaby
2010-10-22 14:03 ` Takashi Iwai
2010-10-22 14:03 ` [alsa-devel] " Takashi Iwai
2010-10-22 19:53 ` Colin Guthrie
2010-10-21 15:22 ` Valdis.Kletnieks
2010-10-21 15:22 ` Valdis.Kletnieks
2010-10-21 17:59 ` Jiri Slaby
2010-10-21 17:59 ` Jiri Slaby
2010-10-21 11:10 ` mmotm 2010-10-20-15-01 uploaded Zimny Lech
2010-10-21 11:14 ` mmotm 2010-10-20 - netfilter Kconfig whinge Valdis.Kletnieks
2010-10-29 19:11 ` Patrick McHardy
2010-10-21 17:51 ` DVB: af9015 defunct [was: mmotm 2010-10-20-15-01 uploaded] Jiri Slaby
2010-10-21 22:24 ` Jiri Slaby
2010-10-22 9:21 ` Jiri Slaby
2010-10-22 13:56 ` Mauro Carvalho Chehab
2010-10-22 14:06 ` Jiri Slaby
2010-10-27 16:12 ` Mauro Carvalho Chehab
2010-10-27 16:36 ` Jiri Slaby
2010-10-27 17:05 ` Mauro Carvalho Chehab
2010-10-27 16:41 ` Antti Palosaari
2010-10-27 17:11 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC17629.6050703@ladisch.de \
--to=clemens@ladisch.de \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.