All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Chemparathy <cyril@ti.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: "davinci-linux-open-source@linux.davincidsp.com"
	<davinci-linux-open-source@linux.davincidsp.com>,
	"dbrownell@users.sourceforge.net"
	<dbrownell@users.sourceforge.net>,
	sameo@linux.intel.com,
	"broonie@opensource.wolfsonmicro.com"
	<broonie@opensource.wolfsonmicro.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
	"rpurdie@rpsys.net" <rpurdie@rpsys.net>,
	"spi-devel-general@lists.sourceforge.net"
	<spi-devel-general@lists.sourceforge.net>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"lrg@slimlogic.co.uk" <lrg@slimlogic.co.uk>
Subject: Re: [PATCH v3 01/12] misc: add driver for sequencer serial port
Date: Fri, 22 Oct 2010 15:03:38 -0400	[thread overview]
Message-ID: <4CC1E00A.3010109@ti.com> (raw)
In-Reply-To: <20101022152024.65e8f181@lxorguk.ukuu.org.uk>

On 10/22/2010 10:20 AM, Alan Cox wrote:
> On Thu, 21 Oct 2010 17:01:02 -0400
> Cyril Chemparathy <cyril@ti.com> wrote:
> 
>> TI's sequencer serial port (TI-SSP) is a jack-of-all-trades type of serial port
>> device.  It has a built-in programmable execution engine that can be programmed
>> to operate as almost any serial bus (I2C, SPI, EasyScale, and others).
>>
>> This patch adds a driver for this controller device.  The driver does not
>> expose a user-land interface.  Protocol drivers built on top of this layer are
>> expected to remain in-kernel.
> 
> I suspect the driver belongs with the mfd drivers not with drivers/misc ?
> 
> otherwise it looks very nice.

Unlike MFDs, this device doesn't have cells with differing
functionality.  Instead it has functionally identical ports that can
operate in a variety of modes.  That said, does this still fit in with
other MFD drivers?  If so, I don't see a problem with moving it there.

Thanks
Cyril.

WARNING: multiple messages have this Message-ID (diff)
From: cyril@ti.com (Cyril Chemparathy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 01/12] misc: add driver for sequencer serial port
Date: Fri, 22 Oct 2010 15:03:38 -0400	[thread overview]
Message-ID: <4CC1E00A.3010109@ti.com> (raw)
In-Reply-To: <20101022152024.65e8f181@lxorguk.ukuu.org.uk>

On 10/22/2010 10:20 AM, Alan Cox wrote:
> On Thu, 21 Oct 2010 17:01:02 -0400
> Cyril Chemparathy <cyril@ti.com> wrote:
> 
>> TI's sequencer serial port (TI-SSP) is a jack-of-all-trades type of serial port
>> device.  It has a built-in programmable execution engine that can be programmed
>> to operate as almost any serial bus (I2C, SPI, EasyScale, and others).
>>
>> This patch adds a driver for this controller device.  The driver does not
>> expose a user-land interface.  Protocol drivers built on top of this layer are
>> expected to remain in-kernel.
> 
> I suspect the driver belongs with the mfd drivers not with drivers/misc ?
> 
> otherwise it looks very nice.

Unlike MFDs, this device doesn't have cells with differing
functionality.  Instead it has functionally identical ports that can
operate in a variety of modes.  That said, does this still fit in with
other MFD drivers?  If so, I don't see a problem with moving it there.

Thanks
Cyril.

WARNING: multiple messages have this Message-ID (diff)
From: Cyril Chemparathy <cyril@ti.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: "davinci-linux-open-source@linux.davincidsp.com" 
	<davinci-linux-open-source@linux.davincidsp.com>,
	"spi-devel-general@lists.sourceforge.net" 
	<spi-devel-general@lists.sourceforge.net>,
	"broonie@opensource.wolfsonmicro.com" 
	<broonie@opensource.wolfsonmicro.com>,
	"lrg@slimlogic.co.uk" <lrg@slimlogic.co.uk>,
	"dbrownell@users.sourceforge.net"
	<dbrownell@users.sourceforge.net>,
	"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"rpurdie@rpsys.net" <rpurdie@rpsys.net>,
	sameo@linux.intel.com
Subject: Re: [PATCH v3 01/12] misc: add driver for sequencer serial port
Date: Fri, 22 Oct 2010 15:03:38 -0400	[thread overview]
Message-ID: <4CC1E00A.3010109@ti.com> (raw)
In-Reply-To: <20101022152024.65e8f181@lxorguk.ukuu.org.uk>

On 10/22/2010 10:20 AM, Alan Cox wrote:
> On Thu, 21 Oct 2010 17:01:02 -0400
> Cyril Chemparathy <cyril@ti.com> wrote:
> 
>> TI's sequencer serial port (TI-SSP) is a jack-of-all-trades type of serial port
>> device.  It has a built-in programmable execution engine that can be programmed
>> to operate as almost any serial bus (I2C, SPI, EasyScale, and others).
>>
>> This patch adds a driver for this controller device.  The driver does not
>> expose a user-land interface.  Protocol drivers built on top of this layer are
>> expected to remain in-kernel.
> 
> I suspect the driver belongs with the mfd drivers not with drivers/misc ?
> 
> otherwise it looks very nice.

Unlike MFDs, this device doesn't have cells with differing
functionality.  Instead it has functionally identical ports that can
operate in a variety of modes.  That said, does this still fit in with
other MFD drivers?  If so, I don't see a problem with moving it there.

Thanks
Cyril.

  reply	other threads:[~2010-10-22 19:03 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-21 21:01 [PATCH v3 00/12] tnetv107x ssp driver stack Cyril Chemparathy
2010-10-21 21:01 ` Cyril Chemparathy
2010-10-21 21:01 ` Cyril Chemparathy
     [not found] ` <1287694873-12904-1-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
2010-10-21 21:01   ` [PATCH v3 01/12] misc: add driver for sequencer serial port Cyril Chemparathy
2010-10-21 21:01     ` Cyril Chemparathy
2010-10-21 21:01     ` Cyril Chemparathy
     [not found]     ` <1287694873-12904-2-git-send-email-cyril-l0cyMroinI0@public.gmane.org>
2010-10-21 23:12       ` Andrew Morton
2010-10-21 23:12         ` Andrew Morton
2010-10-21 23:12         ` Andrew Morton
     [not found]         ` <20101021161224.b4c0b623.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2010-10-22 12:39           ` Cyril Chemparathy
2010-10-22 12:39             ` Cyril Chemparathy
2010-10-22 12:39             ` Cyril Chemparathy
2010-10-22 12:48             ` Arnd Bergmann
2010-10-22 12:48               ` Arnd Bergmann
     [not found]               ` <201010221448.17728.arnd-r2nGTMty4D4@public.gmane.org>
2010-10-22 19:33                 ` Cyril Chemparathy
2010-10-22 19:33                   ` Cyril Chemparathy
2010-10-22 19:33                   ` Cyril Chemparathy
2010-10-22 22:46                   ` Russell King - ARM Linux
2010-10-22 22:46                     ` Russell King - ARM Linux
2010-10-22 14:20       ` Alan Cox
2010-10-22 14:20         ` Alan Cox
2010-10-22 14:20         ` Alan Cox
2010-10-22 19:03         ` Cyril Chemparathy [this message]
2010-10-22 19:03           ` Cyril Chemparathy
2010-10-22 19:03           ` Cyril Chemparathy
2010-10-21 21:01   ` [PATCH v3 02/12] davinci: add tnetv107x ssp platform device Cyril Chemparathy
2010-10-21 21:01     ` Cyril Chemparathy
2010-10-21 21:01     ` Cyril Chemparathy
2010-10-21 21:01   ` [PATCH v3 03/12] davinci: add ssp config for tnetv107x evm board Cyril Chemparathy
2010-10-21 21:01     ` Cyril Chemparathy
2010-10-21 21:01     ` Cyril Chemparathy
2010-10-21 21:01   ` [PATCH v3 04/12] spi: add ti-ssp spi master driver Cyril Chemparathy
2010-10-21 21:01     ` Cyril Chemparathy
2010-10-21 21:01     ` Cyril Chemparathy
2010-10-21 21:01   ` [PATCH v3 05/12] davinci: add spi devices on tnetv107x evm Cyril Chemparathy
2010-10-21 21:01     ` Cyril Chemparathy
2010-10-21 21:01     ` Cyril Chemparathy
2010-10-21 21:01   ` [PATCH v3 07/12] davinci: add tnetv107x evm regulators Cyril Chemparathy
2010-10-21 21:01     ` Cyril Chemparathy
2010-10-21 21:01     ` Cyril Chemparathy
2010-10-21 21:01   ` [PATCH v3 08/12] gpio: add ti-ssp virtual gpio driver Cyril Chemparathy
2010-10-21 21:01     ` Cyril Chemparathy
2010-10-21 21:01     ` Cyril Chemparathy
2010-10-21 21:01   ` [PATCH v3 09/12] davinci: add tnetv107x evm ti-ssp gpio device Cyril Chemparathy
2010-10-21 21:01     ` Cyril Chemparathy
2010-10-21 21:01     ` Cyril Chemparathy
2010-10-21 21:01   ` [PATCH v3 10/12] backlight: add support for tps6116x controller Cyril Chemparathy
2010-10-21 21:01     ` Cyril Chemparathy
2010-10-21 21:01     ` Cyril Chemparathy
2010-10-21 21:19     ` Joe Perches
2010-10-21 21:19       ` Joe Perches
2010-10-21 21:01   ` [PATCH v3 11/12] davinci: add tnetv107x evm backlight device Cyril Chemparathy
2010-10-21 21:01     ` Cyril Chemparathy
2010-10-21 21:01     ` Cyril Chemparathy
2010-10-21 21:01   ` [PATCH v3 12/12] davinci: add tnetv107x evm i2c eeprom device Cyril Chemparathy
2010-10-21 21:01     ` Cyril Chemparathy
2010-10-21 21:01     ` Cyril Chemparathy
2010-10-21 21:01 ` [PATCH v3 06/12] regulator: add driver for tps6524x regulator Cyril Chemparathy
2010-10-21 21:01   ` Cyril Chemparathy
2010-10-21 21:01   ` Cyril Chemparathy
2010-10-21 22:26 ` [PATCH v3 00/12] tnetv107x ssp driver stack Kevin Hilman
2010-10-21 22:26   ` Kevin Hilman
     [not found]   ` <87mxq7p4hv.fsf-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
2010-10-21 22:59     ` Andrew Morton
2010-10-21 22:59       ` Andrew Morton
2010-10-21 22:59       ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CC1E00A.3010109@ti.com \
    --to=cyril@ti.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=dbrownell@users.sourceforge.net \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    --cc=rpurdie@rpsys.net \
    --cc=sameo@linux.intel.com \
    --cc=spi-devel-general@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.