All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: mst@redhat.com, kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/2] msix: Pull in config.h for CONFIG_KVM
Date: Sat, 23 Oct 2010 09:41:44 +0200	[thread overview]
Message-ID: <4CC291B8.5030907@redhat.com> (raw)
In-Reply-To: <1287798606.5129.1.camel@x201>

On 10/23/2010 03:50 AM, Alex Williamson wrote:
> Oops, memory.c isn't upstream, I'll push it down in my patch queue and
> send a new one.

Neither is kvm_set_irq actually. :)  This patch is only needed for qemu-kvm.

BTW, maybe the better solution would be to move the kvm_*_irq* functions 
from qemu-kvm.c to kvm-all.c, add stubs to kvm-stub.c, and get rid of 
the #ifdef completely in msix.c

Paolo

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, mst@redhat.com
Subject: [Qemu-devel] Re: [PATCH 2/2] msix: Pull in config.h for CONFIG_KVM
Date: Sat, 23 Oct 2010 09:41:44 +0200	[thread overview]
Message-ID: <4CC291B8.5030907@redhat.com> (raw)
In-Reply-To: <1287798606.5129.1.camel@x201>

On 10/23/2010 03:50 AM, Alex Williamson wrote:
> Oops, memory.c isn't upstream, I'll push it down in my patch queue and
> send a new one.

Neither is kvm_set_irq actually. :)  This patch is only needed for qemu-kvm.

BTW, maybe the better solution would be to move the kvm_*_irq* functions 
from qemu-kvm.c to kvm-all.c, add stubs to kvm-stub.c, and get rid of 
the #ifdef completely in msix.c

Paolo

  reply	other threads:[~2010-10-23  7:41 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-22 20:31 [PATCH 0/2] msix: couple fixes Alex Williamson
2010-10-22 20:31 ` [Qemu-devel] " Alex Williamson
2010-10-22 20:40 ` [PATCH 1/2] msix: Allow msix_init on a device with existing MSI-X capability Alex Williamson
2010-10-22 20:40   ` [Qemu-devel] " Alex Williamson
2010-10-23 16:18   ` Michael S. Tsirkin
2010-10-23 16:18     ` [Qemu-devel] " Michael S. Tsirkin
2010-10-23 16:55     ` Alex Williamson
2010-10-23 16:55       ` [Qemu-devel] " Alex Williamson
2010-10-28 15:00       ` Avi Kivity
2010-10-28 15:00         ` [Qemu-devel] " Avi Kivity
2010-11-01 15:56         ` Alex Williamson
2010-11-01 15:56           ` [Qemu-devel] " Alex Williamson
2010-10-22 20:40 ` [PATCH 2/2] msix: Pull in config.h for CONFIG_KVM Alex Williamson
2010-10-22 20:40   ` [Qemu-devel] " Alex Williamson
2010-10-23  1:50   ` Alex Williamson
2010-10-23  1:50     ` [Qemu-devel] " Alex Williamson
2010-10-23  7:41     ` Paolo Bonzini [this message]
2010-10-23  7:41       ` Paolo Bonzini
2010-10-23 16:16   ` Michael S. Tsirkin
2010-10-23 16:16     ` [Qemu-devel] " Michael S. Tsirkin
2010-10-23 16:52     ` Alex Williamson
2010-10-23 16:52       ` [Qemu-devel] " Alex Williamson
2010-10-23 17:29       ` Michael S. Tsirkin
2010-10-23 17:29         ` [Qemu-devel] " Michael S. Tsirkin
2010-10-23 18:42         ` Alex Williamson
2010-10-23 18:42           ` [Qemu-devel] " Alex Williamson
2010-10-23 20:38           ` Michael S. Tsirkin
2010-10-23 20:38             ` [Qemu-devel] " Michael S. Tsirkin
2010-10-23 21:01             ` Alex Williamson
2010-10-23 21:01               ` [Qemu-devel] " Alex Williamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CC291B8.5030907@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.