All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] shadow: Switch to getting libtool from PATH
@ 2010-10-24 13:36 Eric Bénard
  2010-10-24 18:28 ` Khem Raj
  0 siblings, 1 reply; 4+ messages in thread
From: Eric Bénard @ 2010-10-24 13:36 UTC (permalink / raw)
  To: openembedded-devel; +Cc: Eric Bénard

* with PAM enabled, shadow's libtool sets lt_sysroot to the machine's
sysroot and not the arch's sysroot, thus it can't find libpam.
* by using libtool from PATH, this patch fix the problem.
* tested using angstrom-2010.x for an arvm5te target

Signed-off-by: Eric Bénard <eric@eukrea.com>
---
 recipes/shadow/shadow.inc |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/recipes/shadow/shadow.inc b/recipes/shadow/shadow.inc
index f1476b7..b8f1d2b 100644
--- a/recipes/shadow/shadow.inc
+++ b/recipes/shadow/shadow.inc
@@ -52,6 +52,9 @@ EXTRA_OECONF_libc-uclibc += "\
     ${@base_contains('DISTRO_FEATURES', 'pam', '--with-libpam', '--without-libpam', d)} \
 "
 
+LIBTOOL = "${HOST_SYS}-libtool"
+EXTRA_OEMAKE = "'LIBTOOL=${LIBTOOL}'"
+
 CFLAGS += "-I../include"
 
 PACKAGES =+ "${PN}-group"
-- 
1.6.3.3




^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] shadow: Switch to getting libtool from PATH
  2010-10-24 13:36 [PATCH] shadow: Switch to getting libtool from PATH Eric Bénard
@ 2010-10-24 18:28 ` Khem Raj
  2010-10-24 19:38   ` Eric Bénard
  0 siblings, 1 reply; 4+ messages in thread
From: Khem Raj @ 2010-10-24 18:28 UTC (permalink / raw)
  To: openembedded-devel; +Cc: Eric Bénard

2010/10/24 Eric Bénard <eric@eukrea.com>:
> * with PAM enabled, shadow's libtool sets lt_sysroot to the machine's
> sysroot and not the arch's sysroot, thus it can't find libpam.
> * by using libtool from PATH, this patch fix the problem.
> * tested using angstrom-2010.x for an arvm5te target
>
> Signed-off-by: Eric Bénard <eric@eukrea.com>

I have fixed it in autotools class. Basically it should have takes
care of setting
the sysroot correctly for arch and machine recipes equally. Should be fixed now
please pull and retest.

> ---
>  recipes/shadow/shadow.inc |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/recipes/shadow/shadow.inc b/recipes/shadow/shadow.inc
> index f1476b7..b8f1d2b 100644
> --- a/recipes/shadow/shadow.inc
> +++ b/recipes/shadow/shadow.inc
> @@ -52,6 +52,9 @@ EXTRA_OECONF_libc-uclibc += "\
>     ${@base_contains('DISTRO_FEATURES', 'pam', '--with-libpam', '--without-libpam', d)} \
>  "
>
> +LIBTOOL = "${HOST_SYS}-libtool"
> +EXTRA_OEMAKE = "'LIBTOOL=${LIBTOOL}'"
> +
>  CFLAGS += "-I../include"
>
>  PACKAGES =+ "${PN}-group"
> --
> 1.6.3.3
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] shadow: Switch to getting libtool from PATH
  2010-10-24 18:28 ` Khem Raj
@ 2010-10-24 19:38   ` Eric Bénard
  2010-10-24 19:46     ` Paul Menzel
  0 siblings, 1 reply; 4+ messages in thread
From: Eric Bénard @ 2010-10-24 19:38 UTC (permalink / raw)
  To: openembedded-devel

Hi Khem,

Le 24/10/2010 20:28, Khem Raj a écrit :
> 2010/10/24 Eric Bénard<eric@eukrea.com>:
>> * with PAM enabled, shadow's libtool sets lt_sysroot to the machine's
>> sysroot and not the arch's sysroot, thus it can't find libpam.
>> * by using libtool from PATH, this patch fix the problem.
>> * tested using angstrom-2010.x for an arvm5te target
>>
>> Signed-off-by: Eric Bénard<eric@eukrea.com>
>
> I have fixed it in autotools class. Basically it should have takes
> care of setting
> the sysroot correctly for arch and machine recipes equally. Should be fixed now
> please pull and retest.
>
you patch fixe the problem. Thanks

Eric



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] shadow: Switch to getting libtool from PATH
  2010-10-24 19:38   ` Eric Bénard
@ 2010-10-24 19:46     ` Paul Menzel
  0 siblings, 0 replies; 4+ messages in thread
From: Paul Menzel @ 2010-10-24 19:46 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 990 bytes --]

Dear Eric, dear Khem,


Am Sonntag, den 24.10.2010, 21:38 +0200 schrieb Eric Bénard:

> Le 24/10/2010 20:28, Khem Raj a écrit :
> > 2010/10/24 Eric Bénard<eric@eukrea.com>:
> >> * with PAM enabled, shadow's libtool sets lt_sysroot to the machine's
> >> sysroot and not the arch's sysroot, thus it can't find libpam.
> >> * by using libtool from PATH, this patch fix the problem.
> >> * tested using angstrom-2010.x for an arvm5te target
> >>
> >> Signed-off-by: Eric Bénard<eric@eukrea.com>
> >
> > I have fixed it in autotools class. Basically it should have takes
> > care of setting
> > the sysroot correctly for arch and machine recipes equally. Should be fixed now
> > please pull and retest.

That is commit 669ac1 [1].
>
> you patch fixe the problem. Thanks

For me too with `angstrom-2008.1` for `MACHINE="beagleboard"`!


Thanks,

Paul


[1] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=669ac121adeacd1850f67ab4aa758036f4599135

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-10-24 19:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-24 13:36 [PATCH] shadow: Switch to getting libtool from PATH Eric Bénard
2010-10-24 18:28 ` Khem Raj
2010-10-24 19:38   ` Eric Bénard
2010-10-24 19:46     ` Paul Menzel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.