Re: [Qemu-devel] Re: [PATCH 0/2] Type-safe ioport callbacks

[Anthony Liguori <anthony@codemonkey.ws>]

On 10/24/2010 12:38 PM, Avi Kivity wrote:
>  On 10/24/2010 07:35 PM, Paolo Bonzini wrote:
>> On 10/24/2010 05:34 PM, Avi Kivity wrote:
>>> A recent qemu ->  qemu-kvm merge broke cpu hotplug without the compiler
>>> complaining because of the type-unsafeness of the ioport callbacks.  
>>> This
>>> patchset adds a type-safe variant of ioport callbacks and coverts a 
>>> sample
>>> ioport.  Converting the other 300-odd registrations is left as an 
>>> excercise
>>> to the community.
>>
>> Should we create a Documentation/ file with incomplete transitions 
>> and the commit(s) that introduced them, for volunteers who wish to do 
>> some dirty work or to learn Coccinelle?
>
> If we have a TODO, we could add a janitor section there.

That's unnecessary work.  The vast majority of the callers of 
register_ioport* should be using a bus specific interface instead.

Regards,

Anthony Liguori