From: Avi Kivity <avi@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Anthony Liguori <anthony@codemonkey.ws>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH 1/2] Type-safe ioport callbacks
Date: Wed, 27 Oct 2010 11:26:26 +0200 [thread overview]
Message-ID: <4CC7F042.3040901@redhat.com> (raw)
In-Reply-To: <AANLkTi=NdsFQgn=TB7OJfhDdPegYP+TwKqd4+hFOywkb@mail.gmail.com>
On 10/26/2010 08:33 PM, Blue Swirl wrote:
> >
> > Why two types? I think some devices use PIO on a PC and MMIO on other
> > architectures. Sharing the type would allow sharing code.
>
> Then there are the functions provided by rwhandler.c. I think that
> interface makes even more sense compared to 8/16/32 (and 64?) bit
> handlers in many cases.
On the other hand, that makes the transition harder.
Perhaps we can have a type with {read,write}(addr, width), and another
built on top that provides the traditional {read,write}[bwl](addr) to
ease the transition.
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH 1/2] Type-safe ioport callbacks
Date: Wed, 27 Oct 2010 11:26:26 +0200 [thread overview]
Message-ID: <4CC7F042.3040901@redhat.com> (raw)
In-Reply-To: <AANLkTi=NdsFQgn=TB7OJfhDdPegYP+TwKqd4+hFOywkb@mail.gmail.com>
On 10/26/2010 08:33 PM, Blue Swirl wrote:
> >
> > Why two types? I think some devices use PIO on a PC and MMIO on other
> > architectures. Sharing the type would allow sharing code.
>
> Then there are the functions provided by rwhandler.c. I think that
> interface makes even more sense compared to 8/16/32 (and 64?) bit
> handlers in many cases.
On the other hand, that makes the transition harder.
Perhaps we can have a type with {read,write}(addr, width), and another
built on top that provides the traditional {read,write}[bwl](addr) to
ease the transition.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-10-27 9:26 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-24 15:34 [PATCH 0/2] Type-safe ioport callbacks Avi Kivity
2010-10-24 15:34 ` [Qemu-devel] " Avi Kivity
2010-10-24 15:34 ` [PATCH 1/2] " Avi Kivity
2010-10-24 15:34 ` [Qemu-devel] " Avi Kivity
2010-10-24 16:41 ` Avi Kivity
2010-10-24 16:41 ` [Qemu-devel] " Avi Kivity
2010-10-24 18:14 ` [Qemu-devel] " Blue Swirl
2010-10-24 18:14 ` Blue Swirl
2010-10-25 10:00 ` Avi Kivity
2010-10-25 10:00 ` Avi Kivity
2010-10-25 18:38 ` Blue Swirl
2010-10-25 18:38 ` Blue Swirl
2010-10-26 8:05 ` Avi Kivity
2010-10-26 8:05 ` Avi Kivity
2010-10-26 15:09 ` Blue Swirl
2010-10-26 15:09 ` Blue Swirl
2010-10-26 17:18 ` Avi Kivity
2010-10-26 17:18 ` Avi Kivity
2010-10-26 17:27 ` Anthony Liguori
2010-10-26 17:35 ` Avi Kivity
2010-10-26 18:33 ` Blue Swirl
2010-10-26 18:33 ` Blue Swirl
2010-10-27 9:26 ` Avi Kivity [this message]
2010-10-27 9:26 ` Avi Kivity
2010-10-27 20:23 ` Blue Swirl
2010-10-27 20:23 ` Blue Swirl
2010-10-25 12:54 ` Juan Quintela
2010-10-25 12:54 ` [Qemu-devel] " Juan Quintela
2010-10-25 12:56 ` Avi Kivity
2010-10-25 12:56 ` [Qemu-devel] " Avi Kivity
2010-10-24 15:34 ` [PATCH 2/2] piix4 acpi: convert io BAR to type-safe " Avi Kivity
2010-10-24 15:34 ` [Qemu-devel] " Avi Kivity
2010-10-24 17:35 ` [PATCH 0/2] Type-safe " Paolo Bonzini
2010-10-24 17:35 ` [Qemu-devel] " Paolo Bonzini
2010-10-24 17:38 ` Avi Kivity
2010-10-24 17:38 ` [Qemu-devel] " Avi Kivity
2010-10-25 13:46 ` Anthony Liguori
2010-10-25 13:52 ` Paolo Bonzini
2010-10-25 13:52 ` Paolo Bonzini
2010-10-25 14:04 ` Anthony Liguori
2010-10-25 14:04 ` Anthony Liguori
2010-10-25 13:45 ` [Qemu-devel] " Anthony Liguori
2010-10-25 13:45 ` Anthony Liguori
2010-10-25 15:40 ` Markus Armbruster
2010-10-25 15:40 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC7F042.3040901@redhat.com \
--to=avi@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=blauwirbel@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.