[PATCH] espgs_8.15.3.bb: Depend on cups as EXTRA_OECONF has --enable-cups.

[PATCH] espgs_8.15.3.bb: Depend on cups as EXTRA_OECONF has --enable-cups.

[Graham Gower]

pstoraster/gdevcups.c:74:25: fatal error: cups/raster.h: No such file or directory

Signed-off-by: Graham Gower <graham.gower@gmail.com>
---
 recipes/espgs/espgs_8.15.3.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/recipes/espgs/espgs_8.15.3.bb b/recipes/espgs/espgs_8.15.3.bb
index ba03f00..c2349e0 100644
--- a/recipes/espgs/espgs_8.15.3.bb
+++ b/recipes/espgs/espgs_8.15.3.bb
@@ -2,7 +2,7 @@ DESCRIPTION = "ESP Ghostscript is an up-to-date GNU Ghostscript distribution \
 including bug fixes, new drivers, and additional support for CUPS."
 HOMEPAGE = "http://www.cups.org/espgs/"
 SECTION = "libs"
-DEPENDS = "jpeg zlib libpng tiff fontconfig"
+DEPENDS = "jpeg zlib libpng tiff fontconfig cups"
 LICENSE = "GPL"
 PR = "r1"
 
-- 
1.7.1

Re: [PATCH] espgs_8.15.3.bb: Depend on cups as EXTRA_OECONF has --enable-cups.

[Frans Meulenbroeks]

2010/10/26 Graham Gower <graham.gower@gmail.com>:
>
> pstoraster/gdevcups.c:74:25: fatal error: cups/raster.h: No such file or directory
>
> Signed-off-by: Graham Gower <graham.gower@gmail.com>
> ---
>  recipes/espgs/espgs_8.15.3.bb |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/recipes/espgs/espgs_8.15.3.bb b/recipes/espgs/espgs_8.15.3.bb
> index ba03f00..c2349e0 100644
> --- a/recipes/espgs/espgs_8.15.3.bb
> +++ b/recipes/espgs/espgs_8.15.3.bb
> @@ -2,7 +2,7 @@ DESCRIPTION = "ESP Ghostscript is an up-to-date GNU Ghostscript distribution \
>  including bug fixes, new drivers, and additional support for CUPS."
>  HOMEPAGE = "http://www.cups.org/espgs/"
>  SECTION = "libs"
> -DEPENDS = "jpeg zlib libpng tiff fontconfig"
> +DEPENDS = "jpeg zlib libpng tiff fontconfig cups"
>  LICENSE = "GPL"
>  PR = "r1"
>
>

Three small remarks:
- not sure if changes like this require a PR bump. I always choose the
the safe way and bump when in doubt.
- it would be nice if, when you are fixing a recipe you would also
improve the LICENSE = "GPL" thing
- and there is also a 7.07.1 recipe. Should this apply to this version
as well (or alternately should we remove that recipe?)

Acked-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>

Re: [PATCH] espgs_8.15.3.bb: Depend on cups as EXTRA_OECONF has --enable-cups.

[Graham Gower]

On 26 October 2010 17:06, Frans Meulenbroeks
<fransmeulenbroeks@gmail.com> wrote:
> 2010/10/26 Graham Gower <graham.gower@gmail.com>:
>>
>> pstoraster/gdevcups.c:74:25: fatal error: cups/raster.h: No such file or directory
>>
>> Signed-off-by: Graham Gower <graham.gower@gmail.com>
>> ---
>>  recipes/espgs/espgs_8.15.3.bb |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/recipes/espgs/espgs_8.15.3.bb b/recipes/espgs/espgs_8.15.3.bb
>> index ba03f00..c2349e0 100644
>> --- a/recipes/espgs/espgs_8.15.3.bb
>> +++ b/recipes/espgs/espgs_8.15.3.bb
>> @@ -2,7 +2,7 @@ DESCRIPTION = "ESP Ghostscript is an up-to-date GNU Ghostscript distribution \
>>  including bug fixes, new drivers, and additional support for CUPS."
>>  HOMEPAGE = "http://www.cups.org/espgs/"
>>  SECTION = "libs"
>> -DEPENDS = "jpeg zlib libpng tiff fontconfig"
>> +DEPENDS = "jpeg zlib libpng tiff fontconfig cups"
>>  LICENSE = "GPL"
>>  PR = "r1"
>>
>>
>
> Three small remarks:
> - not sure if changes like this require a PR bump. I always choose the
> the safe way and bump when in doubt.
> - it would be nice if, when you are fixing a recipe you would also
> improve the LICENSE = "GPL" thing
> - and there is also a 7.07.1 recipe. Should this apply to this version
> as well (or alternately should we remove that recipe?)
>
> Acked-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>

I'll resubmit something when I get a chance.

-Graham

Re: [PATCH] espgs_8.15.3.bb: Depend on cups as EXTRA_OECONF has --enable-cups.

[Khem Raj]

On Mon, Oct 25, 2010 at 11:36 PM, Frans Meulenbroeks
<fransmeulenbroeks@gmail.com> wrote:
> 2010/10/26 Graham Gower <graham.gower@gmail.com>:
>>
>> pstoraster/gdevcups.c:74:25: fatal error: cups/raster.h: No such file or directory
>>
>> Signed-off-by: Graham Gower <graham.gower@gmail.com>
>> ---
>>  recipes/espgs/espgs_8.15.3.bb |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/recipes/espgs/espgs_8.15.3.bb b/recipes/espgs/espgs_8.15.3.bb
>> index ba03f00..c2349e0 100644
>> --- a/recipes/espgs/espgs_8.15.3.bb
>> +++ b/recipes/espgs/espgs_8.15.3.bb
>> @@ -2,7 +2,7 @@ DESCRIPTION = "ESP Ghostscript is an up-to-date GNU Ghostscript distribution \
>>  including bug fixes, new drivers, and additional support for CUPS."
>>  HOMEPAGE = "http://www.cups.org/espgs/"
>>  SECTION = "libs"
>> -DEPENDS = "jpeg zlib libpng tiff fontconfig"
>> +DEPENDS = "jpeg zlib libpng tiff fontconfig cups"
>>  LICENSE = "GPL"
>>  PR = "r1"
>>
>>
>
> Three small remarks:
> - not sure if changes like this require a PR bump. I always choose the
> the safe way and bump when in doubt.

Well if in doubt always read
http://wiki.openembedded.org/index.php/When_To_Bump_PR
and in this case a PR bump is not needed.

> - it would be nice if, when you are fixing a recipe you would also
> improve the LICENSE = "GPL" thing

yes.

> - and there is also a 7.07.1 recipe. Should this apply to this version
> as well (or alternately should we remove that recipe?)
>

probably remove the old recipe.

> Acked-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Re: [PATCH] espgs_8.15.3.bb: Depend on cups as EXTRA_OECONF has --enable-cups.

[Graham Gower]

On 27 October 2010 16:50, Khem Raj <raj.khem@gmail.com> wrote:
> On Mon, Oct 25, 2010 at 11:36 PM, Frans Meulenbroeks
> <fransmeulenbroeks@gmail.com> wrote:
>> 2010/10/26 Graham Gower <graham.gower@gmail.com>:
>>>
>>> pstoraster/gdevcups.c:74:25: fatal error: cups/raster.h: No such file or directory
>>>
>>> Signed-off-by: Graham Gower <graham.gower@gmail.com>
>>> ---
>>>  recipes/espgs/espgs_8.15.3.bb |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/recipes/espgs/espgs_8.15.3.bb b/recipes/espgs/espgs_8.15.3.bb
>>> index ba03f00..c2349e0 100644
>>> --- a/recipes/espgs/espgs_8.15.3.bb
>>> +++ b/recipes/espgs/espgs_8.15.3.bb
>>> @@ -2,7 +2,7 @@ DESCRIPTION = "ESP Ghostscript is an up-to-date GNU Ghostscript distribution \
>>>  including bug fixes, new drivers, and additional support for CUPS."
>>>  HOMEPAGE = "http://www.cups.org/espgs/"
>>>  SECTION = "libs"
>>> -DEPENDS = "jpeg zlib libpng tiff fontconfig"
>>> +DEPENDS = "jpeg zlib libpng tiff fontconfig cups"
>>>  LICENSE = "GPL"
>>>  PR = "r1"
>>>
>>>
>>
>> Three small remarks:
>> - not sure if changes like this require a PR bump. I always choose the
>> the safe way and bump when in doubt.
>
> Well if in doubt always read
> http://wiki.openembedded.org/index.php/When_To_Bump_PR
> and in this case a PR bump is not needed.
>
>> - it would be nice if, when you are fixing a recipe you would also
>> improve the LICENSE = "GPL" thing
>
> yes.
>
>> - and there is also a 7.07.1 recipe. Should this apply to this version
>> as well (or alternately should we remove that recipe?)
>>
>
> probably remove the old recipe.

Both espgs recipes can be moved to obsolete, as the project has been
merged into ghostscript 3 years ago. There are a couple of dependent
recipes to be moved to depend on gs instead. But I need to fix the gs
recipe to build for me before i can test them.

-Graham

Re: [PATCH] espgs_8.15.3.bb: Depend on cups as EXTRA_OECONF has --enable-cups.

[Khem Raj]

On Wed, Oct 27, 2010 at 2:40 AM, Graham Gower <graham.gower@gmail.com> wrote:
> On 27 October 2010 16:50, Khem Raj <raj.khem@gmail.com> wrote:
>> On Mon, Oct 25, 2010 at 11:36 PM, Frans Meulenbroeks
>> <fransmeulenbroeks@gmail.com> wrote:
>>> 2010/10/26 Graham Gower <graham.gower@gmail.com>:
>>>>
>>>> pstoraster/gdevcups.c:74:25: fatal error: cups/raster.h: No such file or directory
>>>>
>>>> Signed-off-by: Graham Gower <graham.gower@gmail.com>
>>>> ---
>>>>  recipes/espgs/espgs_8.15.3.bb |    2 +-
>>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/recipes/espgs/espgs_8.15.3.bb b/recipes/espgs/espgs_8.15.3.bb
>>>> index ba03f00..c2349e0 100644
>>>> --- a/recipes/espgs/espgs_8.15.3.bb
>>>> +++ b/recipes/espgs/espgs_8.15.3.bb
>>>> @@ -2,7 +2,7 @@ DESCRIPTION = "ESP Ghostscript is an up-to-date GNU Ghostscript distribution \
>>>>  including bug fixes, new drivers, and additional support for CUPS."
>>>>  HOMEPAGE = "http://www.cups.org/espgs/"
>>>>  SECTION = "libs"
>>>> -DEPENDS = "jpeg zlib libpng tiff fontconfig"
>>>> +DEPENDS = "jpeg zlib libpng tiff fontconfig cups"
>>>>  LICENSE = "GPL"
>>>>  PR = "r1"
>>>>
>>>>
>>>
>>> Three small remarks:
>>> - not sure if changes like this require a PR bump. I always choose the
>>> the safe way and bump when in doubt.
>>
>> Well if in doubt always read
>> http://wiki.openembedded.org/index.php/When_To_Bump_PR
>> and in this case a PR bump is not needed.
>>
>>> - it would be nice if, when you are fixing a recipe you would also
>>> improve the LICENSE = "GPL" thing
>>
>> yes.
>>
>>> - and there is also a 7.07.1 recipe. Should this apply to this version
>>> as well (or alternately should we remove that recipe?)
>>>
>>
>> probably remove the old recipe.
>
> Both espgs recipes can be moved to obsolete, as the project has been
> merged into ghostscript 3 years ago. There are a couple of dependent
> recipes to be moved to depend on gs instead. But I need to fix the gs
> recipe to build for me before i can test them.
>

good find fantastic.

> -Graham
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Re: [PATCH] espgs_8.15.3.bb: Depend on cups as EXTRA_OECONF has --enable-cups.

[Steve Sakoman]

On Wed, Oct 27, 2010 at 2:40 AM, Graham Gower <graham.gower@gmail.com> wrote:
> On 27 October 2010 16:50, Khem Raj <raj.khem@gmail.com> wrote:
>> On Mon, Oct 25, 2010 at 11:36 PM, Frans Meulenbroeks
>> <fransmeulenbroeks@gmail.com> wrote:
>>> 2010/10/26 Graham Gower <graham.gower@gmail.com>:
>>>>
>>>> pstoraster/gdevcups.c:74:25: fatal error: cups/raster.h: No such file or directory
>>>>
>>>> Signed-off-by: Graham Gower <graham.gower@gmail.com>
>>>> ---
>>>>  recipes/espgs/espgs_8.15.3.bb |    2 +-
>>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/recipes/espgs/espgs_8.15.3.bb b/recipes/espgs/espgs_8.15.3.bb
>>>> index ba03f00..c2349e0 100644
>>>> --- a/recipes/espgs/espgs_8.15.3.bb
>>>> +++ b/recipes/espgs/espgs_8.15.3.bb
>>>> @@ -2,7 +2,7 @@ DESCRIPTION = "ESP Ghostscript is an up-to-date GNU Ghostscript distribution \
>>>>  including bug fixes, new drivers, and additional support for CUPS."
>>>>  HOMEPAGE = "http://www.cups.org/espgs/"
>>>>  SECTION = "libs"
>>>> -DEPENDS = "jpeg zlib libpng tiff fontconfig"
>>>> +DEPENDS = "jpeg zlib libpng tiff fontconfig cups"
>>>>  LICENSE = "GPL"
>>>>  PR = "r1"
>>>>
>>>>
>>>
>>> Three small remarks:
>>> - not sure if changes like this require a PR bump. I always choose the
>>> the safe way and bump when in doubt.
>>
>> Well if in doubt always read
>> http://wiki.openembedded.org/index.php/When_To_Bump_PR
>> and in this case a PR bump is not needed.
>>
>>> - it would be nice if, when you are fixing a recipe you would also
>>> improve the LICENSE = "GPL" thing
>>
>> yes.
>>
>>> - and there is also a 7.07.1 recipe. Should this apply to this version
>>> as well (or alternately should we remove that recipe?)
>>>
>>
>> probably remove the old recipe.
>
> Both espgs recipes can be moved to obsolete, as the project has been
> merged into ghostscript 3 years ago. There are a couple of dependent
> recipes to be moved to depend on gs instead. But I need to fix the gs
> recipe to build for me before i can test them.

I've been working on this too.

The current state of the recipe is in my working branch (sakoman):

http://www.sakoman.com/cgi-bin/gitweb.cgi?p=openembedded.git;a=shortlog;h=refs/heads/sakoman

It builds, but there is some strangeness in generating the cups-gs and
cup-gs-dbg packages that I still haven't quite figured out.

Steve