* [Qemu-devel] Re: KVM call agenda for Oct 26
@ 2010-10-26 13:04 ` Avi Kivity
0 siblings, 0 replies; 22+ messages in thread
From: Avi Kivity @ 2010-10-26 13:04 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel, kvm-devel, Juan Quintela
On 10/26/2010 02:49 PM, Anthony Liguori wrote:
> On 10/26/2010 03:20 AM, Avi Kivity wrote:
>> On 10/25/2010 09:51 PM, Juan Quintela wrote:
>>> Please send in any agenda items you are interested in covering.
>>>
>>
>> 0.13.1
>>
>> At least two fatal issues:
>> - vmmouse is broken
>> - assertion failure in block layer
>
> There's actually a fair bit. I'm hoping to also get the hotplug fixes
> because tose are pretty important IMHO. I don't want to wait too long
> though.
Also, a new seabios for the SCI level triggered fix.
>
> What's the assertion in the block layer?
https://bugzilla.redhat.com/show_bug.cgi?id=646538
This is qemu-img, so maybe not so critical. I confused this with a
runtime assertion failure in the block layer, for which a fix was merged
post rc3.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: KVM call agenda for Oct 26
2010-10-26 13:04 ` [Qemu-devel] " Avi Kivity
@ 2010-10-26 13:22 ` Anthony Liguori
-1 siblings, 0 replies; 22+ messages in thread
From: Anthony Liguori @ 2010-10-26 13:22 UTC (permalink / raw)
To: Avi Kivity; +Cc: Juan Quintela, kvm-devel, qemu-devel
On 10/26/2010 08:04 AM, Avi Kivity wrote:
> On 10/26/2010 02:49 PM, Anthony Liguori wrote:
>> On 10/26/2010 03:20 AM, Avi Kivity wrote:
>>> On 10/25/2010 09:51 PM, Juan Quintela wrote:
>>>> Please send in any agenda items you are interested in covering.
>>>>
>>>
>>> 0.13.1
>>>
>>> At least two fatal issues:
>>> - vmmouse is broken
>>> - assertion failure in block layer
>>
>> There's actually a fair bit. I'm hoping to also get the hotplug
>> fixes because tose are pretty important IMHO. I don't want to wait
>> too long though.
>
> Also, a new seabios for the SCI level triggered fix.
You mean:
commit 6d5a2172f2b76900572107868ec080400c4f615d
Author: Kevin O'Connor <kevin@koconnor.net>
Date: Wed Oct 20 21:59:11 2010 -0400
mark irq9 active high in DSDT
In PIIX4 SCI (irq9) is active high. Seabios marks it so in interrupt
override table, but some OSes (FreeBSD) require the same information to
be present in DSDT too. Make it so.
Signed-off-by: Gleb Natapov <gleb@redhat.com>
If so, what's the impact of it not being there? I wanted to stick to
0.6.1 for stable-0.13, updating to a git snapshot is going to pull a lot
of things in that would be better to avoid for stable. We can talk to
Kevin about a stable branch but I'd like to understand what the real
impact here is first.
Regards,
Anthony Liguori
>>
>> What's the assertion in the block layer?
>
> https://bugzilla.redhat.com/show_bug.cgi?id=646538
>
> This is qemu-img, so maybe not so critical. I confused this with a
> runtime assertion failure in the block layer, for which a fix was
> merged post rc3.
>
^ permalink raw reply [flat|nested] 22+ messages in thread* [Qemu-devel] Re: KVM call agenda for Oct 26
@ 2010-10-26 13:22 ` Anthony Liguori
0 siblings, 0 replies; 22+ messages in thread
From: Anthony Liguori @ 2010-10-26 13:22 UTC (permalink / raw)
To: Avi Kivity; +Cc: qemu-devel, kvm-devel, Juan Quintela
On 10/26/2010 08:04 AM, Avi Kivity wrote:
> On 10/26/2010 02:49 PM, Anthony Liguori wrote:
>> On 10/26/2010 03:20 AM, Avi Kivity wrote:
>>> On 10/25/2010 09:51 PM, Juan Quintela wrote:
>>>> Please send in any agenda items you are interested in covering.
>>>>
>>>
>>> 0.13.1
>>>
>>> At least two fatal issues:
>>> - vmmouse is broken
>>> - assertion failure in block layer
>>
>> There's actually a fair bit. I'm hoping to also get the hotplug
>> fixes because tose are pretty important IMHO. I don't want to wait
>> too long though.
>
> Also, a new seabios for the SCI level triggered fix.
You mean:
commit 6d5a2172f2b76900572107868ec080400c4f615d
Author: Kevin O'Connor <kevin@koconnor.net>
Date: Wed Oct 20 21:59:11 2010 -0400
mark irq9 active high in DSDT
In PIIX4 SCI (irq9) is active high. Seabios marks it so in interrupt
override table, but some OSes (FreeBSD) require the same information to
be present in DSDT too. Make it so.
Signed-off-by: Gleb Natapov <gleb@redhat.com>
If so, what's the impact of it not being there? I wanted to stick to
0.6.1 for stable-0.13, updating to a git snapshot is going to pull a lot
of things in that would be better to avoid for stable. We can talk to
Kevin about a stable branch but I'd like to understand what the real
impact here is first.
Regards,
Anthony Liguori
>>
>> What's the assertion in the block layer?
>
> https://bugzilla.redhat.com/show_bug.cgi?id=646538
>
> This is qemu-img, so maybe not so critical. I confused this with a
> runtime assertion failure in the block layer, for which a fix was
> merged post rc3.
>
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: KVM call agenda for Oct 26
2010-10-26 13:22 ` [Qemu-devel] " Anthony Liguori
@ 2010-10-26 13:24 ` Gleb Natapov
-1 siblings, 0 replies; 22+ messages in thread
From: Gleb Natapov @ 2010-10-26 13:24 UTC (permalink / raw)
To: Anthony Liguori; +Cc: Avi Kivity, Juan Quintela, kvm-devel, qemu-devel
On Tue, Oct 26, 2010 at 08:22:38AM -0500, Anthony Liguori wrote:
> On 10/26/2010 08:04 AM, Avi Kivity wrote:
> > On 10/26/2010 02:49 PM, Anthony Liguori wrote:
> >>On 10/26/2010 03:20 AM, Avi Kivity wrote:
> >>> On 10/25/2010 09:51 PM, Juan Quintela wrote:
> >>>>Please send in any agenda items you are interested in covering.
> >>>>
> >>>
> >>>0.13.1
> >>>
> >>>At least two fatal issues:
> >>>- vmmouse is broken
> >>>- assertion failure in block layer
> >>
> >>There's actually a fair bit. I'm hoping to also get the hotplug
> >>fixes because tose are pretty important IMHO. I don't want to
> >>wait too long though.
> >
> >Also, a new seabios for the SCI level triggered fix.
>
> You mean:
>
> commit 6d5a2172f2b76900572107868ec080400c4f615d
> Author: Kevin O'Connor <kevin@koconnor.net>
> Date: Wed Oct 20 21:59:11 2010 -0400
>
> mark irq9 active high in DSDT
>
> In PIIX4 SCI (irq9) is active high. Seabios marks it so in interrupt
> override table, but some OSes (FreeBSD) require the same information to
> be present in DSDT too. Make it so.
>
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
>
> If so, what's the impact of it not being there? I wanted to stick
Power down from qemu monitor does not work for FreeBSD.
> to 0.6.1 for stable-0.13, updating to a git snapshot is going to
> pull a lot of things in that would be better to avoid for stable.
> We can talk to Kevin about a stable branch but I'd like to
> understand what the real impact here is first.
>
> Regards,
>
> Anthony Liguori
>
> >>
> >>What's the assertion in the block layer?
> >
> >https://bugzilla.redhat.com/show_bug.cgi?id=646538
> >
> >This is qemu-img, so maybe not so critical. I confused this with
> >a runtime assertion failure in the block layer, for which a fix
> >was merged post rc3.
> >
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Gleb.
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Qemu-devel] Re: KVM call agenda for Oct 26
@ 2010-10-26 13:24 ` Gleb Natapov
0 siblings, 0 replies; 22+ messages in thread
From: Gleb Natapov @ 2010-10-26 13:24 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel, Avi Kivity, kvm-devel, Juan Quintela
On Tue, Oct 26, 2010 at 08:22:38AM -0500, Anthony Liguori wrote:
> On 10/26/2010 08:04 AM, Avi Kivity wrote:
> > On 10/26/2010 02:49 PM, Anthony Liguori wrote:
> >>On 10/26/2010 03:20 AM, Avi Kivity wrote:
> >>> On 10/25/2010 09:51 PM, Juan Quintela wrote:
> >>>>Please send in any agenda items you are interested in covering.
> >>>>
> >>>
> >>>0.13.1
> >>>
> >>>At least two fatal issues:
> >>>- vmmouse is broken
> >>>- assertion failure in block layer
> >>
> >>There's actually a fair bit. I'm hoping to also get the hotplug
> >>fixes because tose are pretty important IMHO. I don't want to
> >>wait too long though.
> >
> >Also, a new seabios for the SCI level triggered fix.
>
> You mean:
>
> commit 6d5a2172f2b76900572107868ec080400c4f615d
> Author: Kevin O'Connor <kevin@koconnor.net>
> Date: Wed Oct 20 21:59:11 2010 -0400
>
> mark irq9 active high in DSDT
>
> In PIIX4 SCI (irq9) is active high. Seabios marks it so in interrupt
> override table, but some OSes (FreeBSD) require the same information to
> be present in DSDT too. Make it so.
>
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
>
> If so, what's the impact of it not being there? I wanted to stick
Power down from qemu monitor does not work for FreeBSD.
> to 0.6.1 for stable-0.13, updating to a git snapshot is going to
> pull a lot of things in that would be better to avoid for stable.
> We can talk to Kevin about a stable branch but I'd like to
> understand what the real impact here is first.
>
> Regards,
>
> Anthony Liguori
>
> >>
> >>What's the assertion in the block layer?
> >
> >https://bugzilla.redhat.com/show_bug.cgi?id=646538
> >
> >This is qemu-img, so maybe not so critical. I confused this with
> >a runtime assertion failure in the block layer, for which a fix
> >was merged post rc3.
> >
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Gleb.
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH] qcow2: Fix segfault when qcow2 preallocate fails
2010-10-26 13:04 ` [Qemu-devel] " Avi Kivity
@ 2010-10-26 13:23 ` Stefan Hajnoczi
-1 siblings, 0 replies; 22+ messages in thread
From: Stefan Hajnoczi @ 2010-10-26 13:23 UTC (permalink / raw)
To: Avi Kivity
Cc: qemu-devel, Anthony Liguori, Juan Quintela, kvm, Kevin Wolf,
Stefan Hajnoczi
When an image is created with -o preallocate, ensure that we only call
preallocate() if the image was indeed opened successfully. Also use
bdrv_delete() instead of bdrv_close() to avoid leaking the
BlockDriverState structure.
This fixes the segfault reported at
https://bugzilla.redhat.com/show_bug.cgi?id=646538.
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
Here's a fix for the segfault.
block/qcow2.c | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index ee3481b..0fceb0d 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -1059,9 +1059,11 @@ exit:
BlockDriverState *bs;
BlockDriver *drv = bdrv_find_format("qcow2");
bs = bdrv_new("");
- bdrv_open(bs, filename, BDRV_O_CACHE_WB | BDRV_O_RDWR, drv);
- ret = preallocate(bs);
- bdrv_close(bs);
+ ret = bdrv_open(bs, filename, BDRV_O_CACHE_WB | BDRV_O_RDWR, drv);
+ if (ret == 0) {
+ ret = preallocate(bs);
+ }
+ bdrv_delete(bs);
}
return ret;
--
1.7.1
^ permalink raw reply related [flat|nested] 22+ messages in thread* [Qemu-devel] [PATCH] qcow2: Fix segfault when qcow2 preallocate fails
@ 2010-10-26 13:23 ` Stefan Hajnoczi
0 siblings, 0 replies; 22+ messages in thread
From: Stefan Hajnoczi @ 2010-10-26 13:23 UTC (permalink / raw)
To: Avi Kivity
Cc: Kevin Wolf, Anthony Liguori, Stefan Hajnoczi, kvm, Juan Quintela,
qemu-devel
When an image is created with -o preallocate, ensure that we only call
preallocate() if the image was indeed opened successfully. Also use
bdrv_delete() instead of bdrv_close() to avoid leaking the
BlockDriverState structure.
This fixes the segfault reported at
https://bugzilla.redhat.com/show_bug.cgi?id=646538.
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
Here's a fix for the segfault.
block/qcow2.c | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index ee3481b..0fceb0d 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -1059,9 +1059,11 @@ exit:
BlockDriverState *bs;
BlockDriver *drv = bdrv_find_format("qcow2");
bs = bdrv_new("");
- bdrv_open(bs, filename, BDRV_O_CACHE_WB | BDRV_O_RDWR, drv);
- ret = preallocate(bs);
- bdrv_close(bs);
+ ret = bdrv_open(bs, filename, BDRV_O_CACHE_WB | BDRV_O_RDWR, drv);
+ if (ret == 0) {
+ ret = preallocate(bs);
+ }
+ bdrv_delete(bs);
}
return ret;
--
1.7.1
^ permalink raw reply related [flat|nested] 22+ messages in thread* Re: [PATCH] qcow2: Fix segfault when qcow2 preallocate fails
2010-10-26 13:23 ` [Qemu-devel] " Stefan Hajnoczi
@ 2010-10-26 13:48 ` Kevin Wolf
-1 siblings, 0 replies; 22+ messages in thread
From: Kevin Wolf @ 2010-10-26 13:48 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: Avi Kivity, qemu-devel, Anthony Liguori, Juan Quintela, kvm
Am 26.10.2010 15:23, schrieb Stefan Hajnoczi:
> When an image is created with -o preallocate, ensure that we only call
> preallocate() if the image was indeed opened successfully. Also use
> bdrv_delete() instead of bdrv_close() to avoid leaking the
> BlockDriverState structure.
>
> This fixes the segfault reported at
> https://bugzilla.redhat.com/show_bug.cgi?id=646538.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Looks good for stable-0.13. In master we'll have the new qcow_create2
implementation as soon as Anthony pulls, so it doesn't apply there.
Kevin
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Qemu-devel] Re: [PATCH] qcow2: Fix segfault when qcow2 preallocate fails
@ 2010-10-26 13:48 ` Kevin Wolf
0 siblings, 0 replies; 22+ messages in thread
From: Kevin Wolf @ 2010-10-26 13:48 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: Anthony Liguori, Juan Quintela, Avi Kivity, kvm, qemu-devel
Am 26.10.2010 15:23, schrieb Stefan Hajnoczi:
> When an image is created with -o preallocate, ensure that we only call
> preallocate() if the image was indeed opened successfully. Also use
> bdrv_delete() instead of bdrv_close() to avoid leaking the
> BlockDriverState structure.
>
> This fixes the segfault reported at
> https://bugzilla.redhat.com/show_bug.cgi?id=646538.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Looks good for stable-0.13. In master we'll have the new qcow_create2
implementation as soon as Anthony pulls, so it doesn't apply there.
Kevin
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH] qcow2: Fix segfault when qcow2 preallocate fails
2010-10-26 13:48 ` [Qemu-devel] " Kevin Wolf
@ 2010-10-26 14:04 ` Stefan Hajnoczi
-1 siblings, 0 replies; 22+ messages in thread
From: Stefan Hajnoczi @ 2010-10-26 14:04 UTC (permalink / raw)
To: Kevin Wolf
Cc: Stefan Hajnoczi, Avi Kivity, qemu-devel, Anthony Liguori,
Juan Quintela, kvm
On Tue, Oct 26, 2010 at 2:48 PM, Kevin Wolf <kwolf@redhat.com> wrote:
> Am 26.10.2010 15:23, schrieb Stefan Hajnoczi:
>> When an image is created with -o preallocate, ensure that we only call
>> preallocate() if the image was indeed opened successfully. Also use
>> bdrv_delete() instead of bdrv_close() to avoid leaking the
>> BlockDriverState structure.
>>
>> This fixes the segfault reported at
>> https://bugzilla.redhat.com/show_bug.cgi?id=646538.
>>
>> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
>
> Looks good for stable-0.13. In master we'll have the new qcow_create2
> implementation as soon as Anthony pulls, so it doesn't apply there.
I forgot about that :). Thanks Kevin.
Stefan
^ permalink raw reply [flat|nested] 22+ messages in thread
* [Qemu-devel] Re: [PATCH] qcow2: Fix segfault when qcow2 preallocate fails
@ 2010-10-26 14:04 ` Stefan Hajnoczi
0 siblings, 0 replies; 22+ messages in thread
From: Stefan Hajnoczi @ 2010-10-26 14:04 UTC (permalink / raw)
To: Kevin Wolf
Cc: Anthony Liguori, Stefan Hajnoczi, kvm, Juan Quintela, qemu-devel,
Avi Kivity
On Tue, Oct 26, 2010 at 2:48 PM, Kevin Wolf <kwolf@redhat.com> wrote:
> Am 26.10.2010 15:23, schrieb Stefan Hajnoczi:
>> When an image is created with -o preallocate, ensure that we only call
>> preallocate() if the image was indeed opened successfully. Also use
>> bdrv_delete() instead of bdrv_close() to avoid leaking the
>> BlockDriverState structure.
>>
>> This fixes the segfault reported at
>> https://bugzilla.redhat.com/show_bug.cgi?id=646538.
>>
>> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
>
> Looks good for stable-0.13. In master we'll have the new qcow_create2
> implementation as soon as Anthony pulls, so it doesn't apply there.
I forgot about that :). Thanks Kevin.
Stefan
^ permalink raw reply [flat|nested] 22+ messages in thread