From: Felix Fietkau <nbd@openwrt.org>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [RFC] ath9k: Insert wmb before linking dma descriptors
Date: Fri, 29 Oct 2010 01:45:42 +0200 [thread overview]
Message-ID: <4CCA0B26.5010008@openwrt.org> (raw)
In-Reply-To: <4CCA0908.6000105@candelatech.com>
On 2010-10-29 1:36 AM, Ben Greear wrote:
> On 10/09/2010 08:23 AM, Felix Fietkau wrote:
>> On 2010-10-09 5:19 PM, Bj?rn Smedman wrote:
>>> On Tue, Oct 5, 2010 at 9:50 PM, Luis R. Rodriguez
>>> <lrodriguez@atheros.com> wrote:
>>>> Felix is more familiar with this area so I'll let him chime with
>>>> his ACK/NACK.
>>>>
>>>> Luis
>>>
>>> So Felix, what do you think? I realize it may not be a common problem
>>> on any currently popular platform, but don't you agree it is in
>>> principle unsafe to write to the ds_link field of dma descriptors
>>> without a guarantee that those writes will be performed in the
>>> intended order?
>> Haven't had time to review this in detail yet. I'll take another look at
>> it later...
>
> Had a chance to look at it? I've been carrying this in my
> tree and it hasn't caused any obvious problems, for what that's
> worth...
Not sure if the patch helps with anything, but I think it can go in...
- Felix
WARNING: multiple messages have this Message-ID (diff)
From: Felix Fietkau <nbd@openwrt.org>
To: Ben Greear <greearb@candelatech.com>
Cc: "Björn Smedman" <bjorn.smedman@venatech.se>,
"John W. Linville" <linville@tuxdriver.com>,
"Luis R. Rodriguez" <lrodriguez@atheros.com>,
"ath9k-devel@venema.h4ckr.net" <ath9k-devel@venema.h4ckr.net>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [ath9k-devel] [RFC] ath9k: Insert wmb before linking dma descriptors
Date: Fri, 29 Oct 2010 01:45:42 +0200 [thread overview]
Message-ID: <4CCA0B26.5010008@openwrt.org> (raw)
In-Reply-To: <4CCA0908.6000105@candelatech.com>
On 2010-10-29 1:36 AM, Ben Greear wrote:
> On 10/09/2010 08:23 AM, Felix Fietkau wrote:
>> On 2010-10-09 5:19 PM, Björn Smedman wrote:
>>> On Tue, Oct 5, 2010 at 9:50 PM, Luis R. Rodriguez
>>> <lrodriguez@atheros.com> wrote:
>>>> Felix is more familiar with this area so I'll let him chime with
>>>> his ACK/NACK.
>>>>
>>>> Luis
>>>
>>> So Felix, what do you think? I realize it may not be a common problem
>>> on any currently popular platform, but don't you agree it is in
>>> principle unsafe to write to the ds_link field of dma descriptors
>>> without a guarantee that those writes will be performed in the
>>> intended order?
>> Haven't had time to review this in detail yet. I'll take another look at
>> it later...
>
> Had a chance to look at it? I've been carrying this in my
> tree and it hasn't caused any obvious problems, for what that's
> worth...
Not sure if the patch helps with anything, but I think it can go in...
- Felix
next prev parent reply other threads:[~2010-10-28 23:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-04 20:55 [ath9k-devel] [RFC] ath9k: Insert wmb before linking dma descriptors Björn Smedman
2010-10-04 20:55 ` Björn Smedman
2010-10-05 13:17 ` [ath9k-devel] " John W. Linville
2010-10-05 13:17 ` John W. Linville
2010-10-05 19:50 ` [ath9k-devel] " Luis R. Rodriguez
2010-10-05 19:50 ` Luis R. Rodriguez
2010-10-09 15:19 ` Björn Smedman
2010-10-09 15:19 ` Björn Smedman
2010-10-09 15:23 ` Felix Fietkau
2010-10-09 15:23 ` Felix Fietkau
2010-10-28 23:36 ` Ben Greear
2010-10-28 23:36 ` Ben Greear
2010-10-28 23:45 ` Felix Fietkau [this message]
2010-10-28 23:45 ` Felix Fietkau
2010-10-29 0:57 ` Luis R. Rodriguez
2010-10-29 0:57 ` Luis R. Rodriguez
2010-11-01 15:44 ` Björn Smedman
2010-11-01 15:44 ` Björn Smedman
2010-11-01 17:17 ` Bob Copeland
2010-11-01 17:17 ` Bob Copeland
2010-11-01 18:49 ` Björn Smedman
2010-11-01 18:49 ` Björn Smedman
2010-11-01 18:56 ` Bob Copeland
2010-11-01 18:56 ` Bob Copeland
2010-11-01 22:45 ` Peter Stuge
2010-11-01 22:45 ` Peter Stuge
2010-11-01 22:51 ` Ben Greear
2010-11-01 22:51 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CCA0B26.5010008@openwrt.org \
--to=nbd@openwrt.org \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.