Re: [Qemu-devel] [PATCH] virtio-9p: Check the return value of llistxattr.

["Venkateswararao Jujjuri (JV)" <jvrao@linux.vnet.ibm.com>]

On 10/29/2010 7:52 PM, Kusanagi Kouichi wrote:
> If llistxattr returned 0, qemu aborts.
> 
> Signed-off-by: Kusanagi Kouichi <slash@ac.auone-net.jp>

Acked-by: Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>

> ---
>  hw/virtio-9p-xattr.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/hw/virtio-9p-xattr.c b/hw/virtio-9p-xattr.c
> index 175f372..1aab081 100644
> --- a/hw/virtio-9p-xattr.c
> +++ b/hw/virtio-9p-xattr.c
> @@ -73,6 +73,9 @@ ssize_t v9fs_list_xattr(FsContext *ctx, const char *path,
> 
>      /* Get the actual len */
>      xattr_len = llistxattr(rpath(ctx, path), value, 0);
> +    if (xattr_len <= 0) {
> +        return xattr_len;
> +    }
> 
>      /* Now fetch the xattr and find the actual size */
>      orig_value = qemu_malloc(xattr_len);