* [Qemu-devel] [PATCH] virtio-9p: Check the return value of llistxattr.
@ 2010-10-30 2:52 Kusanagi Kouichi
2010-10-30 21:29 ` Venkateswararao Jujjuri (JV)
0 siblings, 1 reply; 2+ messages in thread
From: Kusanagi Kouichi @ 2010-10-30 2:52 UTC (permalink / raw)
To: qemu-devel
If llistxattr returned 0, qemu aborts.
Signed-off-by: Kusanagi Kouichi <slash@ac.auone-net.jp>
---
hw/virtio-9p-xattr.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-9p-xattr.c b/hw/virtio-9p-xattr.c
index 175f372..1aab081 100644
--- a/hw/virtio-9p-xattr.c
+++ b/hw/virtio-9p-xattr.c
@@ -73,6 +73,9 @@ ssize_t v9fs_list_xattr(FsContext *ctx, const char *path,
/* Get the actual len */
xattr_len = llistxattr(rpath(ctx, path), value, 0);
+ if (xattr_len <= 0) {
+ return xattr_len;
+ }
/* Now fetch the xattr and find the actual size */
orig_value = qemu_malloc(xattr_len);
--
1.7.2.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] virtio-9p: Check the return value of llistxattr.
2010-10-30 2:52 [Qemu-devel] [PATCH] virtio-9p: Check the return value of llistxattr Kusanagi Kouichi
@ 2010-10-30 21:29 ` Venkateswararao Jujjuri (JV)
0 siblings, 0 replies; 2+ messages in thread
From: Venkateswararao Jujjuri (JV) @ 2010-10-30 21:29 UTC (permalink / raw)
To: Kusanagi Kouichi; +Cc: qemu-devel
On 10/29/2010 7:52 PM, Kusanagi Kouichi wrote:
> If llistxattr returned 0, qemu aborts.
>
> Signed-off-by: Kusanagi Kouichi <slash@ac.auone-net.jp>
Acked-by: Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>
> ---
> hw/virtio-9p-xattr.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/hw/virtio-9p-xattr.c b/hw/virtio-9p-xattr.c
> index 175f372..1aab081 100644
> --- a/hw/virtio-9p-xattr.c
> +++ b/hw/virtio-9p-xattr.c
> @@ -73,6 +73,9 @@ ssize_t v9fs_list_xattr(FsContext *ctx, const char *path,
>
> /* Get the actual len */
> xattr_len = llistxattr(rpath(ctx, path), value, 0);
> + if (xattr_len <= 0) {
> + return xattr_len;
> + }
>
> /* Now fetch the xattr and find the actual size */
> orig_value = qemu_malloc(xattr_len);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-30 21:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-30 2:52 [Qemu-devel] [PATCH] virtio-9p: Check the return value of llistxattr Kusanagi Kouichi
2010-10-30 21:29 ` Venkateswararao Jujjuri (JV)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.