From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Ian Campbell <Ian.Campbell@eu.citrix.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
"Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Vasiliy G Tolstov <v.tolstov@selfip.ru>
Subject: Re: [GIT PULL] Small Xen bugfixes
Date: Sun, 31 Oct 2010 09:28:37 -0700 [thread overview]
Message-ID: <4CCD9935.50308@goop.org> (raw)
In-Reply-To: <1288516429.16032.13.camel@localhost.localdomain>
On 10/31/2010 02:13 AM, Ian Campbell wrote:
>> The 3rd is certainly simplest, at the cost of wasting a trivial amount
>> of memory.
> Doesn't Linux avoid using the lowest 1M anyway? (obviously apart from
> the start of day probing for firmware tables etc).
No, it tries to use most of it I think. It will tend to avoid the low
64k (maybe more) to avoid BIOS bugs.
>> Unfortunately it crashes early. Sigh, will try and sort it
>> out this afternoon.
> Strange!
I didn't get a chance to poke at it again, but in retrospect, I think
there are various "must succeed" allocations in low memory. We don't
need those allocations (things like AP boot trampoline, etc), but we
don't bother to stub them out or prevent them from happening. Reducing
the system to one with *no* allocatable memory below 1M is just too
strange, and would be a continuous source of problems in the future.
Of the other two options, I think your original approach is going to be
simplest. E820 gap filling wouldn't be too bad, but we'd end up having
to add a bit of gap-tracking logic to the E820 loop which isn't
currently there. Ignoring sub-1M gaps is simpler (and it needn't be
conditional on xen_initial_domain(), because we would never expect to
see anything strange sub-1M in a domU, and if there is, we should still
be careful of it in case something odd is going on).
J
WARNING: multiple messages have this Message-ID (diff)
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Ian Campbell <Ian.Campbell@eu.citrix.com>
Cc: "Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Vasiliy G Tolstov <v.tolstov@selfip.ru>
Subject: Re: [GIT PULL] Small Xen bugfixes
Date: Sun, 31 Oct 2010 09:28:37 -0700 [thread overview]
Message-ID: <4CCD9935.50308@goop.org> (raw)
In-Reply-To: <1288516429.16032.13.camel@localhost.localdomain>
On 10/31/2010 02:13 AM, Ian Campbell wrote:
>> The 3rd is certainly simplest, at the cost of wasting a trivial amount
>> of memory.
> Doesn't Linux avoid using the lowest 1M anyway? (obviously apart from
> the start of day probing for firmware tables etc).
No, it tries to use most of it I think. It will tend to avoid the low
64k (maybe more) to avoid BIOS bugs.
>> Unfortunately it crashes early. Sigh, will try and sort it
>> out this afternoon.
> Strange!
I didn't get a chance to poke at it again, but in retrospect, I think
there are various "must succeed" allocations in low memory. We don't
need those allocations (things like AP boot trampoline, etc), but we
don't bother to stub them out or prevent them from happening. Reducing
the system to one with *no* allocatable memory below 1M is just too
strange, and would be a continuous source of problems in the future.
Of the other two options, I think your original approach is going to be
simplest. E820 gap filling wouldn't be too bad, but we'd end up having
to add a bit of gap-tracking logic to the E820 loop which isn't
currently there. Ignoring sub-1M gaps is simpler (and it needn't be
conditional on xen_initial_domain(), because we would never expect to
see anything strange sub-1M in a domU, and if there is, we should still
be careful of it in case something odd is going on).
J
next prev parent reply other threads:[~2010-10-31 21:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-29 18:57 [GIT PULL] Small Xen bugfixes Jeremy Fitzhardinge
2010-10-29 18:57 ` Jeremy Fitzhardinge
2010-10-29 19:08 ` Linus Torvalds
2010-10-29 19:20 ` Jeremy Fitzhardinge
2010-10-29 19:20 ` Jeremy Fitzhardinge
2010-10-29 20:06 ` Jeremy Fitzhardinge
2010-10-31 9:13 ` Ian Campbell
2010-10-31 9:13 ` Ian Campbell
2010-10-31 16:28 ` Jeremy Fitzhardinge [this message]
2010-10-31 16:28 ` Jeremy Fitzhardinge
2010-11-01 16:36 ` Ian Campbell
2010-11-01 16:36 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CCD9935.50308@goop.org \
--to=jeremy@goop.org \
--cc=Ian.Campbell@eu.citrix.com \
--cc=Xen-devel@lists.xensource.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=v.tolstov@selfip.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.