All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saul Wold <saul.wold@intel.com>
To: Gary Thomas <gary@mlbassoc.com>
Cc: Poky <poky@lists.pokylinux.org>
Subject: Re: Inconsistent timestamp use
Date: Wed, 03 Nov 2010 15:34:40 -0700	[thread overview]
Message-ID: <4CD1E380.8080207@intel.com> (raw)
In-Reply-To: <4CD1839D.7070606@mlbassoc.com>

On 11/03/2010 08:45 AM, Gary Thomas wrote:
> On 11/03/2010 09:35 AM, Saul Wold wrote:
>> On 11/03/2010 06:58 AM, Gary Thomas wrote:
>>> The Poky root file system (init scripts) has a mechanism for
>>> supporting systems without a working hardware [time of day] clock.
>>> It seems that this has suffered some rot recently and is now
>>> quite inconsistent:
>>> * rootfs_update_timestamp() uses a different format for the time stamp
>>> * the init scripts look for /etc/timestamp2, not /etc/timestamp which
>>> is created with the image
>>>
>>> The attached patch makes this consistent and the system clock now works
>>> much better (about as good as a machine without a hardware clock can!)
>>>
>>
>> Hi Gary,
>>
>> This is a good change for the smaller images that use the busybox date
>> function, but will break images that use the real date command.
>> Unfortunately, they happen to use different formats for setting the time
>> and date.
>>
>> It may be that we need 2 timestamp files, one for a busybox system and a
>> second for the standard date command and then extend the check in the
>> init scripts to figure out which date we are using currently.
>
> Fair enough.  I was just trying to make what's there work consistently.
>
> Perhaps it's good enough to remove the "-s" option from the setting
> function and change back to the old format (+%m%d%H%M%Y).  I'm pretty
> sure that the full-on date program will handle that, as does busybox.
>
I just verified that the +%2m%2d%2H%2M%Y format will work correctly for 
both version of dates, and you are correct that the -s option should go 
away.

The save-rtc.sh script needs to be fixed to use the correct format.

I reponed bug #265 and commented that, if you want to add yourself to 
that bug.

Sau!


> Note: I think the change 41d02d40ed83c791e7a4c1d57d829d706af42e74 was
> actually incorrect.  The proper change would have been to fix the
> timestamp generation to be consistent.
>



      reply	other threads:[~2010-11-03 22:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-03 13:58 Inconsistent timestamp use Gary Thomas
2010-11-03 15:05 ` Mark Hatle
2010-11-03 15:35 ` Saul Wold
2010-11-03 15:45   ` Gary Thomas
2010-11-03 22:34     ` Saul Wold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CD1E380.8080207@intel.com \
    --to=saul.wold@intel.com \
    --cc=gary@mlbassoc.com \
    --cc=poky@lists.pokylinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.