[Qemu-devel] Re: [RFC][RESEND][PATCH v1 05/15] virtproxy: add accept handler for communication channel

[Michael Roth <mdroth@linux.vnet.ibm.com>]

On 11/03/2010 06:02 PM, Adam Litke wrote:
> On Wed, 2010-11-03 at 10:28 -0500, Michael Roth wrote:
>> This accept()'s connections to the socket we told virt-proxy to listen
>> for the channel connection on and sets the appropriate read handler for
>> the resulting FD.
>>
>> Signed-off-by: Michael Roth<mdroth@linux.vnet.ibm.com>
>> ---
>>   virtproxy.c |   37 +++++++++++++++++++++++++++++++++++++
>>   1 files changed, 37 insertions(+), 0 deletions(-)
>>
>> diff --git a/virtproxy.c b/virtproxy.c
>> index fa17722..20532c2 100644
>> --- a/virtproxy.c
>> +++ b/virtproxy.c
>> @@ -166,6 +166,8 @@ static VPConn *get_conn(const VPDriver *drv, int fd, bool client)
>>       return NULL;
>>   }
>>
>> +static void vp_channel_accept(void *opaque);
>> +
>
> Why the forward declaration?  Can you move the function to a different
> place in the file to avoid this?
>
>

For this particular one vp_channel_accept and vp_channel_read reference 
each other at least this one needed a forward declaration. I'll see what 
I can do about these...I'm hesitant to add yet another header file but 
if that's preferred way I can move all the declarations into a 
virtproxy-internal.h file as you suggested.