From: Stephen Boyd <sboyd@codeaurora.org>
To: Daniel Walker <dwalker@codeaurora.org>
Cc: Russell King <linux@arm.linux.org.uk>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Saravana Kannan <skannan@codeaurora.org>,
Colin Cross <ccross@android.com>,
Kevin Hilman <khilman@deeprootsystems.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Nicolas Pitre <nico@fluxnic.net>
Subject: Re: [PATCHv2 2/3] ARM: Allow machines to override __delay()
Date: Thu, 04 Nov 2010 13:58:15 -0700 [thread overview]
Message-ID: <4CD31E67.60107@codeaurora.org> (raw)
In-Reply-To: <1288899002.21823.3.camel@c-dwalke-linux.qualcomm.com>
On 11/04/2010 12:30 PM, Daniel Walker wrote:
> On Thu, 2010-10-28 at 14:19 -0700, Stephen Boyd wrote:
>> +
>> +static void (*delay_fn)(unsigned long) = delay_loop;
>> +
>> +void set_delay_fn(void (*fn)(unsigned long))
>> +{
>> + delay_fn = fn;
>> +}
>
> This needs to be a static inline in the header file.
Wouldn't that mean delay_fn needs to be exposed in the header file too?
I like the fact that it's static and scoped to this file.
>> +/*
>> + * loops = usecs * HZ * loops_per_jiffy / 1000000
>> + */
>> +void __delay(unsigned long loops)
>> +{
>> + delay_fn(loops);
>> +}
>> EXPORT_SYMBOL(__delay);
>
> Can we make this static inline also? I'm sure about the module issues..
Do you mean in the header file or in this file?
I think it won't work because there actually needs to be a __delay
symbol and it can't just be inlined away at all the call sites.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 2/3] ARM: Allow machines to override __delay()
Date: Thu, 04 Nov 2010 13:58:15 -0700 [thread overview]
Message-ID: <4CD31E67.60107@codeaurora.org> (raw)
In-Reply-To: <1288899002.21823.3.camel@c-dwalke-linux.qualcomm.com>
On 11/04/2010 12:30 PM, Daniel Walker wrote:
> On Thu, 2010-10-28 at 14:19 -0700, Stephen Boyd wrote:
>> +
>> +static void (*delay_fn)(unsigned long) = delay_loop;
>> +
>> +void set_delay_fn(void (*fn)(unsigned long))
>> +{
>> + delay_fn = fn;
>> +}
>
> This needs to be a static inline in the header file.
Wouldn't that mean delay_fn needs to be exposed in the header file too?
I like the fact that it's static and scoped to this file.
>> +/*
>> + * loops = usecs * HZ * loops_per_jiffy / 1000000
>> + */
>> +void __delay(unsigned long loops)
>> +{
>> + delay_fn(loops);
>> +}
>> EXPORT_SYMBOL(__delay);
>
> Can we make this static inline also? I'm sure about the module issues..
Do you mean in the header file or in this file?
I think it won't work because there actually needs to be a __delay
symbol and it can't just be inlined away at all the call sites.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2010-11-04 20:58 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 21:19 [PATCHv2 0/3] ARM: Fixing udelay() for SMP and non-SMP systems Stephen Boyd
2010-10-28 21:19 ` Stephen Boyd
2010-10-28 21:19 ` [PATCHv2 1/3] ARM: Translate delay.S into (mostly) C Stephen Boyd
2010-10-28 21:19 ` Stephen Boyd
2010-11-03 17:57 ` Daniel Walker
2010-11-03 17:57 ` Daniel Walker
2010-11-04 2:40 ` Nicolas Pitre
2010-11-04 2:40 ` Nicolas Pitre
2010-11-03 18:27 ` Will Deacon
2010-11-03 18:27 ` Will Deacon
2010-11-03 23:15 ` Stephen Boyd
2010-11-03 23:15 ` Stephen Boyd
2010-11-03 23:17 ` Daniel Walker
2010-11-03 23:17 ` Daniel Walker
2010-10-28 21:19 ` [PATCHv2 2/3] ARM: Allow machines to override __delay() Stephen Boyd
2010-10-28 21:19 ` Stephen Boyd
2010-11-04 19:30 ` Daniel Walker
2010-11-04 19:30 ` Daniel Walker
2010-11-04 20:58 ` Stephen Boyd [this message]
2010-11-04 20:58 ` Stephen Boyd
2010-11-04 21:16 ` Daniel Walker
2010-11-04 21:16 ` Daniel Walker
2010-11-05 21:51 ` Stephen Boyd
2010-11-05 21:51 ` Stephen Boyd
2010-11-05 23:43 ` Daniel Walker
2010-11-05 23:43 ` Daniel Walker
2010-11-06 3:36 ` Stephen Boyd
2010-11-06 3:36 ` Stephen Boyd
2010-11-08 18:11 ` Daniel Walker
2010-11-08 18:11 ` Daniel Walker
2010-10-28 21:19 ` [PATCHv2 3/3] ARM: Implement a timer based __delay() loop Stephen Boyd
2010-10-28 21:19 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD31E67.60107@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=ccross@android.com \
--cc=dwalker@codeaurora.org \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nico@fluxnic.net \
--cc=santosh.shilimkar@ti.com \
--cc=skannan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.