hwmon directory structure bug

hwmon directory structure bug

[Delan Azabani]

The sensors implementation of nouveau has a bug where the name file is
not in hwmonX/device, but in the root of the hwmonX directory. Normally,
the name file (contains driver name) of a sensor is placed:

/sys/class/hwmon/hwmon<int>/device/name

This holds true for coretemp, it8718 and all other sensors I've
encountered. Currently, with the latest nouveau from git, the name file
is placed as

/sys/class/hwmon/hwmon<int>/name

This is incorrect and goes against the convention for hwmon directory
structure. Not a major bug, but a fix would be very helpful.

Re: hwmon directory structure bug

[Martin Peres]

Le 06/11/2010 01:34, Delan Azabani a écrit :
> The sensors implementation of nouveau has a bug where the name file is
> not in hwmonX/device, but in the root of the hwmonX directory. Normally,
> the name file (contains driver name) of a sensor is placed:
>
> /sys/class/hwmon/hwmon<int>/device/name
>
> This holds true for coretemp, it8718 and all other sensors I've
> encountered. Currently, with the latest nouveau from git, the name file
> is placed as
>
> /sys/class/hwmon/hwmon<int>/name
>
> This is incorrect and goes against the convention for hwmon directory
> structure. Not a major bug, but a fix would be very helpful.
oh, thanks for spotting this, I'll correct my mistake tomorrow.

Regards,

Martin

Re: hwmon directory structure bug

[Delan Azabani]

On 06/11/10 10:32, Martin Peres wrote:
> Le 06/11/2010 01:34, Delan Azabani a écrit :
>> The sensors implementation of nouveau has a bug where the name file is
>> not in hwmonX/device, but in the root of the hwmonX directory. Normally,
>> the name file (contains driver name) of a sensor is placed:
>>
>> /sys/class/hwmon/hwmon<int>/device/name
>>
>> This holds true for coretemp, it8718 and all other sensors I've
>> encountered. Currently, with the latest nouveau from git, the name file
>> is placed as
>>
>> /sys/class/hwmon/hwmon<int>/name
>>
>> This is incorrect and goes against the convention for hwmon directory
>> structure. Not a major bug, but a fix would be very helpful.
> oh, thanks for spotting this, I'll correct my mistake tomorrow.
> 
> Regards,
> 
> Martin
> _______________________________________________
> Nouveau mailing list
> Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
> http://lists.freedesktop.org/mailman/listinfo/nouveau

No problem, happy to help.

Thanks and best regards,
Delan Azabani