From: Zan Lynx <zlynx@acm.org>
To: Rik van Riel <riel@redhat.com>
Cc: Jeff Layton <jlayton@redhat.com>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
esandeen@redhat.com, jmoyer@redhat.com,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] clear PageError bit in msync & fsync
Date: Tue, 09 Nov 2010 14:21:31 -0700 [thread overview]
Message-ID: <4CD9BB5B.2090206@acm.org> (raw)
In-Reply-To: <4CD9A209.6070807@redhat.com>
On 11/9/10 12:33 PM, Rik van Riel wrote:
> On 11/09/2010 02:21 PM, Jeff Layton wrote:
>
>> This does leave the page in sort of a funky state. The uptodate bit
>> will still probably be set, but the dirty bit won't be. The page will
>> be effectively "disconnected" from the backing store until someone
>> writes to it.
>>
>> I suppose though that this is the best that can reasonably be done in
>> this situation however...
>
> I spent a few days looking for alternatives, and indeed I found
> nothing better...
Just an off the top of my head crazy idea...
Could you leave the error bit set on the page and treat it as a dirty
bit during a future msync, clearing the error bit at that point.
The general idea would be to leave the error set unless an explicit
write was requested.
--
Zan Lynx
zlynx@acm.org
"Knowledge is Power. Power Corrupts. Study Hard. Be Evil."
next prev parent reply other threads:[~2010-11-09 21:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 16:44 [PATCH] clear PageError bit in msync & fsync Rik van Riel
2010-11-09 18:09 ` Valerie Aurora
2010-11-09 19:21 ` Jeff Layton
2010-11-09 19:33 ` Rik van Riel
2010-11-09 21:07 ` Ted Ts'o
2010-11-09 21:15 ` Rik van Riel
2010-11-09 21:41 ` Andrew Morton
2010-11-12 4:36 ` Rik van Riel
2010-11-12 15:52 ` Jeff Layton
2010-11-12 17:04 ` Rik van Riel
2010-11-09 21:44 ` Jan Kara
2010-11-11 16:31 ` Rik van Riel
2010-11-09 21:21 ` Zan Lynx [this message]
2010-11-09 21:24 ` Rik van Riel
2010-11-12 20:51 ` Eric Sandeen
2010-11-12 21:36 ` Jeff Layton
2010-11-09 21:39 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD9BB5B.2090206@acm.org \
--to=zlynx@acm.org \
--cc=akpm@linux-foundation.org \
--cc=esandeen@redhat.com \
--cc=jlayton@redhat.com \
--cc=jmoyer@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.