* [PATCH] TODO: Add owner to extend the voicecall interface with a property indicating emergency call
@ 2010-11-10 12:25 John Mathew
2010-11-10 14:33 ` Denis Kenzior
0 siblings, 1 reply; 5+ messages in thread
From: John Mathew @ 2010-11-10 12:25 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 341 bytes --]
---
TODO | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/TODO b/TODO
index 84d5aa7..ed37c58 100644
--- a/TODO
+++ b/TODO
@@ -416,7 +416,7 @@ Emergency Calls
Priority: High
Complexity: C1
-
+ Owner: John Mathew <john.mathew@elektrobit.com>
Miscellaneous
=============
--
1.7.0.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] TODO: Add owner to extend the voicecall interface with a property indicating emergency call
2010-11-10 12:25 [PATCH] TODO: Add owner to extend the voicecall interface with a property indicating emergency call John Mathew
@ 2010-11-10 14:33 ` Denis Kenzior
2010-11-10 16:09 ` John Mathew
0 siblings, 1 reply; 5+ messages in thread
From: Denis Kenzior @ 2010-11-10 14:33 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]
Hi John,
On 11/10/2010 06:25 AM, John Mathew wrote:
> ---
> TODO | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/TODO b/TODO
> index 84d5aa7..ed37c58 100644
> --- a/TODO
> +++ b/TODO
> @@ -416,7 +416,7 @@ Emergency Calls
>
> Priority: High
> Complexity: C1
> -
> + Owner: John Mathew <john.mathew@elektrobit.com>
>
> Miscellaneous
> =============
We have pretty strict git apply settings in effect, so your patch does
not apply:
Applying: TODO: Add owner to extend the voicecall interface with a
property indicating emergency call
/home/denkenz/ofono-master/.git/rebase-apply/patch:14: trailing whitespace.
Owner: John Mathew <john.mathew@elektrobit.com>
fatal: 1 line adds whitespace errors.
Patch failed at 0001 TODO: Add owner to extend the voicecall interface
with a property indicating emergency call
Also, please keep your commit header under 50 characters. And yes, I
know the task description is rather 'long' in this case ;) So sometimes
we have to be a bit 'creative'. Something like:
"TODO: Assign Voicecall emergency property task"
would work in this case.
Regards,
-Denis
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-11-10 16:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-10 12:25 [PATCH] TODO: Add owner to extend the voicecall interface with a property indicating emergency call John Mathew
2010-11-10 14:33 ` Denis Kenzior
2010-11-10 16:09 ` John Mathew
2010-11-10 16:09 ` [PATCH] TODO: Assign Voicecall emergency property task John Mathew
2010-11-10 16:13 ` Denis Kenzior
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.