All of lore.kernel.org
 help / color / mirror / Atom feed
From: Henrik Rydberg <rydberg@euromail.se>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: Jean Delvare <khali@linux-fr.org>,
	lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH v4] hwmon: (applesmc) Introduce a register
Date: Wed, 10 Nov 2010 22:48:40 +0000	[thread overview]
Message-ID: <4CDB2148.8080404@euromail.se> (raw)
In-Reply-To: <1289429274-30289-1-git-send-email-guenter.roeck@ericsson.com>

On 11/10/2010 11:47 PM, Guenter Roeck wrote:

> From: Henrik Rydberg <rydberg@euromail.se>
> 
> One main problem with the current driver is the inability to quickly
> search for supported keys, resulting in detailed feature maps per
> machine model which are cumbersome to maintain.
> 
> This patch adds a register lookup table, which enables binary search
> for supported keys. The lookup also reduces the io frequency, so the
> original mutex is replaced by locks around the actual io.
> 
> Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
> [guenter.roeck@ericsson.com: Added value range check to key_at_index_store()]
> Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> ---
> Patch as applied, with added value range check to applesmc_key_at_index_store().


Works nicely, much obliged. It's a wrap. :-)

Thanks,
Henrik

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Henrik Rydberg <rydberg@euromail.se>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: Jean Delvare <khali@linux-fr.org>,
	lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] hwmon: (applesmc) Introduce a register lookup table
Date: Wed, 10 Nov 2010 23:48:40 +0100	[thread overview]
Message-ID: <4CDB2148.8080404@euromail.se> (raw)
In-Reply-To: <1289429274-30289-1-git-send-email-guenter.roeck@ericsson.com>

On 11/10/2010 11:47 PM, Guenter Roeck wrote:

> From: Henrik Rydberg <rydberg@euromail.se>
> 
> One main problem with the current driver is the inability to quickly
> search for supported keys, resulting in detailed feature maps per
> machine model which are cumbersome to maintain.
> 
> This patch adds a register lookup table, which enables binary search
> for supported keys. The lookup also reduces the io frequency, so the
> original mutex is replaced by locks around the actual io.
> 
> Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
> [guenter.roeck@ericsson.com: Added value range check to key_at_index_store()]
> Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> ---
> Patch as applied, with added value range check to applesmc_key_at_index_store().


Works nicely, much obliged. It's a wrap. :-)

Thanks,
Henrik

  reply	other threads:[~2010-11-10 22:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-10 22:47 [lm-sensors] [PATCH v4] hwmon: (applesmc) Introduce a register Guenter Roeck
2010-11-10 22:47 ` [PATCH v4] hwmon: (applesmc) Introduce a register lookup table Guenter Roeck
2010-11-10 22:48 ` Henrik Rydberg [this message]
2010-11-10 22:48   ` Henrik Rydberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CDB2148.8080404@euromail.se \
    --to=rydberg@euromail.se \
    --cc=guenter.roeck@ericsson.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.