All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Nigel Horne <njh@bandsman.co.uk>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] scsi-disk: Move active request asserts
Date: Fri, 12 Nov 2010 11:13:23 +0100	[thread overview]
Message-ID: <4CDD1343.7090708@redhat.com> (raw)
In-Reply-To: <1289555831-22844-1-git-send-email-stefanha@linux.vnet.ibm.com>

Am 12.11.2010 10:57, schrieb Stefan Hajnoczi:
> SCSI read/write requests should not be re-issued before the current
> fragment of I/O completes.  There are asserts in scsi-disk.c that guard
> this constraint but they trigger on SPARC Linux 2.4.  It turns out that
> the asserts are too early in the code path and don't allow for read
> requests to terminate.
> 
> Only the read assert needs to be moved but move the write assert too for
> consistency.
> 
> Reported-by: Nigel Horne <njh@bandsman.co.uk>
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

Thanks, applied to the block branch.

Kevin

      reply	other threads:[~2010-11-12 10:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-12  9:57 [Qemu-devel] [PATCH] scsi-disk: Move active request asserts Stefan Hajnoczi
2010-11-12 10:13 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CDD1343.7090708@redhat.com \
    --to=kwolf@redhat.com \
    --cc=njh@bandsman.co.uk \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.