From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: Anthony.Perard@citrix.com,
Xen Devel <xen-devel@lists.xensource.com>,
QEMU-devel Developers <qemu-devel@nongnu.org>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [Qemu-devel] [PATCH V6 04/15] Introduce -accel command option.
Date: Mon, 15 Nov 2010 13:56:31 +0100 [thread overview]
Message-ID: <4CE12DFF.8050109@redhat.com> (raw)
In-Reply-To: <C0AD410B-E24A-43B5-93A9-6B41D4CEEC93@suse.de>
On 11/15/2010 11:46 AM, Alexander Graf wrote:
> I take back my Acked-by. Sorry, I guess I should have read things in
> more detail first O_o. I still believe that this patch can go in
> before the others, but I'd at least like to see some comments on the
> (0) pointer thing:).
I agree, it kind of works by chance, (0) works but (1) wouldn't. Better
to define the function always.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: Anthony.Perard@citrix.com,
Xen Devel <xen-devel@lists.xensource.com>,
QEMU-devel Developers <qemu-devel@nongnu.org>,
Anthony Liguori <anthony@codemonkey.ws>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [Qemu-devel] [PATCH V6 04/15] Introduce -accel command option.
Date: Mon, 15 Nov 2010 13:56:31 +0100 [thread overview]
Message-ID: <4CE12DFF.8050109@redhat.com> (raw)
In-Reply-To: <C0AD410B-E24A-43B5-93A9-6B41D4CEEC93@suse.de>
On 11/15/2010 11:46 AM, Alexander Graf wrote:
> I take back my Acked-by. Sorry, I guess I should have read things in
> more detail first O_o. I still believe that this patch can go in
> before the others, but I'd at least like to see some comments on the
> (0) pointer thing:).
I agree, it kind of works by chance, (0) works but (1) wouldn't. Better
to define the function always.
Paolo
next prev parent reply other threads:[~2010-11-15 12:56 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 17:36 [Qemu-devel] [PATCH V6 00/15] xen device model support anthony.perard
2010-10-21 17:36 ` anthony.perard
2010-10-21 17:36 ` [Qemu-devel] [PATCH V6 01/15] xen: Replace some tab-indents with spaces (clean-up) anthony.perard
2010-10-21 17:36 ` anthony.perard
2010-10-21 17:36 ` [Qemu-devel] [PATCH V6 02/15] xen: Support new libxc calls from xen unstable anthony.perard
2010-10-21 17:36 ` anthony.perard
2010-11-15 10:25 ` [Qemu-devel] " Alexander Graf
2010-11-15 13:57 ` Stefano Stabellini
2010-11-15 13:57 ` Stefano Stabellini
2010-10-21 17:36 ` [Qemu-devel] [PATCH V6 03/15] xen: Add xen_machine_fv anthony.perard
2010-10-21 17:36 ` anthony.perard
2010-11-15 10:35 ` [Qemu-devel] " Alexander Graf
2010-11-15 11:00 ` Kevin Wolf
2010-11-15 13:57 ` Stefano Stabellini
2010-11-15 13:57 ` Stefano Stabellini
2010-10-21 17:36 ` [Qemu-devel] [PATCH V6 04/15] Introduce -accel command option anthony.perard
2010-10-21 17:36 ` anthony.perard
2010-11-15 10:38 ` [Qemu-devel] " Alexander Graf
2010-11-15 10:38 ` Alexander Graf
2010-11-15 10:46 ` Alexander Graf
2010-11-15 10:46 ` Alexander Graf
2010-11-15 12:56 ` Paolo Bonzini [this message]
2010-11-15 12:56 ` Paolo Bonzini
2010-11-15 14:27 ` Anthony PERARD
2010-11-15 14:27 ` Anthony PERARD
2010-11-15 14:47 ` [Qemu-devel] " Anthony PERARD
2010-11-15 14:51 ` Alexander Graf
2010-10-21 17:36 ` [Qemu-devel] [PATCH V6 05/15] xen: Add xen in -accel option anthony.perard
2010-10-21 17:36 ` anthony.perard
2010-11-15 10:49 ` [Qemu-devel] " Alexander Graf
2010-10-21 17:36 ` [Qemu-devel] [PATCH V6 06/15] xen: Add the Xen platform pci device anthony.perard
2010-10-21 17:36 ` anthony.perard
2010-11-15 10:57 ` [Qemu-devel] " Alexander Graf
2010-11-15 10:57 ` Alexander Graf
2010-10-21 17:36 ` [Qemu-devel] [PATCH V6 07/15] piix_pci: Introduces Xen specific call for irq anthony.perard
2010-10-21 17:36 ` anthony.perard
2010-10-21 17:36 ` [Qemu-devel] [PATCH V6 08/15] xen: add a 8259 Interrupt Controller anthony.perard
2010-10-21 17:36 ` anthony.perard
2010-10-21 17:36 ` [Qemu-devel] [PATCH V6 09/15] xen: Introduce the Xen mapcache anthony.perard
2010-10-21 17:36 ` anthony.perard
2010-11-15 11:43 ` [Qemu-devel] " Alexander Graf
2010-10-21 17:36 ` [Qemu-devel] [PATCH V6 10/15] configure: Always use 64bits target physical addresses with xen enabled anthony.perard
2010-10-21 17:36 ` anthony.perard
2010-10-21 17:36 ` [Qemu-devel] [PATCH V6 11/15] Introduce qemu_ram_ptr_unlock anthony.perard
2010-10-21 17:36 ` anthony.perard
2010-10-21 17:36 ` [Qemu-devel] [PATCH V6 12/15] vl.c: Introduce getter for shutdown_requested and reset_requested anthony.perard
2010-10-21 17:36 ` anthony.perard
2010-10-21 17:36 ` [Qemu-devel] [PATCH V6 13/15] xen: Initialize event channels and io rings anthony.perard
2010-10-21 17:36 ` anthony.perard
2010-10-21 17:36 ` [Qemu-devel] [PATCH V6 14/15] xen: Set running state in xenstore anthony.perard
2010-10-21 17:36 ` anthony.perard
2010-10-21 17:36 ` [Qemu-devel] [PATCH V6 15/15] acpi-piix4: Add Xen hypercall for sleep state anthony.perard
2010-10-21 17:36 ` anthony.perard
2010-10-26 14:24 ` [Qemu-devel] Re: [PATCH V6 00/15] xen device model support Anthony PERARD
2010-10-26 14:24 ` Anthony PERARD
2010-10-26 19:29 ` [Qemu-devel] " Blue Swirl
2010-10-26 20:00 ` Anthony Liguori
2010-10-26 20:00 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE12DFF.8050109@redhat.com \
--to=pbonzini@redhat.com \
--cc=Anthony.Perard@citrix.com \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.