[PATCH] libxc: fix tracing (broken with hypercall buffers)

[PATCH] libxc: fix tracing (broken with hypercall buffers)

[Andre Przywara]

[-- Attachment #1: Type: text/plain, Size: 359 bytes --]

Hi,

the attached patch makes Xen tracing work again, after the introduction 
of the hypercall buffers broke it. Just a missing line.

Thanks to Uwe Dannowski for reporting this.

Signed-off-by: Andre Przywara <andre.przywara@amd.com>

Regards,
Andre.

-- 
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
Tel: +49 351 448-3567-12

[-- Attachment #2: libxc_fix_tracing_hypercall_buffers.patch --]
[-- Type: text/x-patch, Size: 417 bytes --]

diff -r 87f248de5230 tools/libxc/xc_tbuf.c
--- a/tools/libxc/xc_tbuf.c	Mon Nov 15 09:31:38 2010 +0000
+++ b/tools/libxc/xc_tbuf.c	Tue Nov 16 10:11:39 2010 +0100
@@ -121,6 +121,7 @@
     uint64_t mask64 = mask;
 
     bytemap = xc_hypercall_buffer_alloc(xch, bytemap, sizeof(mask64));
+    if (bytemap == NULL)
     {
         PERROR("Could not allocate memory for xc_tbuf_set_cpu_mask hypercall");
         goto out;

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] libxc: fix tracing (broken with hypercall buffers)

[Ian Campbell]

On Tue, 2010-11-16 at 11:28 +0000, Andre Przywara wrote:
> Hi,
> 
> the attached patch makes Xen tracing work again, after the introduction 
> of the hypercall buffers broke it. Just a missing line.
> 
> Thanks to Uwe Dannowski for reporting this.
> 
> Signed-off-by: Andre Przywara <andre.przywara@amd.com>

How careless of me, thank you!

Acked-by: Ian Campbell <ian.campbell@citrix.com>

Re: [PATCH] libxc: fix tracing (broken with hypercall buffers) [and 1 more messages]

[Ian Jackson]

Andre Przywara writes ("[PATCH] libxc: fix tracing (broken with hypercall buffers)"):
> the attached patch makes Xen tracing work again, after the introduction 
> of the hypercall buffers broke it. Just a missing line.

Applied, thanks.

Ian.